Re: [Freeipa-devel] [PATCH 0035][Tests] Fix failing tests in test_ipalib/test_frontend

2016-08-17 Thread Martin Basti
On 17.08.2016 17:12, Milan Kubík wrote: On 08/17/2016 05:08 PM, Lenka Doudova wrote: On 08/17/2016 04:57 PM, Milan Kubík wrote: On 08/17/2016 04:45 PM, Lenka Doudova wrote: Hi, attached patch provides fix for 2 out of three failing tests in ipatests/test_ipalib/test_frontend.py.

Re: [Freeipa-devel] [PATCH 0034][Tests] Fix failing tests in test_ipalib/test_parameters

2016-08-17 Thread Martin Basti
On 17.08.2016 16:49, Milan Kubík wrote: On 08/17/2016 04:31 PM, Lenka Doudova wrote: Hi, attached patch fixes part of failing tests in ipatests/test_ipalib/test_parameters.py. Failures were caused mainly by thin client feature, sometimes by usage of unicode, which tests did not reflect.

Re: [Freeipa-devel] [PATCH 0215-0216] Child domain fixes for AD trust

2016-08-17 Thread Martin Babinsky
On 08/08/2016 01:27 PM, Alexander Bokovoy wrote: Hi! Attached two patches attempt to fix some of the issues we see with child domains. SSSD only 'sees' users from child domains if there is an ID range for each of them. However, after refactoring of trust code when external trust was

Re: [Freeipa-devel] [PATCH 0035][Tests] Fix failing tests in test_ipalib/test_frontend

2016-08-17 Thread Milan Kubík
On 08/17/2016 05:08 PM, Lenka Doudova wrote: On 08/17/2016 04:57 PM, Milan Kubík wrote: On 08/17/2016 04:45 PM, Lenka Doudova wrote: Hi, attached patch provides fix for 2 out of three failing tests in ipatests/test_ipalib/test_frontend.py. Failures were caused by changes related to thin

Re: [Freeipa-devel] [PATCH 0035][Tests] Fix failing tests in test_ipalib/test_frontend

2016-08-17 Thread Lenka Doudova
On 08/17/2016 04:57 PM, Milan Kubík wrote: On 08/17/2016 04:45 PM, Lenka Doudova wrote: Hi, attached patch provides fix for 2 out of three failing tests in ipatests/test_ipalib/test_frontend.py. Failures were caused by changes related to thin client implementation. Fix for the third

Re: [Freeipa-devel] [PATCH 0035][Tests] Fix failing tests in test_ipalib/test_frontend

2016-08-17 Thread Milan Kubík
On 08/17/2016 04:45 PM, Lenka Doudova wrote: Hi, attached patch provides fix for 2 out of three failing tests in ipatests/test_ipalib/test_frontend.py. Failures were caused by changes related to thin client implementation. Fix for the third failure will be provided later (after my PTO), as

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

2016-08-17 Thread Jan Cholasta
On 17.8.2016 16:33, Stanislav Laznicka wrote: On 08/17/2016 04:11 PM, Tibor Dudlak wrote: On Wed, Aug 17, 2016 at 3:36 PM, Stanislav Laznicka > wrote: On 08/16/2016 03:16 PM, Tibor Dudlak wrote: Hi, I have edited this patch after

Re: [Freeipa-devel] [PATCH 0034][Tests] Fix failing tests in test_ipalib/test_parameters

2016-08-17 Thread Milan Kubík
On 08/17/2016 04:31 PM, Lenka Doudova wrote: Hi, attached patch fixes part of failing tests in ipatests/test_ipalib/test_parameters.py. Failures were caused mainly by thin client feature, sometimes by usage of unicode, which tests did not reflect. Issues were discussed with Honza.

[Freeipa-devel] [PATCH 0035][Tests] Fix failing tests in test_ipalib/test_frontend

2016-08-17 Thread Lenka Doudova
Hi, attached patch provides fix for 2 out of three failing tests in ipatests/test_ipalib/test_frontend.py. Failures were caused by changes related to thin client implementation. Fix for the third failure will be provided later (after my PTO), as it will be more complicated fix. Lenka

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

2016-08-17 Thread Stanislav Laznicka
On 08/17/2016 03:50 PM, Pavel Vomacka wrote: On 08/17/2016 02:42 PM, Pavel Vomacka wrote: On 08/11/2016 07:49 PM, Petr Vobornik wrote: On 08/11/2016 07:21 PM, Martin Basti wrote: On 11.08.2016 18:57, Pavel Vomacka wrote: On 08/11/2016 02:00 PM, Petr Vobornik wrote: On 08/11/2016

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

2016-08-17 Thread Stanislav Laznicka
On 08/17/2016 03:58 PM, Alexander Bokovoy wrote: On Thu, 11 Aug 2016, Petr Vobornik wrote: On 08/11/2016 07:21 PM, Martin Basti wrote: On 11.08.2016 18:57, Pavel Vomacka wrote: On 08/11/2016 02:00 PM, Petr Vobornik wrote: On 08/11/2016 10:54 AM, Alexander Bokovoy wrote: On Thu, 11 Aug

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

2016-08-17 Thread Jan Cholasta
On 17.8.2016 16:36, Stanislav Laznicka wrote: On 08/17/2016 03:50 PM, Pavel Vomacka wrote: On 08/17/2016 02:42 PM, Pavel Vomacka wrote: On 08/11/2016 07:49 PM, Petr Vobornik wrote: On 08/11/2016 07:21 PM, Martin Basti wrote: On 11.08.2016 18:57, Pavel Vomacka wrote: On 08/11/2016

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

2016-08-17 Thread Jan Cholasta
On 17.8.2016 16:35, Stanislav Laznicka wrote: On 08/17/2016 03:58 PM, Alexander Bokovoy wrote: On Thu, 11 Aug 2016, Petr Vobornik wrote: On 08/11/2016 07:21 PM, Martin Basti wrote: On 11.08.2016 18:57, Pavel Vomacka wrote: On 08/11/2016 02:00 PM, Petr Vobornik wrote: On 08/11/2016 10:54

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

2016-08-17 Thread Stanislav Laznicka
On 08/17/2016 04:11 PM, Tibor Dudlak wrote: On Wed, Aug 17, 2016 at 3:36 PM, Stanislav Laznicka > wrote: On 08/16/2016 03:16 PM, Tibor Dudlak wrote: Hi, I have edited this patch after review. It should be okay now. Thank

[Freeipa-devel] [PATCH 0034][Tests] Fix failing tests in test_ipalib/test_parameters

2016-08-17 Thread Lenka Doudova
Hi, attached patch fixes part of failing tests in ipatests/test_ipalib/test_parameters.py. Failures were caused mainly by thin client feature, sometimes by usage of unicode, which tests did not reflect. Issues were discussed with Honza. Remaining failing tests should be fixed in scope of

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

2016-08-17 Thread Tibor Dudlak
On Wed, Aug 17, 2016 at 3:36 PM, Stanislav Laznicka wrote: > On 08/16/2016 03:16 PM, Tibor Dudlak wrote: > > Hi, > > I have edited this patch after review. It should be okay now. > > Thank you. > > On Thu, Aug 11, 2016 at 7:49 PM, Petr Vobornik > wrote:

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

2016-08-17 Thread Alexander Bokovoy
On Thu, 11 Aug 2016, Petr Vobornik wrote: On 08/11/2016 07:21 PM, Martin Basti wrote: On 11.08.2016 18:57, Pavel Vomacka wrote: On 08/11/2016 02:00 PM, Petr Vobornik wrote: On 08/11/2016 10:54 AM, Alexander Bokovoy wrote: On Thu, 11 Aug 2016, Jan Cholasta wrote: On 4.8.2016 17:27, Jan

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

2016-08-17 Thread Pavel Vomacka
On 08/17/2016 02:42 PM, Pavel Vomacka wrote: On 08/11/2016 07:49 PM, Petr Vobornik wrote: On 08/11/2016 07:21 PM, Martin Basti wrote: On 11.08.2016 18:57, Pavel Vomacka wrote: On 08/11/2016 02:00 PM, Petr Vobornik wrote: On 08/11/2016 10:54 AM, Alexander Bokovoy wrote: On Thu, 11 Aug

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

2016-08-17 Thread Stanislav Laznicka
On 08/16/2016 03:16 PM, Tibor Dudlak wrote: Hi, I have edited this patch after review. It should be okay now. Thank you. On Thu, Aug 11, 2016 at 7:49 PM, Petr Vobornik > wrote: On 08/11/2016 07:21 PM, Martin Basti wrote: > >

Re: [Freeipa-devel] [PATCH 688] server install: do not prompt for cert file PIN repeatedly

2016-08-17 Thread Jan Cholasta
On 17.8.2016 15:07, Pavel Vomacka wrote: On 08/17/2016 10:24 AM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza ACK. Thanks. Pushed to master: 4ee426a68ec60370eee6f5aec917ecce444840c7 -- Jan Cholasta -- Manage your

Re: [Freeipa-devel] [PATCH 688] server install: do not prompt for cert file PIN repeatedly

2016-08-17 Thread Pavel Vomacka
On 08/17/2016 10:24 AM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza ACK. -- Pavel^3 Vomacka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to

Re: [Freeipa-devel] [PATCH 0063] Raise error on topology disconnect/last-role-host removal during server uninstall

2016-08-17 Thread Martin Babinsky
On 08/17/2016 02:38 PM, Stanislav Laznicka wrote: On 08/17/2016 02:17 PM, Martin Babinsky wrote: On 08/16/2016 03:47 PM, Stanislav Laznicka wrote: On 08/15/2016 02:20 PM, Martin Babinsky wrote: On 08/15/2016 02:13 PM, Martin Babinsky wrote: On 08/12/2016 12:08 PM, Stanislav Laznicka wrote:

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

2016-08-17 Thread Pavel Vomacka
On 08/11/2016 07:49 PM, Petr Vobornik wrote: On 08/11/2016 07:21 PM, Martin Basti wrote: On 11.08.2016 18:57, Pavel Vomacka wrote: On 08/11/2016 02:00 PM, Petr Vobornik wrote: On 08/11/2016 10:54 AM, Alexander Bokovoy wrote: On Thu, 11 Aug 2016, Jan Cholasta wrote: On 4.8.2016 17:27,

Re: [Freeipa-devel] [PATCH 0063] Raise error on topology disconnect/last-role-host removal during server uninstall

2016-08-17 Thread Stanislav Laznicka
On 08/17/2016 02:17 PM, Martin Babinsky wrote: On 08/16/2016 03:47 PM, Stanislav Laznicka wrote: On 08/15/2016 02:20 PM, Martin Babinsky wrote: On 08/15/2016 02:13 PM, Martin Babinsky wrote: On 08/12/2016 12:08 PM, Stanislav Laznicka wrote: Hello, topology disconnect/last-role-host removal

Re: [Freeipa-devel] [PATCH 0063] Raise error on topology disconnect/last-role-host removal during server uninstall

2016-08-17 Thread Martin Babinsky
On 08/16/2016 03:47 PM, Stanislav Laznicka wrote: On 08/15/2016 02:20 PM, Martin Babinsky wrote: On 08/15/2016 02:13 PM, Martin Babinsky wrote: On 08/12/2016 12:08 PM, Stanislav Laznicka wrote: Hello, topology disconnect/last-role-host removal errors would just be logged during server

[Freeipa-devel] Announcing bind-dyndb-ldap version 10.1

2016-08-17 Thread Petr Spacek
The FreeIPA team is proud to announce bind-dyndb-ldap version 10.1. It can be downloaded from https://fedorahosted.org/released/bind-dyndb-ldap/ The new version has also been built for Fedora 24+: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ea30aafae1 Latest news: 10.1 [1]

Re: [Freeipa-devel] [PATCH 0112-7] Speeding up cli help

2016-08-17 Thread Jan Cholasta
On 17.8.2016 13:21, David Kupka wrote: On 08/08/16 13:26, Jan Cholasta wrote: On 4.8.2016 16:32, David Kupka wrote: On 03/08/16 16:33, Jan Cholasta wrote: On 3.8.2016 16:23, David Kupka wrote: On 21/07/16 10:12, Jan Cholasta wrote: Hi, On 20.7.2016 14:32, David Kupka wrote: On 15/07/16

Re: [Freeipa-devel] [PATCH] 0106, 0107: webui: add warning that only one CA server exists

2016-08-17 Thread Martin Basti
On 17.08.2016 12:54, Tomas Krizek wrote: ACK, works for me. On 08/16/2016 10:43 AM, Pavel Vomacka wrote: Hello, Please review attached patches which adds warning that only one CA server is installed. https://fedorahosted.org/freeipa/ticket/5828 -- Tomas Krizek master: *

Re: [Freeipa-devel] [PATCHES 681-682] cert: speed up cert-find, do not crash on invalid data in cert-find

2016-08-17 Thread Martin Basti
On 17.08.2016 10:27, Jan Cholasta wrote: On 16.8.2016 17:01, Martin Basti wrote: On 16.08.2016 17:00, Pavel Vomacka wrote: On 08/12/2016 08:29 AM, Jan Cholasta wrote: On 11.8.2016 19:43, Martin Basti wrote: On 11.08.2016 16:09, Jan Cholasta wrote: On 11.8.2016 14:27, Martin Basti

Re: [Freeipa-devel] [PATCH 0058] Make get_entries not ignore its size_limit argument

2016-08-17 Thread Stanislav Laznicka
On 08/11/2016 02:59 PM, Stanislav Laznicka wrote: On 08/11/2016 07:49 AM, Jan Cholasta wrote: On 2.8.2016 13:47, Stanislav Laznicka wrote: On 07/19/2016 09:20 AM, Jan Cholasta wrote: Hi, On 14.7.2016 14:36, Stanislav Laznicka wrote: Hello, This patch fixes

Re: [Freeipa-devel] [PATCH] 0207, 0218-0219 Solving trust conflicts and external trust topology fixes

2016-08-17 Thread Alexander Bokovoy
On Wed, 17 Aug 2016, Martin Babinsky wrote: On 08/17/2016 12:41 PM, Alexander Bokovoy wrote: On Wed, 17 Aug 2016, Martin Babinsky wrote: On 08/15/2016 06:06 PM, Alexander Bokovoy wrote: On Mon, 15 Aug 2016, Alexander Bokovoy wrote: Hi! Attached are trust-related patches. 0207 is a

Re: [Freeipa-devel] [PATCH] 0207, 0218-0219 Solving trust conflicts and external trust topology fixes

2016-08-17 Thread Alexander Bokovoy
On Wed, 17 Aug 2016, Petr Spacek wrote: On 17.8.2016 12:41, Alexander Bokovoy wrote: On Wed, 17 Aug 2016, Martin Babinsky wrote: On 08/15/2016 06:06 PM, Alexander Bokovoy wrote: On Mon, 15 Aug 2016, Alexander Bokovoy wrote: Hi! Attached are trust-related patches. 0207 is a pre-requisite. I

Re: [Freeipa-devel] [PATCH 0112-7] Speeding up cli help

2016-08-17 Thread David Kupka
On 08/08/16 13:26, Jan Cholasta wrote: On 4.8.2016 16:32, David Kupka wrote: On 03/08/16 16:33, Jan Cholasta wrote: On 3.8.2016 16:23, David Kupka wrote: On 21/07/16 10:12, Jan Cholasta wrote: Hi, On 20.7.2016 14:32, David Kupka wrote: On 15/07/16 12:53, David Kupka wrote: Hello! After

Re: [Freeipa-devel] [PATCH] 0207, 0218-0219 Solving trust conflicts and external trust topology fixes

2016-08-17 Thread Alexander Bokovoy
On Wed, 17 Aug 2016, Martin Babinsky wrote: Hi Alexander, patch 207: LGTM, but I have a feeling that the patch should be linked to both #6021 and #6076 so that it is not lost during backports. patch 218: ipalib/errors.py: 1.) I'm not sure if TrustTopologyConflictError should inherit from

Re: [Freeipa-devel] [PATCH] 0207, 0218-0219 Solving trust conflicts and external trust topology fixes

2016-08-17 Thread Martin Babinsky
On 08/17/2016 12:41 PM, Alexander Bokovoy wrote: On Wed, 17 Aug 2016, Martin Babinsky wrote: On 08/15/2016 06:06 PM, Alexander Bokovoy wrote: On Mon, 15 Aug 2016, Alexander Bokovoy wrote: Hi! Attached are trust-related patches. 0207 is a pre-requisite. I did send it before, it is

Re: [Freeipa-devel] [PATCH] 0207, 0218-0219 Solving trust conflicts and external trust topology fixes

2016-08-17 Thread Petr Spacek
On 17.8.2016 12:41, Alexander Bokovoy wrote: > On Wed, 17 Aug 2016, Martin Babinsky wrote: >> On 08/15/2016 06:06 PM, Alexander Bokovoy wrote: >>> On Mon, 15 Aug 2016, Alexander Bokovoy wrote: Hi! Attached are trust-related patches. 0207 is a pre-requisite. I did send it

Re: [Freeipa-devel] [PATCH] 0106, 0107: webui: add warning that only one CA server exists

2016-08-17 Thread Tomas Krizek
ACK, works for me. On 08/16/2016 10:43 AM, Pavel Vomacka wrote: Hello, Please review attached patches which adds warning that only one CA server is installed. https://fedorahosted.org/freeipa/ticket/5828 -- Tomas Krizek -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH] 0207, 0218-0219 Solving trust conflicts and external trust topology fixes

2016-08-17 Thread Alexander Bokovoy
On Wed, 17 Aug 2016, Martin Babinsky wrote: On 08/17/2016 12:13 PM, Martin Babinsky wrote: On 08/15/2016 06:06 PM, Alexander Bokovoy wrote: On Mon, 15 Aug 2016, Alexander Bokovoy wrote: Hi! Attached are trust-related patches. 0207 is a pre-requisite. I did send it before, it is

Re: [Freeipa-devel] [PATCH] 0207, 0218-0219 Solving trust conflicts and external trust topology fixes

2016-08-17 Thread Alexander Bokovoy
On Wed, 17 Aug 2016, Martin Babinsky wrote: On 08/15/2016 06:06 PM, Alexander Bokovoy wrote: On Mon, 15 Aug 2016, Alexander Bokovoy wrote: Hi! Attached are trust-related patches. 0207 is a pre-requisite. I did send it before, it is re-formatting of the ipaserver/dcerpc.py to be close to PEP8

[Freeipa-devel] [PATCH 0435-0436] Preparation for bind-dyndb-ldap 10.1 release

2016-08-17 Thread Petr Spacek
Hello, Pushed to master: d7ae9e2e0206f770dd252c81abdc8b1be3fd30e2 Bump NVR to 10.1. fddb67672e458c8cbb0fd7997e42f94adb288181 Update NEWS for upcoming 10.1 release. Tagged as v10.1. -- Petr^2 Spacek From fddb67672e458c8cbb0fd7997e42f94adb288181 Mon Sep 17 00:00:00 2001 From: Petr Spacek

Re: [Freeipa-devel] [PATCH 0158] DNS: allow to add forward zone to already broken sub-domain

2016-08-17 Thread Martin Basti
On 12.08.2016 17:10, Petr Spacek wrote: Hello, DNS: allow to add forward zone to already broken sub-domain Errors during DNS resolution might indicate that forwarder is the necessary configuration which is missing. Now we disallow adding a forwarder only if the zone is normally resolvable

Re: [Freeipa-devel] [PATCH] 0207, 0218-0219 Solving trust conflicts and external trust topology fixes

2016-08-17 Thread Martin Babinsky
On 08/17/2016 12:13 PM, Martin Babinsky wrote: On 08/15/2016 06:06 PM, Alexander Bokovoy wrote: On Mon, 15 Aug 2016, Alexander Bokovoy wrote: Hi! Attached are trust-related patches. 0207 is a pre-requisite. I did send it before, it is re-formatting of the ipaserver/dcerpc.py to be close to

Re: [Freeipa-devel] [PATCH] 0207, 0218-0219 Solving trust conflicts and external trust topology fixes

2016-08-17 Thread Martin Babinsky
On 08/15/2016 06:06 PM, Alexander Bokovoy wrote: On Mon, 15 Aug 2016, Alexander Bokovoy wrote: Hi! Attached are trust-related patches. 0207 is a pre-requisite. I did send it before, it is re-formatting of the ipaserver/dcerpc.py to be close to PEP8 requirements. 0218 is an automated trust

Re: [Freeipa-devel] [PATCH 0433-0434] Fix zone removal to respect forward configuration inheritance + Remove preserve_forwarding parameter from ldap_delete_zone2()

2016-08-17 Thread Petr Spacek
On 17.8.2016 10:26, Martin Sehnoutka wrote: > I checked the code. ACK Thanks, pushed to master: d6e413c4cc88101b902d73e05e1ce35e2fe4aedd Fix zone removal to respect forward configuration inheritance. b40976263460d8f4aeeec2a2a8f41cc54dcd0b28 Remove preserve_forwarding parameter from

Re: [Freeipa-devel] [PATCH 0433-0434] Fix zone removal to respect forward configuration inheritance + Remove preserve_forwarding parameter from ldap_delete_zone2()

2016-08-17 Thread Martin Sehnoutka
I checked the code. ACK Martin On 08/12/2016 12:37 PM, Petr Spacek wrote: > Hello, > > please review attached patch set. It fixes > https://fedorahosted.org/bind-dyndb-ldap/ticket/167 > > The code is also available on Github: >

[Freeipa-devel] [PATCH 688] server install: do not prompt for cert file PIN repeatedly

2016-08-17 Thread Jan Cholasta
Hi, the attached patch fixes . Honza -- Jan Cholasta From 5dc9e3a60dcdec0d9cd00bfc8819c1c01e2c4e0f Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Tue, 16 Aug 2016 17:34:06 +0200 Subject: [PATCH] server install: do not