jcholast commented on a pull request
"""
NACK, see my inline comments above.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/50#issuecomment-244858726
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contri
On 5.9.2016 10:42, Tomas Krizek wrote:
On 09/02/2016 09:05 AM, Florence Blanc-Renaud wrote:
On 09/02/2016 08:08 AM, Jan Cholasta wrote:
On 1.9.2016 19:37, Tomas Krizek wrote:
On 09/01/2016 03:58 PM, Florence Blanc-Renaud wrote:
Hi,
please find attached a patch for ipa-certupdate in CA-less
jcholast's pull request #34: " dns: prompt for missing record parts in CLI" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/34
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/34/head:pr34
g
On Mon, Aug 29, 2016 at 06:39:58PM +0200, Martin Babinsky wrote:
> On 08/23/2016 08:40 AM, Fraser Tweedale wrote:
> > Hi folks,
> >
> > Please review attached patch which fixes
> > https://fedorahosted.org/freeipa/ticket/6019.
> >
> > Thanks,
> > Fraser
> >
> >
> >
> Hi Fraser,
>
> I have cou
mbasti-rh commented on a pull request
"""
IMO api version should be incremented, otherwise works for me
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/34#issuecomment-244784027
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/li
On Tue, Aug 30, 2016 at 08:48:58AM +0200, Jan Cholasta wrote:
> On 29.8.2016 07:57, Fraser Tweedale wrote:
> > On Fri, Aug 26, 2016 at 10:41:37AM +0200, Jan Cholasta wrote:
> > > Hi,
> > >
> > > On 22.7.2016 07:18, Fraser Tweedale wrote:
> > > > While I was poking around SAN-processing code, I dec
mbasti-rh's pull request #53: "Fix ScriptError to always return string from
__str__" label *pushed* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/53
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freei
mbasti-rh commented on a pull request
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/00d43095da211f542189c95c88fc2e2c32e75565
ipa-4-4:
https://fedorahosted.org/freeipa/changeset/26175556b46bde9e83699abdd36c5644ec7512ba
"""
See the full comment at
https://github.com/freeipa
mbasti-rh's pull request #53: "Fix ScriptError to always return string from
__str__" was closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/53
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/53/head:pr
mbasti-rh's pull request #53: "Fix ScriptError to always return string from
__str__" label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/53
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-
mbasti-rh commented on a pull request
"""
Fixed upstream
ipa-4-3:
https://fedorahosted.org/freeipa/changeset/2e27b7077d280447dbf526b567566101d4c800c7
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/57#issuecomment-244779751
--
Manage your subscription for the Freeipa-devel m
tiran's pull request #57: "Use RSA-OAEP instead of RSA PKCS#1 v1.5" was closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/57
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/57/head:pr57
git checkout pr
tiran's pull request #57: "Use RSA-OAEP instead of RSA PKCS#1 v1.5" label
*pushed* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/57
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribu
mbasti-rh commented on a pull request
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/4ae4d0d6909e99892442a170288f0eee9610d1c2
ipa-4-4:
https://fedorahosted.org/freeipa/changeset/71e7cb124d021f976eebb6e99fc012becf94a9b6
"""
See the full comment at
https://github.com/freeipa
tiran's pull request #56: "Use RSA-OAEP instead of RSA PKCS#1 v1.5" label
*pushed* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/56
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribu
tiran's pull request #56: "Use RSA-OAEP instead of RSA PKCS#1 v1.5" was closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/56
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/56/head:pr56
git checkout pr
On Fri, Aug 26, 2016 at 10:28:58AM +0200, Jan Cholasta wrote:
> On 19.8.2016 13:11, Fraser Tweedale wrote:
> > Bump for review.
> >
> > On Wed, Aug 17, 2016 at 12:09:39AM +1000, Fraser Tweedale wrote:
> > > On Tue, Aug 16, 2016 at 08:10:08AM +0200, Jan Cholasta wrote:
> > > > On 16.8.2016 07:24, F
mbasti-rh commented on a pull request
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/a3d178b86ddff9335228d99fe06e8fc89a00235a
ipa-4-4:
https://fedorahosted.org/freeipa/changeset/136a649a9e1da26e28b7151af061f8094b0f1d22
"""
See the full comment at
https://github.com/freeipa
jcholast's pull request #54: "cli: use full name when executing a command"
label *pushed* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/54
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
C
jcholast's pull request #54: "cli: use full name when executing a command" was
closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/54
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/54/head:pr54
git che
tiran's pull request #56: "Use RSA-OAEP instead of RSA PKCS#1 v1.5" label *ack*
has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/56
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute
tiran's pull request #57: "Use RSA-OAEP instead of RSA PKCS#1 v1.5" label *ack*
has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/57
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute
jcholast's pull request #54: "cli: use full name when executing a command"
label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/54
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Cont
On Mon, Sep 05, 2016 at 11:59:11PM +1000, Fraser Tweedale wrote:
> On Tue, Aug 30, 2016 at 10:39:16AM +0200, Jan Cholasta wrote:
> > Hi,
> >
> > On 26.8.2016 07:42, Fraser Tweedale wrote:
> > > On Fri, Aug 26, 2016 at 03:37:17PM +1000, Fraser Tweedale wrote:
> > > > Hi all,
> > > >
> > > > Attach
mbasti-rh's pull request #58: "Ip addr validation" was opened
PR body:
"""
"""
See the full pull-request at https://github.com/freeipa/freeipa/pull/58
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/58/head:pr58
git checkout
On Tue, Aug 30, 2016 at 10:39:16AM +0200, Jan Cholasta wrote:
> Hi,
>
> On 26.8.2016 07:42, Fraser Tweedale wrote:
> > On Fri, Aug 26, 2016 at 03:37:17PM +1000, Fraser Tweedale wrote:
> > > Hi all,
> > >
> > > Attached patch fixes https://fedorahosted.org/freeipa/ticket/6221.
> > > It depends on
tiran's pull request #57: "Use RSA-OAEP instead of RSA PKCS#1 v1.5" was opened
PR body:
"""
jwcrypto's RSA1-5 (PKCS#1 v1.5) is vulnerable to padding oracle
side-channel attacks. OAEP (PKCS#1 v2.0) is a safe, more modern
alternative.
https://fedorahosted.org/freeipa/ticket/6278
Signed-off-by: Chr
tiran's pull request #56: "Use RSA-OAEP instead of RSA PKCS#1 v1.5" was opened
PR body:
"""
jwcrypto's RSA1-5 (PKCS#1 v1.5) is vulnerable to padding oracle
side-channel attacks. OAEP (PKCS#1 v2.0) is a safe, more modern
alternative.
https://fedorahosted.org/freeipa/ticket/6278
Signed-off-by: Chr
mbasti-rh's pull request #55: "Fix parse errors with link-local addresses" was
opened
PR body:
"""
Link-local addresses received from netifaces contains '%suffix' that
causes parse error in IPNetwork class. We must remove %suffix before
it us used in IPNetwork objects.
https://fedorahosted.org/f
Hi guys,
Finally the ca-less tests are stable. Here in the attachment is the full
set of necessary patches.
On 08/09/2016 10:57 AM, Oleg Fayans wrote:
Hi all,
Bump for the review of the 0013 patch. The script it addresses can be
reused in some WebUI tests - one more reason to have it review
jcholast's pull request #54: "cli: use full name when executing a command" was
opened
PR body:
"""
Fixes the CLI not to always call the default version of a command even when
the version was explicitly specified.
https://fedorahosted.org/freeipa/ticket/6279
"""
See the full pull-request at http
jcholast's pull request #34: " dns: prompt for missing record parts in CLI" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/34
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/34/head:pr34
g
mbasti-rh's pull request #53: "Fix ScriptError to always return string from
__str__" was opened
PR body:
"""
Use super for proper handling of exceptions. msg property was added due
compatibility with the current code.
https://fedorahosted.org/freeipa/ticket/6294
"""
See the full pull-request at
ofayans's pull request #52: "Removed incorrect check for returncode" label
*ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/52
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute
mirielka's pull request #43: "Tests: Fix regex errors in integration trust
tests" was synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/43
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/43/head:
ofayans commented on a pull request
"""
The commit message was updated
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/52#issuecomment-244720426
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute t
ofayans's pull request #52: "Removed incorrect check for returncode" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/52
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/52/head:pr52
git chec
On 27.8.2016 22:40, Ben Lipton wrote:
On 08/25/2016 04:11 PM, Rob Crittenden wrote:
Ben Lipton wrote:
On 08/23/2016 03:54 AM, Jan Cholasta wrote:
On 8.8.2016 22:23, Ben Lipton wrote:
On 07/25/2016 07:45 AM, Jan Cholasta wrote:
On 25.7.2016 13:11, Alexander Bokovoy wrote:
On Mon, 25 Jul 2016
On 09/02/2016 09:05 AM, Florence Blanc-Renaud wrote:
On 09/02/2016 08:08 AM, Jan Cholasta wrote:
On 1.9.2016 19:37, Tomas Krizek wrote:
On 09/01/2016 03:58 PM, Florence Blanc-Renaud wrote:
Hi,
please find attached a patch for ipa-certupdate in CA-less deployment.
https://fedorahosted.org/fre
jcholast commented on a pull request
"""
NACK on the while loop which could loop infinitely.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/47#issuecomment-244690568
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/free
dkupka's pull request #47: "schema cache: Store and check info for pre-schema
servers" label *ack* has been removed
See the full pull-request at https://github.com/freeipa/freeipa/pull/47
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/free
mbasti-rh commented on a pull request
"""
ACK: Removed incorrect check for returncode
NACK: Several fixes in replica_promotion tests -- missing explanation in
commit messages why this change is needed, if changes are unrelated should be
in multiple patches
ACK: Changed addressing to the client
tomaskrizek commented on a pull request
"""
Works as expected.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/47#issuecomment-244686988
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIP
dkupka's pull request #47: "schema cache: Store and check info for pre-schema
servers" label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/47
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeip
mbasti-rh's pull request #48: "[4.4] Set zanata project-version fo 4.4 branch"
was closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/48
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/48/head:pr48
git
martbab commented on a pull request
"""
Fixed upstream
ipa-4-4:
https://fedorahosted.org/freeipa/changeset/362162aba5ce83043cb3947e453234e933266f4b
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/48#issuecomment-244677238
--
Manage your subscription for the Freeipa-devel mai
mbasti-rh's pull request #48: "[4.4] Set zanata project-version fo 4.4 branch"
label *pushed* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/48
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-dev
mbasti-rh's pull request #48: "[4.4] Set zanata project-version fo 4.4 branch"
label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/48
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
martbab's pull request #51: "Fix failing negative tests for deprecated params"
was closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/51
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/51/head:pr51
git
martbab commented on a pull request
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/82e754e9c5e46317c7c060d9bc9c00ee259101a1
ipa-4-4:
https://fedorahosted.org/freeipa/changeset/4d4ea09a82cf9234a0f3cec43fd1551acae5780c
"""
See the full comment at
https://github.com/freeipa/f
martbab's pull request #51: "Fix failing negative tests for deprecated params"
label *pushed* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/51
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-dev
martbab's pull request #46: "Always fetch forest info from root DCs when
establishing two-way trust" was closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/46
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
martbab's pull request #46: "Always fetch forest info from root DCs when
establishing two-way trust" label *pushed* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/46
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailma
martbab commented on a pull request
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/33f8685513e06f6a398036a78407d61c3ac2db86
https://fedorahosted.org/freeipa/changeset/c789b17b2e28ed9008fee076a0db72fe90f7e93f
https://fedorahosted.org/freeipa/changeset/4ca671788cc54a00de6a55a2
ofayans's pull request #52: "Removed incorrect check for returncode" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/52
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/52/head:pr52
git chec
ofayans's pull request #52: "Removed incorrect check for returncode" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/52
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/52/head:pr52
git chec
ofayans's pull request #52: "Removed incorrect check for returncode" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/52
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/52/head:pr52
git chec
57 matches
Mail list logo