URL: https://github.com/freeipa/freeipa/pull/69
Title: #69: Fix ipa-replica-install with RHEL 6.8 master
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/69
Author: flo-renaud
Title: #69: Fix ipa-replica-install with RHEL 6.8 master
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/69/head:pr69
git checkout pr69
--
URL: https://github.com/freeipa/freeipa/pull/69
Title: #69: Fix ipa-replica-install with RHEL 6.8 master
flo-renaud commented:
"""
Please ignore this PR as the issue has been fixed in IPA 3.0 (in
ipa-replica-prepare).
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/69
Title: #69: Fix ipa-replica-install with RHEL 6.8 master
pvoborni commented:
"""
Is it still needed? Seems that fixing IPA 3.0 fixes the issue.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/69#issuecomment-247603640
--
URL: https://github.com/freeipa/freeipa/pull/82
Author: mbasti-rh
Title: #82: Fix regexp in user/group name
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/82/head:pr82
git checkout pr82
From
URL: https://github.com/freeipa/freeipa/pull/89
Title: #89: client: remove hard dependency on pam_krb5
stlaz commented:
"""
Works as expected.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/89#issuecomment-247579650
--
Manage your subscription for the Freeipa-devel
URL: https://github.com/freeipa/freeipa/pull/89
Title: #89: client: remove hard dependency on pam_krb5
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/82
Title: #82: Fix regexp in user/group name
stlaz commented:
"""
Sure. But from what I see, this patch may possibly break idviews plugin for
users of username of about 255 characters (see idoverrideuser - 'uid'), same
for groups (with 'cn' ofc).
abbra commented on a pull request
"""
'uid' in user object and 'cn' in group object have meaning in POSIX
environments. 'cn' in other objects is not subject for strict limits.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/82#issuecomment-247541965
--
Manage your
stlaz commented on a pull request
"""
Would the gist of this patch also apply to any of idviews, servicedelegation or
topology plugins where a similar or slightly different regexp is used? Could we
rather have the regexp as a constant somewhere so it does not have to be
changed at all places
Sorry for stealing your thread, but you started asking about github
review emails :)
Standard review inline comments are disabled on purpose, each comment
generates one email, so we decided that is better after review to write
a regular comment "NACK, please see inline comments" or so.
I
Akasurde's pull request #83: "Added a fix for setting Priority as required
field " label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/83
--
Manage your subscription for the Freeipa-devel mailing list:
Akasurde's pull request #83: "Added a fix for setting Priority as required
field " was synchronized
See the full pull-request at https://github.com/freeipa/freeipa/pull/83
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
Akasurde's pull request #83: "Added a fix for setting Priority as required
field " was edited
See the full pull-request at https://github.com/freeipa/freeipa/pull/83
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
mbasti-rh commented on a pull request
"""
@Akasurde I said we need a *new* ticket for it. I opened one for you
https://fedorahosted.org/freeipa/ticket/6335
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/83#issuecomment-247530662
--
Manage your subscription for the
15 matches
Mail list logo
