[Freeipa-devel] [freeipa PR#117][comment] Make ipa-replica-install run in interactive mode

2016-10-14 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/117 Title: #117: Make ipa-replica-install run in interactive mode stlaz commented: """ @simo5: There is a LOT of checking of various combinations of options in ipa-client-install, not even mentioning IPADiscovery in interactive mode. It does not

[Freeipa-devel] [freeipa PR#117][comment] Make ipa-replica-install run in interactive mode

2016-10-14 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/117 Title: #117: Make ipa-replica-install run in interactive mode simo5 commented: """ @stlaz I do not understand the rationale. Ideally the ipa-replica-install command gathers all necessary info and ipa-client-install is always run in unattended

[Freeipa-devel] [freeipa PR#116][comment] Add fix for no-hbac-allow option in server install

2016-10-14 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/116 Title: #116: Add fix for no-hbac-allow option in server install Akasurde commented: """ @tomaskrizek @stlaz @jcholast Thanks for review comments. """ See the full comment at https://github.com/freeipa/freeipa/pull/116#issuecomment-253852546 --

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-10-14 Thread Oleg Fayans
Hi, Martin, Right. The point is to have a test that emulates the real-world usecase of this feature. Which is AD integration. No xmlrpc test is able to do so. Of course we can automate testing of CLI options using XMLRPC. But that would not mean we do not need an integration test for the

[Freeipa-devel] [freeipa PR#165][comment] Tests: Verify that cert-find show CA without --all

2016-10-14 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/165 Title: #165: Tests: Verify that cert-find show CA without --all pvoborni commented: """ that reminds me this regression in cert-show: https://fedorahosted.org/freeipa/ticket/6022#comment:6 """ See the full comment at

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-10-14 Thread Martin Babinsky
On 10/14/2016 03:48 PM, Oleg Fayans wrote: So, did I understand correctly, that there would be 2 patches: one containing test for basic idoverrides functionality without AD-integration, and the second one - with AD-integration and an sssd check, correct? I guess, the

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-10-14 Thread Oleg Fayans
So, did I understand correctly, that there would be 2 patches: one containing test for basic idoverrides functionality without AD-integration, and the second one - with AD-integration and an sssd check, correct? I guess, the

[Freeipa-devel] [freeipa PR#165][comment] Tests: Verify that cert-find show CA without --all

2016-10-14 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/165 Title: #165: Tests: Verify that cert-find show CA without --all tomaskrizek commented: """ The same check should be also performed for `cert-show`. The patch also added CA to `cert-request` command, but testing it is probably not worth the

[Freeipa-devel] [freeipa PR#116][+ack] Add fix for no-hbac-allow option in server install

2016-10-14 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/116 Title: #116: Add fix for no-hbac-allow option in server install Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#116][comment] Add fix for no-hbac-allow option in server install

2016-10-14 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/116 Title: #116: Add fix for no-hbac-allow option in server install tomaskrizek commented: """ LGTM, thanks for the patch! """ See the full comment at https://github.com/freeipa/freeipa/pull/116#issuecomment-253785497 -- Manage your subscription

[Freeipa-devel] [freeipa PR#145][edited] Refactoring: LDAP Connection Management

2016-10-14 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/145 Author: tomaskrizek Title: #145: Refactoring: LDAP Connection Management Action: edited Changed field: title Original value: """ [WIP] Refactoring: LDAP Connection Management """ -- Manage your subscription for the Freeipa-devel mailing

[Freeipa-devel] [freeipa PR#145][edited] [WIP] Refactoring: LDAP Connection Management

2016-10-14 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/145 Author: tomaskrizek Title: #145: [WIP] Refactoring: LDAP Connection Management Action: edited Changed field: body Original value: """ PREVIEW, please don't merge yet Design doc:

[Freeipa-devel] [freeipa PR#145][comment] [WIP] Refactoring: LDAP Connection Management

2016-10-14 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: [WIP] Refactoring: LDAP Connection Management tomaskrizek commented: """ I made some changes and removed the connection manager, as discussed with sub-team. The refactoring is not finished, but these changes can be pushed to master

[Freeipa-devel] [freeipa PR#116][edited] Add fix for no-hbac-allow option in server install

2016-10-14 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/116 Author: Akasurde Title: #116: Add fix for no-hbac-allow option in server install Action: edited Changed field: title Original value: """ Added fix for no-hbac-allow option in server install script """ -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#116][synchronized] Added fix for no-hbac-allow option in server install script

2016-10-14 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/116 Author: Akasurde Title: #116: Added fix for no-hbac-allow option in server install script Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/116/head:pr116 git

[Freeipa-devel] [bind-dyndb-ldap PR#2][closed] fix ldif syntax and add idnsTemplateAttribute

2016-10-14 Thread pspacek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/2 Author: stutiredboy Title: #2: fix ldif syntax and add idnsTemplateAttribute Action: closed To pull the PR as Git branch: git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap git fetch ghbind-dyndb-ldap

[Freeipa-devel] [bind-dyndb-ldap PR#2][comment] fix ldif syntax and add idnsTemplateAttribute

2016-10-14 Thread pspacek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/2 Title: #2: fix ldif syntax and add idnsTemplateAttribute pspacek commented: """ Thanks! I've commited the fix as 17711141882aca3847a5daba2292bcbcc471ec63. """ See the full comment at

[Freeipa-devel] [freeipa PR#127][comment] Move ipa-otpd to $libexecdir/ipa, purge ffextension

2016-10-14 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/127 Title: #127: Move ipa-otpd to $libexecdir/ipa, purge ffextension martbab commented: """ I have opened a bug against selinux-policy for this https://bugzilla.redhat.com/show_bug.cgi?id=1384872 """ See the full comment at

[Freeipa-devel] [freeipa PR#165][opened] Tests: Verify that cert-find show CA without --all

2016-10-14 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/165 Author: mirielka Title: #165: Tests: Verify that cert-find show CA without --all Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6151 """ To pull the PR as Git branch: git remote add ghfreeipa

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-10-14 Thread Oleg Fayans
Right you are! I am sorry. On 10/13/2016 06:10 PM, Martin Basti wrote: I think that you forgot to squash commits. Patch 47 doesn't apply On 13.10.2016 14:01, Oleg Fayans wrote: Hi Martin, Thanks for the review. With disabling directory server it works as well, thanks for the hint. Also I

[Freeipa-devel] [freeipa PR#127][comment] Move ipa-otpd to $libexecdir/ipa, purge ffextension

2016-10-14 Thread tjaalton
URL: https://github.com/freeipa/freeipa/pull/127 Title: #127: Move ipa-otpd to $libexecdir/ipa, purge ffextension tjaalton commented: """ that's possible, I'm unable to find where to fix that though """ See the full comment at https://github.com/freeipa/freeipa/pull/127#issuecomment-253752558

[Freeipa-devel] [freeipa PR#126][synchronized] Fix ipa migrate-ds when it finds a search reference

2016-10-14 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/126 Author: flo-renaud Title: #126: Fix ipa migrate-ds when it finds a search reference Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/126/head:pr126 git

[Freeipa-devel] [freeipa PR#164][comment] Trust AD cleanup

2016-10-14 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/164 Title: #164: Trust AD cleanup mirielka commented: """ Thanks for suggestion, I added separate commit for this. """ See the full comment at https://github.com/freeipa/freeipa/pull/164#issuecomment-253735992 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#164][synchronized] Trust AD cleanup

2016-10-14 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/164 Author: mirielka Title: #164: Trust AD cleanup Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/164/head:pr164 git checkout pr164 From

[Freeipa-devel] [freeipa PR#164][comment] Trust AD cleanup

2016-10-14 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/164 Title: #164: Trust AD cleanup martbab commented: """ You can disable the false positive error globally by adding file_exists method as a member of transport object in pylint_plugins.py line 240 """ See the full comment at

[Freeipa-devel] [freeipa PR#164][synchronized] Trust AD cleanup

2016-10-14 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/164 Author: mirielka Title: #164: Trust AD cleanup Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/164/head:pr164 git checkout pr164 From

[Freeipa-devel] [freeipa PR#164][opened] Trust AD cleanup

2016-10-14 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/164 Author: mirielka Title: #164: Trust AD cleanup Action: opened PR body: """ Adding operations that remove test related trust information from AD machines. Package samba-client is necessary for this operation, hence tests are skipped if the