URL: https://github.com/freeipa/freeipa/pull/207
Author: Akasurde
Title: #207: Provide user hint about IP address in IPA install
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/207/head:pr207
git checkout
URL: https://github.com/freeipa/freeipa/pull/207
Title: #207: Provide user hint about IP address in IPA install
mbasti-rh commented:
"""
May I propose following?
```
+msg_first = "Please provide the IP address to be used for this host name"
+msg_other = (
+"Additional IP address
URL: https://github.com/freeipa/freeipa/pull/207
Author: Akasurde
Title: #207: Provide user hint about IP address in IPA install
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/207/head:pr207
git checkout
URL: https://github.com/freeipa/freeipa/pull/145
Title: #145: Refactoring: LDAP Connection Management
mbasti-rh commented:
"""
LGTM except my previous comment, lets wait for test results
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/145#issuecomment-258201939
--
Manage
URL: https://github.com/freeipa/freeipa/pull/145
Title: #145: Refactoring: LDAP Connection Management
mbasti-rh commented:
"""
I don't like `_missing` value in ldap2 class for time and sizelimit
IIUC then `_missing` means that by default the search is unlimited. Why we just
dont create
Hi Martin,
The commit message was updated with the correct ticket link
Thanks for review!
On 11/03/2016 04:22 PM, Martin Basti wrote:
almost ACK, but the ticket in commit message is closed as invalid. So
I'm quite puzzled now what to do.
On 03.11.2016 13:28, Oleg Fayans wrote:
ping for
almost ACK, but the ticket in commit message is closed as invalid. So
I'm quite puzzled now what to do.
On 03.11.2016 13:28, Oleg Fayans wrote:
ping for review
On 10/19/2016 04:54 PM, Oleg Fayans wrote:
Hi Martin,
Thanks for the review. Fixed both issues.
$ ipa-run-tests
URL: https://github.com/freeipa/freeipa/pull/207
Title: #207: Provide user hint about IP address in IPA install
rsd commented:
"""
This happens the case where the user keeps entering a IP address and the UI
asks again as if it were ignored.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/207
Title: #207: Provide user hint about IP address in IPA install
mbasti-rh commented:
"""
NACK, please see inline comment
I'd use 2 different messages:
1st IP: "Please provide the IP address to be used for this host name:"
2nd and more IP:
URL: https://github.com/freeipa/freeipa/pull/145
Title: #145: Refactoring: LDAP Connection Management
tomaskrizek commented:
"""
I've also updated the design document and described the correct usage of LDAP
connections after these changes:
ping for review
On 10/19/2016 04:54 PM, Oleg Fayans wrote:
Hi Martin,
Thanks for the review. Fixed both issues.
$ ipa-run-tests test_integration/test_topology.py -k TestCASpecificRUVs
WARNING: Couldn't write lextab module 'pycparser.lextab'. [Errno 13]
Permission denied: 'lextab.py'
WARNING:
URL: https://github.com/freeipa/freeipa/pull/202
Author: martbab
Title: #202: ipa-getkeytab enhancements
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/202/head:pr202
git checkout pr202
From
LGTM
On 03.11.2016 09:42, Oleg Fayans wrote:
One more ping for review
On 10/27/2016 02:21 PM, Oleg Fayans wrote:
ping for review
On 10/25/2016 10:24 AM, Oleg Fayans wrote:
Integration part of the tests is ready. 2 tests:
1. Adds a cert to idoverride of a windows user
2. sssd part - looks
URL: https://github.com/freeipa/freeipa/pull/208
Title: #208: Tests: Fix integration sudo test
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/208
Title: #208: Tests: Fix integration sudo test
lslebodn commented:
"""
All versions of Fedora have sudo 1.8.18.
And thank you very much for nice/verbose explanation in commit message
ACK
"""
See the full comment at
One more ping for review
On 10/27/2016 02:21 PM, Oleg Fayans wrote:
ping for review
On 10/25/2016 11:29 AM, Oleg Fayans wrote:
The patch was rebased to be able to apply on top of latest version of
certs in idoverrides patch. As before, it requires patches NN 0049 and
0059 to apply
On
One more ping for review
On 10/27/2016 02:21 PM, Oleg Fayans wrote:
ping for review
On 10/25/2016 10:24 AM, Oleg Fayans wrote:
Integration part of the tests is ready. 2 tests:
1. Adds a cert to idoverride of a windows user
2. sssd part - looks up user by his certificate using dbus-sssd
17 matches
Mail list logo
