URL: https://github.com/freeipa/freeipa/pull/669
Title: #669: server: make sure we test for sss_nss_getlistbycert
tiran commented:
"""
AC_CHECK_LIB only checks for functions in libs. Compilation may still fail if
header files and library are not in sync. IMHO we don't hav
URL: https://github.com/freeipa/freeipa/pull/670
Author: tiran
Title: #670: [Py3] session storage parameters must be bytes
Action: opened
PR body:
"""
Fixes TypeError: bytes or integer address expected instead of str instance
Signed-off-by: Christian Heimes <chei...@redhat
URL: https://github.com/freeipa/freeipa/pull/593
Author: tiran
Title: #593: Add make patchcheck for developers
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/593/head:pr593
git checkout pr593
From
URL: https://github.com/freeipa/freeipa/pull/490
Title: #490: certdb: use certutil and match_hostname for cert verification
tiran commented:
"""
github magic is bad magic :/ It still shows up as 'conflicting' for me.
I'll try to find time to review the issue tomorrow, Thursday l
URL: https://github.com/freeipa/freeipa/pull/517
Title: #517: Use Custodia 0.3.1 features
tiran commented:
"""
Custodia 0.3.1 also fixes https://github.com/latchset/custodia/issues/135 (KEM
requests with whitespace in key name fail). The bug has been reported by
@a
URL: https://github.com/freeipa/freeipa/pull/517
Author: tiran
Title: #517: Use Custodia 0.3.1 features
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/517/head:pr517
git checkout pr517
From
URL: https://github.com/freeipa/freeipa/pull/623
Title: #623: client install: do not assume /etc/krb5.conf.d exists
tiran commented:
"""
**Practicality beats purity**
Let's define ```/etc/krb5.conf.d``` as part of our API and don't waste more
time on shaving yet another yak. @t
URL: https://github.com/freeipa/freeipa/pull/623
Title: #623: client install: do not assume /etc/krb5.conf.d exists
tiran commented:
"""
The ipa-certauth plugin now starts to rely on the existence of
```/etc/krb5.conf.d```:
```
%config(noreplace) %{_sysconfdir}/krb5.conf
URL: https://github.com/freeipa/freeipa/pull/517
Title: #517: Use Custodia 0.3.1 features
tiran commented:
"""
F25 scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=18643521
```
$ fedpkg clone custodia
$ cd custodia
$ fedpkg switch-branch master
$ fedpkg scrat
URL: https://github.com/freeipa/freeipa/pull/517
Title: #517: Use Custodia 0.3.1 features
tiran commented:
"""
0.3.1 with fix for the space in URLs is out.
* rawhide build https://koji.fedoraproject.org/koji/taskinfo?taskID=18637684
* F26 scratch build https://koji.fedorap
URL: https://github.com/freeipa/freeipa/pull/517
Author: tiran
Title: #517: Use Custodia 0.3 features
Action: edited
Changed field: title
Original value:
"""
Use Custodia 0.3 features
"""
--
Manage your subscription for the Freeipa-devel mailing list:
URL: https://github.com/freeipa/freeipa/pull/657
Title: #657: configure: fix --disable-server with certauth plugin
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/657
Title: #657: configure: fix --disable-server with certauth plugin
tiran commented:
"""
LGTM
I verified that the PR fixes
* --disable-server
* --enable-server with old version of krb5 that does not have
```krb5/certauth_plugi
URL: https://github.com/freeipa/freeipa/pull/655
Title: #655: httpinstance.disable_system_trust: Don't fail if module 'Root
Certs' …
tiran commented:
"""
@stlaz The broad except also catches and ignores typos in the command line or
missing ```modutil``` binary.
"&quo
URL: https://github.com/freeipa/freeipa/pull/618
Title: #618: [WIP] Tox testing support for client wheel packages
tiran commented:
"""
Tox testing should also be integrated into Travis CI to catch bugs like
https://pagure.io/freeipa/issue/6816. The tox script will automatically
URL: https://github.com/freeipa/freeipa/pull/616
Title: #616: Simplify KRA transport cert cache
tiran commented:
"""
I did not miss
https://github.com/freeipa/freeipa/pull/616#issuecomment-287739826
"""
See the full comment at
https://github.com/freeipa
URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: [WIP] Tox testing support for client wheel packages
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout
URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: [WIP] Tox testing support for client wheel packages
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout
URL: https://github.com/freeipa/freeipa/pull/649
Title: #649: Session cookie storage and handling fixes
tiran commented:
"""
@simo5 I left some comments.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/649#issuecomment-288971205
--
Manage you
URL: https://github.com/freeipa/freeipa/pull/517
Title: #517: Use Custodia 0.3 features
tiran commented:
"""
Full error message: ```code 406, message Key name
ca/caSigningCert%20cert-pki-ca does not match subject ca/caSigningCert
cert-pki-ca```
Custodia issue https://gith
URL: https://github.com/freeipa/freeipa/pull/517
Title: #517: Use Custodia 0.3 features
tiran commented:
"""
Please custodia logs (```journalctl -u ipa-custodia``` and
```/var/log/ipa-custodia.audit.log```) from the server.
"""
See the full comment at
https://g
URL: https://github.com/freeipa/freeipa/pull/636
Author: tiran
Title: #636: [Py3] Fix ipatests.util doc tests
Action: opened
PR body:
"""
Doctests of ipatests.util fail under Python 3.
The old test scenario does no longer work on Python 3 since u'how are you'
and 'how are you'
URL: https://github.com/freeipa/freeipa/pull/626
Title: #626: Move helper code for integration plugin
tiran commented:
"""
@apophys has created ticket https://pagure.io/freeipa/issue/6798 and I have
updated all commit messages.
"""
See the full comment at
http
URL: https://github.com/freeipa/freeipa/pull/626
Author: tiran
Title: #626: Move helper code for integration plugin
Action: edited
Changed field: body
Original value:
"""
fd1b4f6ec9a349196d5df510008c4745f0b1fb84 broke integration tests because the
integration helper im
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
PR is blocked by #613
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/397#issuecom
URL: https://github.com/freeipa/freeipa/pull/517
Title: #517: Use Custodia 0.3 features
tiran commented:
"""
PR is blocked because custodia 0.3 is not yet in
https://copr.fedorainfracloud.org/coprs/g/freeipa/freeipa-master/packages/
Please add the package fro Koji builds
htt
URL: https://github.com/freeipa/freeipa/pull/613
Title: #613: Constrain wheel package versions
tiran commented:
"""
@MartinBasti please finish the review. The issue makes my daily work harder and
more complicated.
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/616
Author: tiran
Title: #616: Simplify KRA transport cert cache
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/616/head:pr616
git checkout pr616
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/616
Title: #616: Simplify KRA transport cert cache
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/619
Title: #619: pytest 3.x compatibility
tiran commented:
"""
@martbab @MartinBasti Do you agree with the workaround or do you want to
suggest a different approach?
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/626
Title: #626: Move helper code for integration plugin
tiran commented:
"""
@apophys Please create a ticket for the issue. This PR should not get merged
until the issue is properly documented in a ticket and commit messages hav
URL: https://github.com/freeipa/freeipa/pull/624
Title: #624: Use connection keep-alive
tiran commented:
"""
This behavior could be caused by
https://github.com/python/cpython/blob/master/Lib/socket.py#L688 . What's
```socket.getaddrinfo(host, 443, 0, socket.SOCK_STREAM)``
URL: https://github.com/freeipa/freeipa/pull/517
Author: tiran
Title: #517: [WIP] Use Custodia 0.3 features
Action: edited
Changed field: body
Original value:
"""
* Use sd-notify in ipa-custodia.service
* Introduce libexec/ipa/ipa-custodia script. It comes with correct
URL: https://github.com/freeipa/freeipa/pull/517
Author: tiran
Title: #517: [WIP] Use Custodia 0.3 features
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/517/head:pr517
git checkout pr517
From
URL: https://github.com/freeipa/freeipa/pull/616
Author: tiran
Title: #616: Simplify KRA transport cert cache
Action: edited
Changed field: body
Original value:
"""
In-memory cache causes problem in forking servers. A file based cache is
good enough. It's easier to unders
URL: https://github.com/freeipa/freeipa/pull/626
Author: tiran
Title: #626: Move helper code for integration plugin
Action: edited
Changed field: body
Original value:
"""
Helper code for ```ipatests.pytest_plugins.integration``` was in
```ipatests.test_integration```. This do
URL: https://github.com/freeipa/freeipa/pull/616
Title: #616: Simplify KRA transport cert cache
tiran commented:
"""
Size of a patch is a wrong metric. It's about code complexity. My patch reduces
code complexity and logic complexity. It also fixes at least two bugs:
multi-proc
URL: https://github.com/freeipa/freeipa/pull/623
Title: #623: client install: do not assume /etc/krb5.conf.d exists
tiran commented:
"""
I'd rather create ```/etc/krb5.conf.d``` than to make the line conditional.
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/624
Author: tiran
Title: #624: Use connection keep-alive
Action: opened
PR body:
"""
Do not forcefully close the connection after every request. This enables
HTTP connection keep-alive, also known as persistent TCP and TLS/SSL
c
URL: https://github.com/freeipa/freeipa/pull/619
Author: tiran
Title: #619: pytest 3.x compatibility
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/619/head:pr619
git checkout pr619
From
URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: [WIP] Tox testing support for client wheel packages
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout
URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: [WIP] Tox testing support for client wheel packages
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout
URL: https://github.com/freeipa/freeipa/pull/619
Author: tiran
Title: #619: pytest 3.x compatibility
Action: opened
PR body:
"""
pytest 3.x does no longer support plain pytest.skip() on module level.
Signed-off-by: Christian Heimes <chei...@redhat.com>
"""
URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: [WIP] Tox testing support for client wheel packages
Action: opened
PR body:
"""
Depends on PR #613
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freei
URL: https://github.com/freeipa/freeipa/pull/613
Author: tiran
Title: #613: Constrain wheel package versions
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/613/head:pr613
git checkout pr613
From
URL: https://github.com/freeipa/freeipa/pull/593
Title: #593: Add make patchcheck for developers
tiran commented:
"""
All dependencies have been merged. PR is ready for review.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/593#issuecom
URL: https://github.com/freeipa/freeipa/pull/593
Author: tiran
Title: #593: Add make patchcheck for developers
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/593/head:pr593
git checkout pr593
From
URL: https://github.com/freeipa/freeipa/pull/616
Author: tiran
Title: #616: Simplify KRA transport cert cache
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/616/head:pr616
git checkout pr616
From
URL: https://github.com/freeipa/freeipa/pull/616
Author: tiran
Title: #616: Simplify KRA transport cert cache
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/616/head:pr616
git checkout pr616
From
URL: https://github.com/freeipa/freeipa/pull/616
Title: #616: Simplify KRA transport cert cache
tiran commented:
"""
@HonzaCholasta I don't agree with you. Mutable mapping is too complex for a
simple cache. My approach is KISS.
"""
See the full comment at
http
URL: https://github.com/freeipa/freeipa/pull/517
Title: #517: [WIP] Use Custodia 0.3 features
tiran commented:
"""
I had some issues with build system yesterday. For some reason
```python2-python-etcd``` dependency was missing dependency on ```etcd```. I'm
glad time heals all
URL: https://github.com/freeipa/freeipa/pull/614
Author: tiran
Title: #614: [4.5] Constrain wheel package versions
Action: edited
Changed field: title
Original value:
"""
Constrain wheel package versions
"""
--
Manage your subscription for the Fre
URL: https://github.com/freeipa/freeipa/pull/616
Title: #616: Simplify KRA transport cert cache
tiran commented:
"""
Needs to be merged into ipa-4.5 branch, too.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/616#issuecomment-28731116
URL: https://github.com/freeipa/freeipa/pull/616
Author: tiran
Title: #616: Simplify KRA transport cert cache
Action: opened
PR body:
"""
In-memory cache causes problem in forking servers. A file based cache is
good enough. It's easier to understand and avoids perform
URL: https://github.com/freeipa/freeipa/pull/614
Author: tiran
Title: #614: Constrain wheel package versions
Action: opened
PR body:
"""
The presence of IPA packages on PyPI revealed an interesting issue with
make wheel_bundle. pip gives final releases a higher precedence than
URL: https://github.com/freeipa/freeipa/pull/613
Author: tiran
Title: #613: Constrain wheel package versions
Action: opened
PR body:
"""
The presence of IPA packages on PyPI revealed an interesting issue with
make wheel_bundle. pip gives final releases a higher precedence than
URL: https://github.com/freeipa/freeipa/pull/607
Title: #607: Backup ipa-specific httpd unit-file
tiran commented:
"""
The symlink is generated by a script when httpd is started.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/607#issuecom
URL: https://github.com/freeipa/freeipa/pull/607
Title: #607: Backup ipa-specific httpd unit-file
tiran commented:
"""
LGTM
Did you check if there are more files missing after backup, uninstall, restore?
You could use ```find /etc /usr /var >before_uninstall``` before un
URL: https://github.com/freeipa/freeipa/pull/379
Title: #379: Packaging: Add IPA commands package
Label: -postponed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/379
Author: tiran
Title: #379: Packaging: Add IPA commands package
Action: edited
Changed field: title
Original value:
"""
Packaging: Add placeholder and IPA commands packages
"""
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/379
Author: tiran
Title: #379: Packaging: Add placeholder and IPA commands packages
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/379/head:pr379
git checkout
URL: https://github.com/freeipa/freeipa/pull/517
Title: #517: [WIP] Use Custodia 0.3 features
tiran commented:
"""
This PR must be merged into 4.5 ASAP. Without the fix it is not possible to
define proper SELinux policies for ipa-custodia and stand-alone custodia.
"&quo
URL: https://github.com/freeipa/freeipa/pull/397
Author: tiran
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/397
URL: https://github.com/freeipa/freeipa/pull/593
Author: tiran
Title: #593: WIP: Add make patchcheck for developers
Action: edited
Changed field: title
Original value:
"""
WIP: Add make patchcheck for developers
"""
--
Manage your subscription for the Fre
URL: https://github.com/freeipa/freeipa/pull/593
Author: tiran
Title: #593: WIP: Add make patchcheck for developers
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/593/head:pr593
git checkout pr593
From
URL: https://github.com/freeipa/freeipa/pull/593
Author: tiran
Title: #593: WIP: Add make patchcheck for developers
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/593/head:pr593
git checkout pr593
From
URL: https://github.com/freeipa/freeipa/pull/599
Title: #599: CONFIGURE: Improve error messages for optional dependencies
tiran commented:
"""
NACK, you are changing the spirit of the accepted PR #502.
"""
See the full comment at
https://github.com/freeipa
URL: https://github.com/freeipa/freeipa/pull/594
Title: #594: Fix Python 3 pylint errors
tiran commented:
"""
@stlaz I fixed the problem with shadowed builtin type ```type```.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/594#issuecom
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
tiran commented:
"""
@pvoborni For the use case "easy for developers" the ```make lint``` target is
not sufficient. It tests only a small subset and doesn't check Python 3
URL: https://github.com/freeipa/freeipa/pull/594
Author: tiran
Title: #594: Fix Python 3 pylint errors
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/594/head:pr594
git checkout pr594
From
URL: https://github.com/freeipa/freeipa/pull/517
Author: tiran
Title: #517: [WIP] Use Custodia 0.3 features
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/517/head:pr517
git checkout pr517
From
URL: https://github.com/freeipa/freeipa/pull/593
Author: tiran
Title: #593: WIP: Add make patchcheck for developers
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/593/head:pr593
git checkout pr593
From
URL: https://github.com/freeipa/freeipa/pull/475
Author: tiran
Title: #475: Add options to run only ipaclient unittests
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/475/head:pr475
git checkout pr475
URL: https://github.com/freeipa/freeipa/pull/594
Author: tiran
Title: #594: Fix Python 3 pylint errors
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/594/head:pr594
git checkout pr594
From
URL: https://github.com/freeipa/freeipa/pull/594
Author: tiran
Title: #594: Fix Python 3 pylint errors
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/594/head:pr594
git checkout pr594
From
URL: https://github.com/freeipa/freeipa/pull/598
Author: tiran
Title: #598: Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb
Action: opened
PR body:
"""
Debian packages should be installed under dist-packages, not
site-packages. Debian has patched distutils and se
URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build
tiran commented:
"""
```ipa-getkeytab``` uses ```libini_config``` and ```libsasl2```.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/596#iss
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
tiran commented:
"""
PR #593 addresses @lslebodn concerns and provides a superior solution for local
pre-commit checking.
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/593
Title: #593: WIP: Add make patchcheck for developers
tiran commented:
"""
Depends on PRs #475, #587, #594
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/593#issuecomment-28666594
URL: https://github.com/freeipa/freeipa/pull/594
Author: tiran
Title: #594: Fix Python 3 pylint errors
Action: opened
PR body:
"""
```
* Module ipaserver.install.ipa_kra_install
ipaserver/install/ipa_kra_install.py:25: [W0402(deprecated-module), ] Uses of a
de
URL: https://github.com/freeipa/freeipa/pull/593
Author: tiran
Title: #593: WIP: Add make patchcheck for developers
Action: opened
PR body:
"""
Ticket 6604 makes pylint and jsl optional dependencies. The change
is controversal, because some developers prefer that pylint
URL: https://github.com/freeipa/freeipa/pull/591
Title: #591: spec file: add unconditional python-setuptools BuildRequires
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
I've moved the code to cert.py and raise SkipPluginModule from there.
"""
See the full comment at
https://g
URL: https://github.com/freeipa/freeipa/pull/397
Author: tiran
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/397
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
tiran commented:
"""
@martbab I've cleanup up some white space noise and squashed all commits.
"""
See the full comment at
https://github.com/freeipa
URL: https://github.com/freeipa/freeipa/pull/475
Author: tiran
Title: #475: Add options to run only ipaclient unittests
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/475/head:pr475
git checkout pr475
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
tiran commented:
"""
https://github.com/freeipa/freeipa/pull/502#issue-209980292
two thumbs up, one heart, no thumbs down
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/586
Author: tiran
Title: #586: Ignore ipapython/.DEFAULT_PLUGINS
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/586/head:pr586
git checkout pr586
From
URL: https://github.com/freeipa/freeipa/pull/587
Title: #587: Python 3: Fix session storage
tiran commented:
"""
@simo5 is UTF-8 correct or are keys and values ASCII only?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/587#issuecom
URL: https://github.com/freeipa/freeipa/pull/587
Author: tiran
Title: #587: Python 3: Fix session storage
Action: opened
PR body:
"""
ctypes can only handle bytes, not text. Encode and decode all incoming
and outgoing text from UTF-8 to bytes.
Signed-off-by: Christi
URL: https://github.com/freeipa/freeipa/pull/502
Author: tiran
Title: #502: Make pylint and jsl optional
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/502/head:pr502
git checkout pr502
From
URL: https://github.com/freeipa/freeipa/pull/433
Title: #433: csrgen: Allow some certificate fields to be specified by the user
tiran commented:
"""
@LiptonB please resolve conflicts
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/433#issuecom
URL: https://github.com/freeipa/freeipa/pull/586
Author: tiran
Title: #586: Ignore ipapython/.DEFAULT_PLUGINS
Action: opened
PR body:
"""
Signed-off-by: Christian Heimes <chei...@redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa ht
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
tiran commented:
"""
The PR got three +1 / heart and not -1. I propose to get it merged for 4.5
today.
"""
See the full comment at
https://github.com/freeipa/freeipa/p
URL: https://github.com/freeipa/freeipa/pull/502
Author: tiran
Title: #502: Make pylint and jsl optional
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/502/head:pr502
git checkout pr502
From
URL: https://github.com/freeipa/freeipa/pull/502
Author: tiran
Title: #502: Make pylint and jsl optional
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/502/head:pr502
git checkout pr502
From
URL: https://github.com/freeipa/freeipa/pull/538
Author: tiran
Title: #538: Run test_ipaclient test suite
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/538/head:pr538
git checkout pr538
From
URL: https://github.com/freeipa/freeipa/pull/542
Title: #542: Implementation independent interface for CSR generation
tiran commented:
"""
@LiptonB needs rebase
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/542#issuecomment-28645211
URL: https://github.com/freeipa/freeipa/pull/517
Title: #517: [WIP] Use Custodia 0.3 features
tiran commented:
"""
sigh, template markers aren't picked up automatically. I fixed
```init/systemd/Makefile.am```.
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/517
Author: tiran
Title: #517: [WIP] Use Custodia 0.3 features
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/517/head:pr517
git checkout pr517
From
101 - 200 of 773 matches
Mail list logo
