Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-05 Thread Simo Sorce
On Fri, 2011-11-04 at 16:55 -0400, Nalin Dahyabhai wrote: On Fri, Nov 04, 2011 at 04:45:02PM -0400, Simo Sorce wrote: After a quick review with nalin offline I decided for a different approach that properly covers the range of values we want and is more similar to the initial code. New

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Alexander Bokovoy
On Thu, 03 Nov 2011, Simo Sorce wrote: As stated in the bug in order to attain better interoperability with Windows clients we need to change the way we generate the random salt. ACK. -- / Alexander Bokovoy ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Martin Kosek
On Fri, 2011-11-04 at 10:04 +0200, Alexander Bokovoy wrote: On Thu, 03 Nov 2011, Simo Sorce wrote: As stated in the bug in order to attain better interoperability with Windows clients we need to change the way we generate the random salt. ACK. Pushed to master. Martin

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Simo Sorce
On Fri, 2011-11-04 at 11:14 +0100, Martin Kosek wrote: On Fri, 2011-11-04 at 10:04 +0200, Alexander Bokovoy wrote: On Thu, 03 Nov 2011, Simo Sorce wrote: As stated in the bug in order to attain better interoperability with Windows clients we need to change the way we generate the random

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Martin Kosek
On Fri, 2011-11-04 at 07:41 -0400, Simo Sorce wrote: On Fri, 2011-11-04 at 11:14 +0100, Martin Kosek wrote: On Fri, 2011-11-04 at 10:04 +0200, Alexander Bokovoy wrote: On Thu, 03 Nov 2011, Simo Sorce wrote: As stated in the bug in order to attain better interoperability with Windows

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Simo Sorce
On Fri, 2011-11-04 at 12:55 +0100, Martin Kosek wrote: On Fri, 2011-11-04 at 07:41 -0400, Simo Sorce wrote: On Fri, 2011-11-04 at 11:14 +0100, Martin Kosek wrote: On Fri, 2011-11-04 at 10:04 +0200, Alexander Bokovoy wrote: On Thu, 03 Nov 2011, Simo Sorce wrote: As stated in the bug

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Simo Sorce
On Fri, 2011-11-04 at 08:03 -0400, Simo Sorce wrote: On Fri, 2011-11-04 at 12:55 +0100, Martin Kosek wrote: On Fri, 2011-11-04 at 07:41 -0400, Simo Sorce wrote: On Fri, 2011-11-04 at 11:14 +0100, Martin Kosek wrote: On Fri, 2011-11-04 at 10:04 +0200, Alexander Bokovoy wrote: On Thu,

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Nalin Dahyabhai
On Thu, Nov 03, 2011 at 06:26:15PM -0400, Simo Sorce wrote: As stated in the bug in order to attain better interoperability with Windows clients we need to change the way we generate the random salt. Nack. The data in a krb5_data is of type 'char', and if it's signed, the math used here

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Simo Sorce
On Fri, 2011-11-04 at 15:15 -0400, Nalin Dahyabhai wrote: On Thu, Nov 03, 2011 at 06:26:15PM -0400, Simo Sorce wrote: As stated in the bug in order to attain better interoperability with Windows clients we need to change the way we generate the random salt. Nack. The data in a krb5_data

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Simo Sorce
On Fri, 2011-11-04 at 15:59 -0400, Simo Sorce wrote: On Fri, 2011-11-04 at 15:15 -0400, Nalin Dahyabhai wrote: On Thu, Nov 03, 2011 at 06:26:15PM -0400, Simo Sorce wrote: As stated in the bug in order to attain better interoperability with Windows clients we need to change the way we

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Simo Sorce
On Fri, 2011-11-04 at 16:14 -0400, Simo Sorce wrote: On Fri, 2011-11-04 at 15:59 -0400, Simo Sorce wrote: On Fri, 2011-11-04 at 15:15 -0400, Nalin Dahyabhai wrote: On Thu, Nov 03, 2011 at 06:26:15PM -0400, Simo Sorce wrote: As stated in the bug in order to attain better interoperability

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Nalin Dahyabhai
On Fri, Nov 04, 2011 at 04:45:02PM -0400, Simo Sorce wrote: After a quick review with nalin offline I decided for a different approach that properly covers the range of values we want and is more similar to the initial code. New patches attached. Looks good to me. Please bump up

[Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-03 Thread Simo Sorce
As stated in the bug in order to attain better interoperability with Windows clients we need to change the way we generate the random salt. Simo. -- Simo Sorce * Red Hat, Inc * New York From 350fdbfeab1cd04ba1ef576f7de075dbb91b6dfc Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com