John Dennis wrote:
On 07/20/2012 12:34 PM, Petr Viktorin wrote:
On 07/20/2012 05:59 PM, John Dennis wrote:
A fair amount of the code in the framework is doing this now, but the
install code was never cleaned up. That was left for another day, I
guess that day is here.
Updated. I also added
On 07/19/2012 08:01 PM, John Dennis wrote:
Overall I really like the approach, good work.
I have not applied and run the patch, so my comments are based only on
code reading.
I have just a small things which might need changing.
One of the ideas in the log manager is to easily support per
A fair amount of the code in the framework is doing this now, but the
install code was never cleaned up. That was left for another day, I
guess that day is here.
Updated. I also added the necessary lint exception.
I'm curious as to why it works that way, though. Normally, to put
methods in a
On 07/20/2012 05:59 PM, John Dennis wrote:
A fair amount of the code in the framework is doing this now, but the
install code was never cleaned up. That was left for another day, I
guess that day is here.
Updated. I also added the necessary lint exception.
I'm curious as to why it works that
On 07/20/2012 12:34 PM, Petr Viktorin wrote:
On 07/20/2012 05:59 PM, John Dennis wrote:
A fair amount of the code in the framework is doing this now, but the
install code was never cleaned up. That was left for another day, I
guess that day is here.
Updated. I also added the necessary lint
Overall I really like the approach, good work.
I have not applied and run the patch, so my comments are based only on
code reading.
I have just a small things which might need changing.
One of the ideas in the log manager is to easily support per class
logging (borrowed from Java). This
On 07/17/2012 10:41 PM, Rob Crittenden wrote:
Petr Viktorin wrote:
On 06/29/2012 11:28 PM, Rob Crittenden wrote:
Petr Viktorin wrote:
On 06/25/2012 03:00 PM, Petr Viktorin wrote:
On 06/20/2012 06:15 PM, Rob Crittenden wrote:
Petr Viktorin wrote:
On 06/04/2012 04:56 PM, Petr Viktorin wrote:
Petr Viktorin wrote:
On 06/29/2012 11:28 PM, Rob Crittenden wrote:
Petr Viktorin wrote:
On 06/25/2012 03:00 PM, Petr Viktorin wrote:
On 06/20/2012 06:15 PM, Rob Crittenden wrote:
Petr Viktorin wrote:
On 06/04/2012 04:56 PM, Petr Viktorin wrote:
Currently, FreeIPA's install/admin scripts
Petr Viktorin wrote:
On 06/25/2012 03:00 PM, Petr Viktorin wrote:
On 06/20/2012 06:15 PM, Rob Crittenden wrote:
Petr Viktorin wrote:
On 06/04/2012 04:56 PM, Petr Viktorin wrote:
Currently, FreeIPA's install/admin scripts are long pieces of code
that aren't very reusable, importable, or
On 06/20/2012 06:15 PM, Rob Crittenden wrote:
Petr Viktorin wrote:
On 06/04/2012 04:56 PM, Petr Viktorin wrote:
Currently, FreeIPA's install/admin scripts are long pieces of code
that aren't very reusable, importable, or testable.
They have been extended over time with features such as logging
On 06/25/2012 03:00 PM, Petr Viktorin wrote:
On 06/20/2012 06:15 PM, Rob Crittenden wrote:
Petr Viktorin wrote:
On 06/04/2012 04:56 PM, Petr Viktorin wrote:
Currently, FreeIPA's install/admin scripts are long pieces of code
that aren't very reusable, importable, or testable.
They have been
Petr Viktorin wrote:
On 06/04/2012 04:56 PM, Petr Viktorin wrote:
Currently, FreeIPA's install/admin scripts are long pieces of code
that aren't very reusable, importable, or testable.
They have been extended over time with features such as logging and
error handling, but since each tool was
On 06/04/2012 04:56 PM, Petr Viktorin wrote:
Currently, FreeIPA's install/admin scripts are long pieces of code
that aren't very reusable, importable, or testable.
They have been extended over time with features such as logging and
error handling, but since each tool was extended individually,
13 matches
Mail list logo
