Re: [Freeipa-devel] [PATCH] 271 Modified dialog to use sections.

2011-09-23 Thread Endi Sukma Dewata
On 9/23/2011 4:31 AM, Petr Vobornik wrote: On 09/22/2011 09:15 PM, Endi Sukma Dewata wrote: I've split the patch into two: 4a is the revised original patch, ACK 4b is the additional cleanup for the undo. you missed: dns.js:562 and host.js:406 . Beside this it's OK. Fixed. We actually

Re: [Freeipa-devel] [PATCH] 271 Modified dialog to use sections.

2011-09-22 Thread Petr Vobornik
On 09/21/2011 10:10 PM, Endi Sukma Dewata wrote: On 9/21/2011 6:50 AM, Petr Vobornik wrote: Fixed. The dialog fields don't need undo, so the text() needs to be overridden to disable undo. This can be improved again later. The override isn't necessary because it wasn't there before and all (at