Re: [Freeipa-devel] [PATCH] 938 consolidate external member code

2012-02-08 Thread Martin Kosek
On Tue, 2012-02-07 at 16:49 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2012-02-01 at 16:45 -0500, Rob Crittenden wrote: We had code all over the place to handle adding and removing external members from a variety of attributes. I consolidated these all into two functions in

Re: [Freeipa-devel] [PATCH] 938 consolidate external member code

2012-02-07 Thread Rob Crittenden
Martin Kosek wrote: On Wed, 2012-02-01 at 16:45 -0500, Rob Crittenden wrote: We had code all over the place to handle adding and removing external members from a variety of attributes. I consolidated these all into two functions in baseldap.py. This obsoletes my patch 920 but this patch

Re: [Freeipa-devel] [PATCH] 938 consolidate external member code

2012-02-06 Thread Martin Kosek
On Wed, 2012-02-01 at 16:45 -0500, Rob Crittenden wrote: We had code all over the place to handle adding and removing external members from a variety of attributes. I consolidated these all into two functions in baseldap.py. This obsoletes my patch 920 but this patch includes the improved

Re: [Freeipa-devel] [PATCH] 938 consolidate external member code

2012-02-06 Thread Rob Crittenden
Martin Kosek wrote: On Wed, 2012-02-01 at 16:45 -0500, Rob Crittenden wrote: We had code all over the place to handle adding and removing external members from a variety of attributes. I consolidated these all into two functions in baseldap.py. This obsoletes my patch 920 but this patch

Re: [Freeipa-devel] [PATCH] 938 consolidate external member code

2012-02-06 Thread Martin Kosek
On Mon, 2012-02-06 at 09:28 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2012-02-01 at 16:45 -0500, Rob Crittenden wrote: We had code all over the place to handle adding and removing external members from a variety of attributes. I consolidated these all into two functions in

[Freeipa-devel] [PATCH] 938 consolidate external member code

2012-02-01 Thread Rob Crittenden
We had code all over the place to handle adding and removing external members from a variety of attributes. I consolidated these all into two functions in baseldap.py. This obsoletes my patch 920 but this patch includes the improved error reporting that was present. rob From