Re: [Freeipa-devel] [PATCH] Unchecked return value in ipa-getkeytab

2011-01-12 Thread Rob Crittenden
Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/11/2011 10:57 AM, Martin Kosek wrote: On Tue, 2011-01-11 at 10:49 +0100, Martin Kosek wrote: krb5_init_context return value was not checked. This could lead to unhandled error issues. This patch moves the Kerberos

[Freeipa-devel] [PATCH] Unchecked return value in ipa-getkeytab

2011-01-11 Thread Martin Kosek
krb5_init_context return value was not checked. This could lead to unhandled error issues. This patch moves the Kerberos context initialization to the branch where it is needed and handles the error value in a way that allows program exit in a standard way deallocating all resources.

Re: [Freeipa-devel] [PATCH] Unchecked return value in ipa-getkeytab

2011-01-11 Thread Martin Kosek
On Tue, 2011-01-11 at 10:49 +0100, Martin Kosek wrote: krb5_init_context return value was not checked. This could lead to unhandled error issues. This patch moves the Kerberos context initialization to the branch where it is needed and handles the error value in a way that allows program

Re: [Freeipa-devel] [PATCH] Unchecked return value in ipa-getkeytab

2011-01-11 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/11/2011 10:57 AM, Martin Kosek wrote: On Tue, 2011-01-11 at 10:49 +0100, Martin Kosek wrote: krb5_init_context return value was not checked. This could lead to unhandled error issues. This patch moves the Kerberos context initialization to