Re: [Freeipa-devel] [PATCH 0048] Default the token owner to the person adding the token

2014-05-23 Thread Alexander Bokovoy
On Fri, 23 May 2014, Jan Cholasta wrote: On 22.5.2014 16:21, Nathaniel McCallum wrote: I still need a review on this. On Wed, 2014-05-07 at 10:06 -0400, Nathaniel McCallum wrote: On Wed, 2014-05-07 at 15:54 +0200, Petr Vobornik wrote: On 6.5.2014 17:07, Nathaniel McCallum wrote: On Tue, 2014

Re: [Freeipa-devel] [PATCH 0048] Default the token owner to the person adding the token

2014-05-22 Thread Jan Cholasta
On 22.5.2014 16:21, Nathaniel McCallum wrote: I still need a review on this. On Wed, 2014-05-07 at 10:06 -0400, Nathaniel McCallum wrote: On Wed, 2014-05-07 at 15:54 +0200, Petr Vobornik wrote: On 6.5.2014 17:07, Nathaniel McCallum wrote: On Tue, 2014-05-06 at 16:11 +0200, Jan Cholasta wrote:

Re: [Freeipa-devel] [PATCH 0048] Default the token owner to the person adding the token

2014-05-22 Thread Simo Sorce
On Thu, 2014-05-22 at 10:21 -0400, Nathaniel McCallum wrote: > I still need a review on this. LGTM. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-

Re: [Freeipa-devel] [PATCH 0048] Default the token owner to the person adding the token

2014-05-22 Thread Nathaniel McCallum
I still need a review on this. On Wed, 2014-05-07 at 10:06 -0400, Nathaniel McCallum wrote: > On Wed, 2014-05-07 at 15:54 +0200, Petr Vobornik wrote: > > On 6.5.2014 17:07, Nathaniel McCallum wrote: > > > On Tue, 2014-05-06 at 16:11 +0200, Jan Cholasta wrote: > > >> On 6.5.2014 15:16, Nathaniel Mc

Re: [Freeipa-devel] [PATCH 0048] Default the token owner to the person adding the token

2014-05-07 Thread Nathaniel McCallum
On Wed, 2014-05-07 at 15:54 +0200, Petr Vobornik wrote: > On 6.5.2014 17:07, Nathaniel McCallum wrote: > > On Tue, 2014-05-06 at 16:11 +0200, Jan Cholasta wrote: > >> On 6.5.2014 15:16, Nathaniel McCallum wrote: > >>> On Tue, 2014-05-06 at 13:46 +0200, Jan Cholasta wrote: > Hi, > > O

Re: [Freeipa-devel] [PATCH 0048] Default the token owner to the person adding the token

2014-05-07 Thread Petr Vobornik
On 6.5.2014 17:07, Nathaniel McCallum wrote: On Tue, 2014-05-06 at 16:11 +0200, Jan Cholasta wrote: On 6.5.2014 15:16, Nathaniel McCallum wrote: On Tue, 2014-05-06 at 13:46 +0200, Jan Cholasta wrote: Hi, On 5.5.2014 18:40, Nathaniel McCallum wrote: Creating tokens for yourself is the most co

Re: [Freeipa-devel] [PATCH 0048] Default the token owner to the person adding the token

2014-05-06 Thread Nathaniel McCallum
On Tue, 2014-05-06 at 16:11 +0200, Jan Cholasta wrote: > On 6.5.2014 15:16, Nathaniel McCallum wrote: > > On Tue, 2014-05-06 at 13:46 +0200, Jan Cholasta wrote: > >> Hi, > >> > >> On 5.5.2014 18:40, Nathaniel McCallum wrote: > >>> Creating tokens for yourself is the most common operation. Making th

Re: [Freeipa-devel] [PATCH 0048] Default the token owner to the person adding the token

2014-05-06 Thread Jan Cholasta
On 6.5.2014 15:16, Nathaniel McCallum wrote: On Tue, 2014-05-06 at 13:46 +0200, Jan Cholasta wrote: Hi, On 5.5.2014 18:40, Nathaniel McCallum wrote: Creating tokens for yourself is the most common operation. Making this the default optimizes for the common case. The user-find call should be

Re: [Freeipa-devel] [PATCH 0048] Default the token owner to the person adding the token

2014-05-06 Thread Nathaniel McCallum
On Tue, 2014-05-06 at 13:46 +0200, Jan Cholasta wrote: > Hi, > > On 5.5.2014 18:40, Nathaniel McCallum wrote: > > Creating tokens for yourself is the most common operation. Making this > > the default optimizes for the common case. > > The user-find call should be inside the if statement. This i

Re: [Freeipa-devel] [PATCH 0048] Default the token owner to the person adding the token

2014-05-06 Thread Jan Cholasta
Hi, On 5.5.2014 18:40, Nathaniel McCallum wrote: Creating tokens for yourself is the most common operation. Making this the default optimizes for the common case. The user-find call should be inside the if statement. Also please check if there actually is a result, if you run user-find --whoa

[Freeipa-devel] [PATCH 0048] Default the token owner to the person adding the token

2014-05-05 Thread Nathaniel McCallum
Creating tokens for yourself is the most common operation. Making this the default optimizes for the common case. >From a35485a2ffe4f47792203ebc5a6ef4b955bf Mon Sep 17 00:00:00 2001 From: Nathaniel McCallum Date: Mon, 5 May 2014 10:41:20 -0400 Subject: [PATCH] Default the token owner to the pe