Re: [Freeipa-devel] [PATCH 0097] Properly handle LDAP socket closures in ipa-otpd

2016-09-30 Thread Nathaniel McCallum
On Fri, 2016-09-30 at 15:10 +0200, Petr Vobornik wrote: > On 09/28/2016 04:58 PM, Nathaniel McCallum wrote: > > On Wed, 2016-09-28 at 08:03 +0300, Alexander Bokovoy wrote: > > > On ti, 27 syys 2016, Nathaniel McCallum wrote: > > > > In at least one case, when an LDAP socket closes, a read event >

Re: [Freeipa-devel] [PATCH 0097] Properly handle LDAP socket closures in ipa-otpd

2016-09-30 Thread Petr Vobornik
On 09/28/2016 04:58 PM, Nathaniel McCallum wrote: > On Wed, 2016-09-28 at 08:03 +0300, Alexander Bokovoy wrote: >> On ti, 27 syys 2016, Nathaniel McCallum wrote: >>> In at least one case, when an LDAP socket closes, a read event is >>> fired >>> rather than an error event. Without this patch,

Re: [Freeipa-devel] [PATCH 0097] Properly handle LDAP socket closures in ipa-otpd

2016-09-28 Thread Nathaniel McCallum
On Wed, 2016-09-28 at 08:03 +0300, Alexander Bokovoy wrote: > On ti, 27 syys 2016, Nathaniel McCallum wrote: > > In at least one case, when an LDAP socket closes, a read event is > > fired > > rather than an error event. Without this patch, ipa-otpd silently > > ignores this event and enters a

Re: [Freeipa-devel] [PATCH 0097] Properly handle LDAP socket closures in ipa-otpd

2016-09-27 Thread Alexander Bokovoy
On ti, 27 syys 2016, Nathaniel McCallum wrote: In at least one case, when an LDAP socket closes, a read event is fired rather than an error event. Without this patch, ipa-otpd silently ignores this event and enters a state where all bind auths fail. To remedy this problem, we pass error events

Re: [Freeipa-devel] [PATCH 0097] Properly handle LDAP socket closures in ipa-otpd

2016-09-27 Thread Simo Sorce
On Tue, 2016-09-27 at 14:54 -0400, Nathaniel McCallum wrote: > In at least one case, when an LDAP socket closes, a read event is > fired > rather than an error event. Without this patch, ipa-otpd silently > ignores this event and enters a state where all bind auths fail. > > To remedy this

[Freeipa-devel] [PATCH 0097] Properly handle LDAP socket closures in ipa-otpd

2016-09-27 Thread Nathaniel McCallum
In at least one case, when an LDAP socket closes, a read event is fired rather than an error event. Without this patch, ipa-otpd silently ignores this event and enters a state where all bind auths fail. To remedy this problem, we pass error events along the same path as read events. Should the