On 03/05/2015 02:45 PM, Petr Spacek wrote:
On 26.2.2015 17:01, Martin Basti wrote:
On 26/02/15 13:06, Petr Spacek wrote:
Hello Martin,
thank you for patch! This NACK is only aesthetic :-)
On 25.2.2015 14:21, Martin Basti wrote:
if (!check_return_value(rv, import_wrapped_key: key
On 26.2.2015 17:01, Martin Basti wrote:
On 26/02/15 13:06, Petr Spacek wrote:
Hello Martin,
thank you for patch! This NACK is only aesthetic :-)
On 25.2.2015 14:21, Martin Basti wrote:
if (!check_return_value(rv, import_wrapped_key: key unwrapping)) {
+error = 1;
+
On 26/02/15 13:06, Petr Spacek wrote:
Hello Martin,
thank you for patch! This NACK is only aesthetic :-)
On 25.2.2015 14:21, Martin Basti wrote:
if (!check_return_value(rv, import_wrapped_key: key unwrapping)) {
+error = 1;
+goto final;
+}
This exact sequence is
Hello Martin,
thank you for patch! This NACK is only aesthetic :-)
On 25.2.2015 14:21, Martin Basti wrote:
if (!check_return_value(rv, import_wrapped_key: key unwrapping)) {
+error = 1;
+goto final;
+}
This exact sequence is repeated many times in the code.
I
Ticket: https://fedorahosted.org/freeipa/ticket/4657
Patch attached.
--
Martin Basti
From 15509e09b658e9b2460ce42081baa1bb77a4d1e8 Mon Sep 17 00:00:00 2001
From: Martin Basti mba...@redhat.com
Date: Tue, 24 Feb 2015 19:25:31 +0100
Subject: [PATCH] Fix memory leaks in ipap11helper
Ticket:
On 25/02/15 14:21, Martin Basti wrote:
Ticket: https://fedorahosted.org/freeipa/ticket/4657
Patch attached.
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
I forgot to mention, requires
