Re: [Freeipa-devel] [PATCH 0441] Configure httpd service from installer

2016-04-22 Thread Martin Basti
On 22.04.2016 10:17, Stanislav Laznicka wrote: On 04/22/2016 10:08 AM, Martin Basti wrote: On 21.04.2016 22:55, Timo Aaltonen wrote: 21.04.2016, 20:50, Martin Basti kirjoitti: On 21.04.2016 19:28, Stanislav Laznicka wrote: On 04/21/2016 11:19 AM, Martin Basti wrote: On 20.04.2016 17:27

Re: [Freeipa-devel] [PATCH 0441] Configure httpd service from installer

2016-04-22 Thread Stanislav Laznicka
On 04/22/2016 10:08 AM, Martin Basti wrote: On 21.04.2016 22:55, Timo Aaltonen wrote: 21.04.2016, 20:50, Martin Basti kirjoitti: On 21.04.2016 19:28, Stanislav Laznicka wrote: On 04/21/2016 11:19 AM, Martin Basti wrote: On 20.04.2016 17:27, Martin Basti wrote: On 24.03.2016 14:27, Marti

Re: [Freeipa-devel] [PATCH 0441] Configure httpd service from installer

2016-04-22 Thread Martin Basti
On 21.04.2016 22:55, Timo Aaltonen wrote: 21.04.2016, 20:50, Martin Basti kirjoitti: On 21.04.2016 19:28, Stanislav Laznicka wrote: On 04/21/2016 11:19 AM, Martin Basti wrote: On 20.04.2016 17:27, Martin Basti wrote: On 24.03.2016 14:27, Martin Basti wrote: On 24.03.2016 13:55, Jan Cho

Re: [Freeipa-devel] [PATCH 0441] Configure httpd service from installer

2016-04-21 Thread Timo Aaltonen
21.04.2016, 20:50, Martin Basti kirjoitti: > > > On 21.04.2016 19:28, Stanislav Laznicka wrote: >> On 04/21/2016 11:19 AM, Martin Basti wrote: >>> >>> >>> On 20.04.2016 17:27, Martin Basti wrote: On 24.03.2016 14:27, Martin Basti wrote: > > > On 24.03.2016 13:55, Jan Ch

Re: [Freeipa-devel] [PATCH 0441] Configure httpd service from installer

2016-04-21 Thread Martin Basti
On 21.04.2016 19:28, Stanislav Laznicka wrote: On 04/21/2016 11:19 AM, Martin Basti wrote: On 20.04.2016 17:27, Martin Basti wrote: On 24.03.2016 14:27, Martin Basti wrote: On 24.03.2016 13:55, Jan Cholasta wrote: On 18.3.2016 23:27, Timo Aaltonen wrote: On 17.03.2016 18:36, Martin B

Re: [Freeipa-devel] [PATCH 0441] Configure httpd service from installer

2016-04-21 Thread Stanislav Laznicka
On 04/21/2016 11:19 AM, Martin Basti wrote: On 20.04.2016 17:27, Martin Basti wrote: On 24.03.2016 14:27, Martin Basti wrote: On 24.03.2016 13:55, Jan Cholasta wrote: On 18.3.2016 23:27, Timo Aaltonen wrote: On 17.03.2016 18:36, Martin Basti wrote: https://fedorahosted.org/freeipa/tick

Re: [Freeipa-devel] [PATCH 0441] Configure httpd service from installer

2016-04-21 Thread Martin Basti
On 20.04.2016 17:27, Martin Basti wrote: On 24.03.2016 14:27, Martin Basti wrote: On 24.03.2016 13:55, Jan Cholasta wrote: On 18.3.2016 23:27, Timo Aaltonen wrote: On 17.03.2016 18:36, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5681 would be nicer if ipa-httpd.conf wa

Re: [Freeipa-devel] [PATCH 0441] Configure httpd service from installer

2016-04-20 Thread Martin Basti
On 24.03.2016 14:27, Martin Basti wrote: On 24.03.2016 13:55, Jan Cholasta wrote: On 18.3.2016 23:27, Timo Aaltonen wrote: On 17.03.2016 18:36, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5681 would be nicer if ipa-httpd.conf was a template with the current hardcoded valu

Re: [Freeipa-devel] [PATCH 0441] Configure httpd service from installer

2016-03-24 Thread Rob Crittenden
Jan Cholasta wrote: On 18.3.2016 15:12, Martin Babinsky wrote: On 03/17/2016 05:36 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5681 Patch attached. Hi Martin, Nitpick attack: Please fix the commit message: "File httpd.service was created by RPM, what causes that httpd

Re: [Freeipa-devel] [PATCH 0441] Configure httpd service from installer

2016-03-24 Thread Martin Basti
On 24.03.2016 13:55, Jan Cholasta wrote: On 18.3.2016 23:27, Timo Aaltonen wrote: On 17.03.2016 18:36, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5681 would be nicer if ipa-httpd.conf was a template with the current hardcoded values replaced with platform paths.. +1, I wo

Re: [Freeipa-devel] [PATCH 0441] Configure httpd service from installer

2016-03-24 Thread Jan Cholasta
On 18.3.2016 15:12, Martin Babinsky wrote: On 03/17/2016 05:36 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5681 Patch attached. Hi Martin, Nitpick attack: Please fix the commit message: "File httpd.service was created by RPM, what causes that httpd service may", should

Re: [Freeipa-devel] [PATCH 0441] Configure httpd service from installer

2016-03-24 Thread Jan Cholasta
On 18.3.2016 23:27, Timo Aaltonen wrote: On 17.03.2016 18:36, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5681 would be nicer if ipa-httpd.conf was a template with the current hardcoded values replaced with platform paths.. +1, I would also prefer if the file was renamed to

Re: [Freeipa-devel] [PATCH 0441] Configure httpd service from installer

2016-03-19 Thread Martin Babinsky
On 03/17/2016 05:36 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5681 Patch attached. Hi Martin, Nitpick attack: Please fix the commit message: "File httpd.service was created by RPM, what causes that httpd service may", should be "..., which causes" Otherwise the code

[Freeipa-devel] [PATCH 0441] Configure httpd service from installer

2016-03-19 Thread Martin Basti
https://fedorahosted.org/freeipa/ticket/5681 Patch attached. From 9cce757cbdb19e71d314339cd2b822792dde3210 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Wed, 16 Mar 2016 09:04:42 +0100 Subject: [PATCH] Configure httpd service from installer instead of directly from RPM File httpd.service w

Re: [Freeipa-devel] [PATCH 0441] Configure httpd service from installer

2016-03-18 Thread Timo Aaltonen
On 17.03.2016 18:36, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5681 would be nicer if ipa-httpd.conf was a template with the current hardcoded values replaced with platform paths.. not relevant to this patch, but there are others candidates for templates like: daemons/d