Re: [Freeipa-devel] [PATCH 24/24] Add utility classes for handling DN's along with their, unittest.

2011-06-22 Thread Rob Crittenden
John Dennis wrote: Revised patch attached. Added copyright notice. Added support for concatenation and in-place addition for a few more types. Updated the unit test for the new functionality. Correct import statement in unit test. Ack, pushed to master and ipa-2-0 ___

Re: [Freeipa-devel] [PATCH 24/24] Add utility classes for handling DN's along with their, unittest.

2011-06-22 Thread Rob Crittenden
John Dennis wrote: Revised patch attached. Added copyright notice. Added support for concatenation and in-place addition for a few more types. Updated the unit test for the new functionality. Correct import statement in unit test. I can work with the updated patch you sent but it isn't in

Re: [Freeipa-devel] [PATCH 24/24] Add utility classes for handling DN's along with their, unittest.

2011-06-20 Thread John Dennis
On 06/20/2011 04:51 PM, John Dennis wrote: On 06/20/2011 04:06 PM, Rob Crittenden wrote: Take a look at ipalib/constants.py, it is full of containers like this. It is hard to review this patch without seeing how it will be used in the framework, are you planning on replacing all of these with DN

Re: [Freeipa-devel] [PATCH 24/24] Add utility classes for handling DN's along with their, unittest.

2011-06-20 Thread John Dennis
On 06/20/2011 04:06 PM, Rob Crittenden wrote: Take a look at ipalib/constants.py, it is full of containers like this. It is hard to review this patch without seeing how it will be used in the framework, are you planning on replacing all of these with DN constructors? Yup, I'm aware of these. Th

Re: [Freeipa-devel] [PATCH 24/24] Add utility classes for handling DN's along with their, unittest.

2011-06-20 Thread Rob Crittenden
John Dennis wrote: On 06/20/2011 10:01 AM, Rob Crittenden wrote: Am I misreading the documentation on how one can create a DN? >>> print container cn=users,cn=accounts >>> print basedn dc=example,dc=com >>> str(DN(container, basedn)) 'cn=users,cn=accounts=dc\\=example\\,dc\\=com' >>> uid='rcrit

Re: [Freeipa-devel] [PATCH 24/24] Add utility classes for handling DN's along with their, unittest.

2011-06-20 Thread John Dennis
On 06/20/2011 10:01 AM, Rob Crittenden wrote: Am I misreading the documentation on how one can create a DN? >>> print container cn=users,cn=accounts >>> print basedn dc=example,dc=com >>> str(DN(container, basedn)) 'cn=users,cn=accounts=dc\\=example\\,dc\\=com' >>> uid='rcrit' >>>

Re: [Freeipa-devel] [PATCH 24/24] Add utility classes for handling DN's along with their, unittest.

2011-06-20 Thread Rob Crittenden
John Dennis wrote: This adds a new module and set of classes to ipalib for handling DN's. Please see the module doc and class doc for full explanation. Included is a very complete unit test for the module. At close to 900 lines of code the unit test exercises just about every conceivable way the