Re: [Freeipa-devel] [PATCHES] 138-145 Action panel for user password reset

2012-06-04 Thread Petr Vobornik
On 06/01/2012 02:40 AM, Endi Sukma Dewata wrote: ACK. Looks good. Pushed to master. Some comments: 1. I suppose the select_action will always be the first action in any header_actions, and the action doesn't actually do anything. You might want to consider the '-- select action --' as part

Re: [Freeipa-devel] [PATCHES] 138-145 Action panel for user password reset

2012-05-31 Thread Endi Sukma Dewata
ACK. Looks good. Some comments: 1. I suppose the select_action will always be the first action in any header_actions, and the action doesn't actually do anything. You might want to consider the '-- select action --' as part of the IPA.action_list_widget and add it automatically in