URL: https://github.com/freeipa/freeipa/pull/115
Title: #115: Don't show traceback when ipa config file is not an absolute path
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/d7a2dfddbc2dc9ae4cea7d65e56d61a6a4d2b928
URL: https://github.com/freeipa/freeipa/pull/115
Title: #115: Don't show traceback when ipa config file is not an absolute path
mbasti-rh commented:
"""
nack, please see comments
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/115#issuecomment-250442693
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/115
Title: #115: Don't show traceback when ipa config file is not an absolute path
tomaskrizek commented:
"""
I found no reason why the path should be absolute, so I removed that constraint.
The parser check to verify if file exists should remain,
URL: https://github.com/freeipa/freeipa/pull/115
Title: #115: Don't show traceback when ipa config file is not an absolute path
pspacek commented:
"""
Why the file must be absolute? I would rather remove this requirement and be
done with it. `open()` the file and if it succeeds - use it. If it
URL: https://github.com/freeipa/freeipa/pull/115
Title: #115: Don't show traceback when ipa config file is not an absolute path
mbasti-rh commented:
"""
NACK, please see inline comments
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/115#issuecomment-249846654
--
Manage
URL: https://github.com/freeipa/freeipa/pull/115
Title: #115: Don't show traceback when ipa config file is not an absolute path
mbasti-rh commented:
"""
NACK, please see my inline comments
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/115#issuecomment-249783814
--
