URL: https://github.com/freeipa/freeipa/pull/160 Author: ofayans Title: #160: Reverted the essertion for replica uninstall returncode Action: synchronized
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/160/head:pr160 git checkout pr160
From b4259eae202d352ebe548c6c316c0ea534ab959e Mon Sep 17 00:00:00 2001 From: Oleg Fayans <ofay...@redhat.com> Date: Thu, 13 Oct 2016 08:46:35 +0200 Subject: [PATCH] Reverted the essertion for replica uninstall returncode As the issue with ipa installer always returning 0 returncode was addressed, the test needs to be made aware of this change. https://fedorahosted.org/freeipa/ticket/5725 --- ipatests/test_integration/test_replica_promotion.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/ipatests/test_integration/test_replica_promotion.py b/ipatests/test_integration/test_replica_promotion.py index 58f0fa5..0e93356 100644 --- a/ipatests/test_integration/test_replica_promotion.py +++ b/ipatests/test_integration/test_replica_promotion.py @@ -357,12 +357,8 @@ def test_replica_uninstallation_prohibited(self): result = self.replicas[0].run_command(['ipa-server-install', '--uninstall', '-U'], raiseonerr=False) - # Due to ticket 3230 server installation/uninstallation always returns - # 0 unless an uncaught exception occurs. Once this issue is properly - # addressed, please care to change expected return code in the - # following assert from 0 to something else. assert_error(result, "Removal of '%s' leads to disconnected" - " topology" % self.replicas[0].hostname, 0) + " topology" % self.replicas[0].hostname, 1) self.replicas[0].run_command(['ipa-server-install', '--uninstall', '-U', '--ignore-topology-disconnect'])
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
