URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
jcholast commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/1e6a204b4372bbbfb722a00370a5ce4e34406b9f
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
pvoborni commented:
"""
Lets push this code if it is correct but only misses usecases mentioned above".
Honza will implement the missing usecases in separate PR.
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
tiran commented:
"""
@pvoborni No, my answer is an disagreement. Honza does not want the approve the
PR as it stands now.
My proposal is
* Review this PR under the premise that it
URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
pvoborni commented:
"""
Christian, was your answer agreement to Honza's proposal? I.e. push this PR? To
rest later by Honza?
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
pvoborni commented:
"""
Christian, was your answer agreement to Honza's proposal? I.e. push this PR? To
rest later by Honza?
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
pvoborni commented:
"""
If I understand Christian right, it is not disagreement about something which
needs to be done. But rather a proposal to address rest of the scripts later in
URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
tiran commented:
"""
- [X]
```daemons/dnssec/ipa-dnskeysync-replica:124:ipalib.api.bootstrap(in_server=True,
log=None) # no logging to file```
- [X]
URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
tiran commented:
"""
All bootstrap() calls without an explicit confdir argument are fine. If you
think otherwise, please list all calls and give me a compelling reason to have
them
URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
jcholast commented:
"""
Please explain, all of the affected scripts are server-only and thus not
related to the integration effort and most probably won't work correctly with
URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
tiran commented:
"""
I fixed a few. Some scripts deliberately do not have the confdir flag in
bootstrap.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
jcholast commented:
"""
You missed a few:
```
daemons/dnssec/ipa-dnskeysync-replica:124:ipalib.api.bootstrap(in_server=True,
log=None) # no logging to file
URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
tiran commented:
"""
For #182
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/280#issuecomment-263301120
--
Manage your subscription for the Freeipa-devel
12 matches
Mail list logo
