[Freeipa-devel] [freeipa PR#348][comment] ca: fix ca-find with --pkey-only

2017-01-05 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/348 Title: #348: ca: fix ca-find with --pkey-only mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/ceb26f5ac428cdbed8ec1fa89e9ed6f1d903a5a0 """ See the full comment at

[Freeipa-devel] [freeipa PR#348][comment] ca: fix ca-find with --pkey-only

2017-01-05 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/348 Title: #348: ca: fix ca-find with --pkey-only frasertweedale commented: """ Thanks @mbasti-rh ! """ See the full comment at https://github.com/freeipa/freeipa/pull/348#issuecomment-270590370 -- Manage your subscription for the Freeipa-devel

[Freeipa-devel] [freeipa PR#348][comment] ca: fix ca-find with --pkey-only

2017-01-05 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/348 Title: #348: ca: fix ca-find with --pkey-only mbasti-rh commented: """ @frasertweedale your permissions have been upgraded :) """ See the full comment at https://github.com/freeipa/freeipa/pull/348#issuecomment-270589759 -- Manage your

[Freeipa-devel] [freeipa PR#348][comment] ca: fix ca-find with --pkey-only

2017-01-05 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/348 Title: #348: ca: fix ca-find with --pkey-only frasertweedale commented: """ It is an ACK. I don't have perms to add the label tho :) """ See the full comment at https://github.com/freeipa/freeipa/pull/348#issuecomment-270589226 -- Manage your

[Freeipa-devel] [freeipa PR#348][comment] ca: fix ca-find with --pkey-only

2017-01-05 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/348 Title: #348: ca: fix ca-find with --pkey-only HonzaCholasta commented: """ @frasertweedale, is that an ACK? :-) """ See the full comment at https://github.com/freeipa/freeipa/pull/348#issuecomment-270586148 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#348][comment] ca: fix ca-find with --pkey-only

2016-12-21 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/348 Title: #348: ca: fix ca-find with --pkey-only frasertweedale commented: """ LGTM """ See the full comment at https://github.com/freeipa/freeipa/pull/348#issuecomment-268509213 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#348][comment] ca: fix ca-find with --pkey-only

2016-12-19 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/348 Title: #348: ca: fix ca-find with --pkey-only frasertweedale commented: """ IMO the current change is fine, but I would also implement a defensive guard within `set_certificate_attrs` in case this somehow happens in some other command.