URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
MartinBasti commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/593ea7da9a732647052cb56c08ad367e40be3912
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
abbra commented:
"""
I've rebased against master and added responses to inline comments in the PR.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/410#issuecomment-279315609
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
abbra commented:
"""
Updated the spec file and the commit message.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/410#issuecomment-278108158
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
frozencemetery commented:
"""
@simo5 @abbra I'll move it over, but it won't break anything to pull in
krb5-devel *and* krb5-kdb-version as far as I can tell.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
frozencemetery commented:
"""
@simo5 @abbra I'll move it over, but it won't break anything to pull in
krb5-devel *and* krb5-kdb-version as far as I can tell.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
simo5 commented:
"""
@frozencemetery Should we provide krb5-kdb-version-devel from krb5-devel ?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/410#issuecomment-277949768
--
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
abbra commented:
"""
@simo5 @frozencemetery unfortunately, the provide of "krb5-kdb-version = 6.1"
is on krb5-libs, not on krb5-devel, so I cannot do a buildrequires dependency
this way.
"""
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
abbra commented:
"""
I split the tables into separate ones and also made independent #if/#endif
blocks for them. Finally, I added a spec file guard to force using 1.15-5 or
later version on
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
frozencemetery commented:
"""
There was talk of exporting a minor dal version but I think upstream explicitly
doesn't want it.
freeipa.spec.in should be modified if I understand correctly;
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
abbra commented:
"""
No, no minor DAL version. That's why I had to resort to structure member checks
in autoconf.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
simo5 commented:
"""
I checked and can't find it ... facepalm
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/410#issuecomment-274826331
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
simo5 commented:
"""
Doesn't kdb.h also export a MINOR version to test against ?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/410#issuecomment-274823821
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
abbra commented:
"""
@simo5 spec dependencies are separate from the code -- the spec will not help
on Debian, for example.
We need both the spec dependencies and the proper checks in the code.
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
simo5 commented:
"""
Also I know you can use ifdefs to avoid copy large parts of the
structure initialization but I would prefer 3 separate full inits based only on
ifdefs on the DAL version
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
simo5 commented:
"""
abbra, we should also change how spec deps work
I asked @rharwood to add a provides that is the dal version number
we should stop having a dep on the krb5 major version number
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
abbra commented:
"""
Thanks for the suggestions. I've updated the configure check to explicitly warn
when both .free_principal and .free_principal_e_data are missing. DAL version 5
had
URL: https://github.com/freeipa/freeipa/pull/410
Title: #410: ipa-kdb: support KDB DAL version 6.1
sumit-bose commented:
"""
Are there any plans how to handle 6.0? Should configure at least show a warning
if KRB5_KDB_DAL_MAJOR_VERSION == 6 but no free e_data callback was found?
Should the
17 matches
Mail list logo
