URL: https://github.com/freeipa/freeipa/pull/436
Title: #436: x509: allow leading text in PEM files
HonzaCholasta commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/89dfbab3ca076812590f371c21abcb51b350170b
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/436
Title: #436: x509: allow leading text in PEM files
tiran commented:
"""
Yes, please keep the test. It should pass with the current regular expression,
too.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/436
Title: #436: x509: allow leading text in PEM files
HonzaCholasta commented:
"""
Oops, didn't realize that `^` matches beginning of each line in multiline mode.
I think we can keep the test, though.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/436
Title: #436: x509: allow leading text in PEM files
tiran commented:
"""
NACK
The ^ is correct because the regular expression must search for a line that
starts with ```-BEGIN CERTIFICATE-```. I cannot reproduce the issue
locally. The
