URL: https://github.com/freeipa/freeipa/pull/459
Title: #459: [WIP] Faster JSON encoder/decoder
MartinBasti commented:
"""
LGTM
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/459#issuecomment-279688053
--
Manage your subscription for the Freeipa-devel mailing list:
URL: https://github.com/freeipa/freeipa/pull/459
Title: #459: [WIP] Faster JSON encoder/decoder
tiran commented:
"""
@pvoborni I have modified the PR and added a pretty_print option. JSON is now
pretty printed for verbose level 2 and higher.
The old implementation converted all list to
URL: https://github.com/freeipa/freeipa/pull/459
Title: #459: [WIP] Faster JSON encoder/decoder
pvoborni commented:
"""
As mention on meeting, if rpcserver prettyprints into output in debug mode then
it is fine.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/459
Title: #459: [WIP] Faster JSON encoder/decoder
tiran commented:
"""
```curl url | python -m json.tool```
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/459#issuecomment-279375693
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/459
Title: #459: [WIP] Faster JSON encoder/decoder
pvoborni commented:
"""
It's usually quicker to read raw response in browser than the folded "preview"
because everything is visible and no clicking is required. Same for curl
testing. But for curl
URL: https://github.com/freeipa/freeipa/pull/459
Title: #459: [WIP] Faster JSON encoder/decoder
abbra commented:
"""
Right, as long as ipa CLI is capable to print formatted debug output, that's
enough.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/459
Title: #459: [WIP] Faster JSON encoder/decoder
tiran commented:
"""
Why would you want to sort or indent the raw output? The extra verbose output
of ```ipa``` just loads and dumps the output a second time. It's less efficient
but who cares
URL: https://github.com/freeipa/freeipa/pull/459
Title: #459: [WIP] Faster JSON encoder/decoder
pvoborni commented:
"""
Is there a way(I did not read changes thoroughly) to enable sorting and
indentation, e.g. for testing purposes?
"""
See the full comment at
