[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

mbasti-rh commented on a pull request """ **Xfailed the tests due to a known bug with replica preparation** Fixed upstream master: https://fedorahosted.org/freeipa/changeset/1e484d010b653b8ac06425ca602ba5c9e950ed89 """ See the full comment at https://github.com/freeipa/freeipa/pull/52#issuecom

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

mbasti-rh commented on a pull request """ **Changed addressing to the client hosts to be replicas** Fixed upstream master: https://fedorahosted.org/freeipa/changeset/ac78d191ded6721cf1051413cdd6862c0362e66b ipa-4-4: https://fedorahosted.org/freeipa/changeset/de4a1fc0df5474f268c7ed08ffb802110631c1

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

mbasti-rh commented on a pull request """ **Several fixes in replica_promotion tests** Fixed upstream master: https://fedorahosted.org/freeipa/changeset/39c15ecdcdcbc2a0b651b0f89080789dd806e998 ipa-4-4: https://fedorahosted.org/freeipa/changeset/cd6adafbf699da48ab877e77ac9c1cc1dd26bf61 """ See

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

mbasti-rh commented on a pull request """ **Removed incorrect check for returncode** Fixed upstream master: https://fedorahosted.org/freeipa/changeset/22b0e8a9eb9eb3d47131c6784d70dd409d5b889b ipa-4-4: https://fedorahosted.org/freeipa/changeset/e265853d055caf7e3d17316eee6e25aa26bbf2a9 """ See th

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

ofayans commented on a pull request """ Done """ See the full comment at https://github.com/freeipa/freeipa/pull/52#issuecomment-244925053 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.free

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

mbasti-rh commented on a pull request """ Ad 2. yes """ See the full comment at https://github.com/freeipa/freeipa/pull/52#issuecomment-244914033 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://w

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

ofayans commented on a pull request """ @mbasti-rh, 1. Fixed 2. It's OK, but we won't have working tests in 4.3 branch. Should I create a ticket? 3. Gotya :) """ See the full comment at https://github.com/freeipa/freeipa/pull/52#issuecomment-244913086 -- Manage your subscription for the Freeip

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

mbasti-rh commented on a pull request """ I went through commit messages again and I changed my mind, NACK: 1) commit: Removed incorrect check for returncode This commit contains incorrect ticket, issue has not been fixed by this commit 2) commit: Several fixes in replica_promotion tests This

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

ofayans commented on a pull request """ The commit message was updated """ See the full comment at https://github.com/freeipa/freeipa/pull/52#issuecomment-244720426 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute t

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

mbasti-rh commented on a pull request """ ACK: Removed incorrect check for returncode NACK: Several fixes in replica_promotion tests -- missing explanation in commit messages why this change is needed, if changes are unrelated should be in multiple patches ACK: Changed addressing to the client