URL: https://github.com/freeipa/freeipa/pull/757
Title: #757: ca, kra install: validate DM password
stlaz commented:
"""
You forgot an import in ipa-ca-install:
```
* Module ipa-ca-install
install/tools/ipa-ca-install:37: [W0611(unused-import), ] Unused ScriptError
imported from
URL: https://github.com/freeipa/freeipa/pull/757
Title: #757: ca, kra install: validate DM password
MartinBasti commented:
"""
We have to use `sys.exit()` in this case, because I forgot that CA still uses
old style installer. Without `sys.exit()` ti will always suggest user to
uninstall
URL: https://github.com/freeipa/freeipa/pull/757
Title: #757: ca, kra install: validate DM password
tomaskrizek commented:
"""
Implementing the tests shouldn't block us from pushing this fix. I opened a
ticket for it: https://pagure.io/freeipa/issue/6941
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/757
Title: #757: ca, kra install: validate DM password
tomaskrizek commented:
"""
Thanks for the feedback, hopefully I addressed all the issues.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/757#issuecomment-299469642
--
URL: https://github.com/freeipa/freeipa/pull/757
Title: #757: ca, kra install: validate DM password
stlaz commented:
"""
There will be no more sys.exits. This patchset shall not be ACKed until all
have been removed.
"""
See the full comment at
