Re: [Freeipa-devel] [PATCH 0064] Check if IPA is configured before attempting a winsync migration

2015-11-23 Thread Martin Babinsky
On 11/20/2015 07:10 PM, Gabe Alford wrote: Thanks. Updated patch attached. Gabe On Fri, Nov 20, 2015 at 10:36 AM, Martin Babinsky > wrote: On 11/20/2015 04:02 PM, Gabe Alford wrote: Hello, Fix for

Re: [Freeipa-devel] [PATCH 0064] Check if IPA is configured before attempting a winsync migration

2015-11-23 Thread Tomas Babej
On 11/23/2015 12:11 PM, Martin Babinsky wrote: > On 11/20/2015 07:10 PM, Gabe Alford wrote: >> Thanks. Updated patch attached. >> >> >> Gabe >> >> On Fri, Nov 20, 2015 at 10:36 AM, Martin Babinsky > > wrote: >> >> On 11/20/2015 04:02 PM, Gabe

Re: [Freeipa-devel] [PATCH 0064] Check if IPA is configured before attempting a winsync migration

2015-11-20 Thread Gabe Alford
Thanks. Updated patch attached. Gabe On Fri, Nov 20, 2015 at 10:36 AM, Martin Babinsky wrote: > On 11/20/2015 04:02 PM, Gabe Alford wrote: > >> Hello, >> >> Fix for https://fedorahosted.org/freeipa/ticket/5470 >> >> Thanks, >> >> Gabe >> >> >> Hi Gabe, > > patch looks

Re: [Freeipa-devel] [PATCH 0064] Check if IPA is configured before attempting a winsync migration

2015-11-20 Thread Martin Babinsky
On 11/20/2015 04:02 PM, Gabe Alford wrote: Hello, Fix for https://fedorahosted.org/freeipa/ticket/5470 Thanks, Gabe Hi Gabe, patch looks good. IMHO it would be better if you moved the check before API initialization like so: """ @@ -340,6 +340,12 @@ class