Re: [Freeipa-devel] [Patch] 0001-2 User Life Cycle: create containers and scoping DS plugins

2014-09-01 Thread Martin Kosek
Thanks. ACK, pushed to master. Martin On 08/29/2014 04:36 PM, thierry bordaz wrote: Hello, Partially reverts commit of 04ea75a7a5109907ede2a0216bd39fac46a992c0 The fix 04ea75a7a5109907ede2a0216bd39fac46a992c0 restricted the DNA scope to 'cn=accounts,SUFFIX' . This was

Re: [Freeipa-devel] [Patch] 0001-2 User Life Cycle: create containers and scoping DS plugins

2014-08-29 Thread thierry bordaz
Hello, Partially reverts commit of 04ea75a7a5109907ede2a0216bd39fac46a992c0 The fix 04ea75a7a5109907ede2a0216bd39fac46a992c0 restricted the DNA scope to 'cn=accounts,SUFFIX' . This was invalid. If you run recent master instance (with that scoping) you may need to reinstall IPA or

Re: [Freeipa-devel] [Patch] 0001-2 User Life Cycle: create containers and scoping DS plugins

2014-08-28 Thread Sumit Bose
On Thu, Aug 14, 2014 at 07:18:40PM +0200, thierry bordaz wrote: Hello, Following Petr remarks from the previous review, I modified the original fix to move it only in '.update' files. Thanks thierry From d45e78dfeb7761348c464b3bb3956656bb115ce0 Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [Patch] 0001-2 User Life Cycle: create containers and scoping DS plugins

2014-08-28 Thread thierry bordaz
On 08/28/2014 06:51 PM, Sumit Bose wrote: On Thu, Aug 14, 2014 at 07:18:40PM +0200, thierry bordaz wrote: Hello, Following Petr remarks from the previous review, I modified the original fix to move it only in '.update' files. Thanks thierry From

Re: [Freeipa-devel] [Patch] 0001-2 User Life Cycle: create containers and scoping DS plugins

2014-08-28 Thread Sumit Bose
On Thu, Aug 28, 2014 at 07:26:51PM +0200, thierry bordaz wrote: On 08/28/2014 06:51 PM, Sumit Bose wrote: On Thu, Aug 14, 2014 at 07:18:40PM +0200, thierry bordaz wrote: Hello, Following Petr remarks from the previous review, I modified the original fix to move it only in '.update'

Re: [Freeipa-devel] [Patch] 0001-2 User Life Cycle: create containers and scoping DS plugins

2014-08-28 Thread thierry bordaz
On 08/28/2014 08:30 PM, Sumit Bose wrote: On Thu, Aug 28, 2014 at 07:26:51PM +0200, thierry bordaz wrote: On 08/28/2014 06:51 PM, Sumit Bose wrote: On Thu, Aug 14, 2014 at 07:18:40PM +0200, thierry bordaz wrote: Hello, Following Petr remarks from the previous review, I modified the

Re: [Freeipa-devel] [Patch] 0001-2 User Life Cycle: create containers and scoping DS plugins

2014-08-19 Thread Martin Kosek
On 08/18/2014 05:17 PM, thierry bordaz wrote: On 08/18/2014 05:10 PM, Petr Viktorin wrote: On 08/18/2014 05:03 PM, thierry bordaz wrote: ... Simply reply to this mail with the revised patch attached. As for attaching patches to the tickets, I've never done it and no one ever complained, so

Re: [Freeipa-devel] [Patch] 0001-2 User Life Cycle: create containers and scoping DS plugins

2014-08-19 Thread Petr Viktorin
On 08/18/2014 05:17 PM, thierry bordaz wrote: On 08/18/2014 05:10 PM, Petr Viktorin wrote: On 08/18/2014 05:03 PM, thierry bordaz wrote: On 08/18/2014 04:06 PM, Petr Viktorin wrote: On 08/14/2014 07:18 PM, thierry bordaz wrote: Hello, [...] Otherwise ACK. We want to push this together with

Re: [Freeipa-devel] [Patch] 0001-2 User Life Cycle: create containers and scoping DS plugins

2014-08-18 Thread Petr Viktorin
On 08/14/2014 07:18 PM, thierry bordaz wrote: Hello, Following Petr remarks from the previous review, I modified the original fix to move it only in '.update' files. Thanks thierry Looks better, thanks! I've tested install and upgrades, everything works as expected. Some

Re: [Freeipa-devel] [Patch] 0001-2 User Life Cycle: create containers and scoping DS plugins

2014-08-18 Thread thierry bordaz
On 08/18/2014 04:06 PM, Petr Viktorin wrote: On 08/14/2014 07:18 PM, thierry bordaz wrote: Hello, Following Petr remarks from the previous review, I modified the original fix to move it only in '.update' files. Thanks thierry Looks better, thanks! I've tested install and

Re: [Freeipa-devel] [Patch] 0001-2 User Life Cycle: create containers and scoping DS plugins

2014-08-18 Thread Petr Viktorin
On 08/18/2014 05:03 PM, thierry bordaz wrote: On 08/18/2014 04:06 PM, Petr Viktorin wrote: On 08/14/2014 07:18 PM, thierry bordaz wrote: Hello, Following Petr remarks from the previous review, I modified the original fix to move it only in '.update' files. Thanks thierry

Re: [Freeipa-devel] [Patch] 0001-2 User Life Cycle: create containers and scoping DS plugins

2014-08-18 Thread thierry bordaz
On 08/18/2014 05:10 PM, Petr Viktorin wrote: On 08/18/2014 05:03 PM, thierry bordaz wrote: On 08/18/2014 04:06 PM, Petr Viktorin wrote: On 08/14/2014 07:18 PM, thierry bordaz wrote: Hello, Following Petr remarks from the previous review, I modified the original fix to move it only in