Re: [Freeipa-devel] [PATCH] 026 HBAC plugin inconsistent output

2011-02-07 Thread Jan Zelený
Martin Kosek mko...@redhat.com wrote: This patch adds a proper summary text to HBAC command which is then printed out in CLI. Now, HBAC plugin output is consistent with other plugins. https://fedorahosted.org/freeipa/ticket/596 I believe API.txt should be updated (you change hbacrule_enable

Re: [Freeipa-devel] [PATCH] Fixed type of argument in class help

2011-02-07 Thread Jakub Hrozek
On Wed, Feb 02, 2011 at 08:54:47AM +0100, Jan Zelený wrote: At Rob's suggestion I changed the argument type in class help, this is only oneliner, I think it can be pushed directly. Jan -takes_args = (Bytes('command?'),) +takes_args = (Str('command?'),) Nack, you also need to

Re: [Freeipa-devel] [PATCH] Fix of a small typo

2011-02-07 Thread Jakub Hrozek
On Fri, Feb 04, 2011 at 06:41:41PM +0100, Jan Zeleny wrote: Trivial fix, can be pushed directly Jan Ack ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Fixed command delegation-show

2011-02-07 Thread Jakub Hrozek
On Fri, Feb 04, 2011 at 06:40:54PM +0100, Jan Zeleny wrote: Recent changes in permission prefixes influenced also delegations. The plugin has been updated accordingly, but this one line has been forgotten. Jan I think it is not needed, the only command preceding return from the function is

[Freeipa-devel] [PATCH] 72 Set minimum for Kerberos policy max life and max renew

2011-02-07 Thread Pavel Zuna
Fix #847 Pavel freeipa-pzuna-72-krbtpmin.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Fixed command delegation-show

2011-02-07 Thread Jan Zelený
Jakub Hrozek jhro...@redhat.com wrote: On Fri, Feb 04, 2011 at 06:40:54PM +0100, Jan Zeleny wrote: Recent changes in permission prefixes influenced also delegations. The plugin has been updated accordingly, but this one line has been forgotten. Jan I think it is not needed, the only

Re: [Freeipa-devel] [PATCH] 027 Support of user default email domain

2011-02-07 Thread Jakub Hrozek
On Fri, Feb 04, 2011 at 03:20:55PM +0100, Martin Kosek wrote: This patch fixes the default domain functionality for user email(s). This setting may be configured via: ipa config-mod --emaildomain=example.com Then, when user is added/modified and --mail option is passed, the default domain

[Freeipa-devel] [PATCH] 73 Update config doc to reflect that 0 is not allowed for search time limit.

2011-02-07 Thread Pavel Zuna
Fix #837 Pavel freeipa-pzuna-73-configdoc.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 72 Set minimum for Kerberos policy max life and max renew

2011-02-07 Thread Jakub Hrozek
On Mon, Feb 07, 2011 at 11:13:56AM +0100, Pavel Zuna wrote: Fix #847 Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Nack, please update API.txt

[Freeipa-devel] [PATCH] 76 Fallback to default locale (en_US) if env. setting is corrupt.

2011-02-07 Thread Pavel Zuna
This is a follow-up to my patches 69 and 71 (70 is garbage). It prevents a crash when user misconfigures his locale settings. Pavel freeipa-pzuna-76-deflocale.patch Description: application/mbox ___ Freeipa-devel mailing list

[Freeipa-devel] [PATCH] 77 Update krbtpolicy doc to inform that restarting krb5kdc might be needed.

2011-02-07 Thread Pavel Zuna
It seems that restarting krb5kdc is only needed when changes to the global policy are made. Per-user policies take effect immediately for newly requested tickets. Can someone please confirm? Fix #844 Pavel freeipa-pzuna-77-krbtpdoc.patch Description: application/mbox

Re: [Freeipa-devel] [PATCH] 77 Update krbtpolicy doc to inform that restarting krb5kdc might be needed.

2011-02-07 Thread Jenny Galipeau
Pavel Zuna wrote: It seems that restarting krb5kdc is only needed when changes to the global policy are made. Per-user policies take effect immediately for newly requested tickets. Can someone please confirm? Yes, in testing this is the behavior. If the help could specify that a ipactl

[Freeipa-devel] [PATCH] Removed unused code.

2011-02-07 Thread Endi Sukma Dewata
This depends on freeipa-edewata-0094-Restructuring-details-page.patch. -- Endi S. Dewata From 14fbaabf3c283f43113d4ee87b4db87a88102a95 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Fri, 4 Feb 2011 11:48:09 -0600 Subject: [PATCH] Removed unused code. ---

Re: [Freeipa-devel] [PATCH] Removed unused code.

2011-02-07 Thread Adam Young
On 02/07/2011 10:27 AM, Endi Sukma Dewata wrote: This depends on freeipa-edewata-0094-Restructuring-details-page.patch. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] Hide initial status.

2011-02-07 Thread Endi Sukma Dewata
Previously all certificate Kerberos key statuses (valid, missing and revoked) will appear briefly at the same time during page load. This has been fixed by setting the initial style to hidden. -- Endi S. Dewata From afaa735fe055190809de1fcae17ed2d7bc64f47c Mon Sep 17 00:00:00 2001 From: Endi S.

[Freeipa-devel] [PATCH] 701 fix uninstallation

2011-02-07 Thread Rob Crittenden
The state file is read early on in the uninstall and then each service manages its own uninstallation, resetting state as it goes along. Finally we remove the shared 389-ds user but the state is still the original state at the start of the uninstall so everything basically gets reset. Re-read

[Freeipa-devel] [PATCH] 702 add entitlement API

2011-02-07 Thread Rob Crittenden
The entitlement plugin was being skipped completely if the python-rhsm package wasn't installed. We want to let it limp through if the package isn't installed but we're doing API validation. ticket 919 rob freeipa-rcrit-702-entitle.patch Description: application/mbox

Re: [Freeipa-devel] [PATCH] Hide initial status.

2011-02-07 Thread Adam Young
On 02/07/2011 12:58 PM, Endi Sukma Dewata wrote: Previously all certificate Kerberos key statuses (valid, missing and revoked) will appear briefly at the same time during page load. This has been fixed by setting the initial style to hidden. -- Endi S. Dewata

Re: [Freeipa-devel] [PATCH] 701 fix uninstallation

2011-02-07 Thread Adam Young
On 02/07/2011 01:35 PM, Rob Crittenden wrote: The state file is read early on in the uninstall and then each service manages its own uninstallation, resetting state as it goes along. Finally we remove the shared 389-ds user but the state is still the original state at the start of the

Re: [Freeipa-devel] [PATCH] 026 HBAC plugin inconsistent output

2011-02-07 Thread Adam Young
On 02/07/2011 04:38 AM, Jan Zelený wrote: Martin Kosekmko...@redhat.com wrote: This patch adds a proper summary text to HBAC command which is then printed out in CLI. Now, HBAC plugin output is consistent with other plugins. https://fedorahosted.org/freeipa/ticket/596 I believe API.txt

[Freeipa-devel] [PATCH] Read-only text widget's save() should return null.

2011-02-07 Thread Endi Sukma Dewata
Pushed under one-liner rule. -- Endi S. Dewata From 2d84ab075cb418139afe0697de67eea82eecc15a Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Mon, 7 Feb 2011 13:12:30 -0600 Subject: [PATCH] Read-only text widget's save() should return null. --- install/ui/widget.js |3

Re: [Freeipa-devel] [PATCH] 73 Update config doc to reflect that 0 is not allowed for search time limit.

2011-02-07 Thread David O'Brien
Pavel Zuna wrote: Fix #837 Pavel /me hesitantly asks... Doesn't this mean that 1 is illegal? doc=_('Max. amount of time (sec.) for a search ( 1 or -1 for unlimited)'), Neither is there any mention of zero being illegal. It may be implicit or self-evident, but I don't rely on that in doc.

Re: [Freeipa-devel] [PATCH] 77 Update krbtpolicy doc to inform that restarting krb5kdc might be needed.

2011-02-07 Thread David O'Brien
Dmitri Pal wrote: On 02/07/2011 06:46 PM, David O'Brien wrote: Jenny Galipeau wrote: Pavel Zuna wrote: It seems that restarting krb5kdc is only needed when changes to the global policy are made. Per-user policies take effect immediately for newly requested tickets. Can someone please confirm?