Re: [Freeipa-devel] [PATCH] 34-35 ipasam fixes

2012-07-06 Thread Alexander Bokovoy
On Wed, 04 Jul 2012, Sumit Bose wrote: Hi, the following two patches contain fixes for ipa_sam.c. The first fixes several issues which were found by clang and the second removes some testing stuff I forgot to change. ACK. I'll commit them after SASL bind callback as they touch the same file.

[Freeipa-devel] [PATCH] use 'dedicated keytab file' parameter value instead of hard-coded string

2012-07-06 Thread Alexander Bokovoy
Hi, another small two-line cleanup. We already set 'dedicated keytab file' in smb.conf when installing trusts via ipa-adtrust-install. -- / Alexander Bokovoy From 48340d9c7dcdd10fa03ee8c4f4894a077babd42e Mon Sep 17 00:00:00 2001 From: Alexander Bokovoy aboko...@redhat.com Date: Fri, 6 Jul 2012

[Freeipa-devel] [PATCH] reduce redundant checks in ldapsam_search_users()

2012-07-06 Thread Alexander Bokovoy
Hi, Obvious clean up in ldapsam_search_users(): every branch is setting the same base dn and nothing else. -- / Alexander Bokovoy From 73250245710e26fecf8034667cb5c2358a592fad Mon Sep 17 00:00:00 2001 From: Alexander Bokovoy aboko...@redhat.com Date: Fri, 6 Jul 2012 12:48:27 +0300 Subject:

Re: [Freeipa-devel] [PATCH] reduce redundant checks in ldapsam_search_users()

2012-07-06 Thread Alexander Bokovoy
On Fri, 06 Jul 2012, Alexander Bokovoy wrote: Hi, Obvious clean up in ldapsam_search_users(): every branch is setting the same base dn and nothing else. Merged the line with talloc_strdup() call few lines after that. -- / Alexander Bokovoy From bf06e39a143967d3d99dcfe3fcd4d7f2a5f0142c Mon Sep

Re: [Freeipa-devel] [PATCH] use 'dedicated keytab file' parameter value instead of hard-coded string

2012-07-06 Thread Sumit Bose
On Fri, Jul 06, 2012 at 12:47:12PM +0300, Alexander Bokovoy wrote: Hi, another small two-line cleanup. We already set 'dedicated keytab file' in smb.conf when installing trusts via ipa-adtrust-install. ACK bye, Sumit -- / Alexander Bokovoy

Re: [Freeipa-devel] [PATCH] reduce redundant checks in ldapsam_search_users()

2012-07-06 Thread Sumit Bose
On Fri, Jul 06, 2012 at 01:18:28PM +0300, Alexander Bokovoy wrote: On Fri, 06 Jul 2012, Alexander Bokovoy wrote: Hi, Obvious clean up in ldapsam_search_users(): every branch is setting the same base dn and nothing else. Merged the line with talloc_strdup() call few lines after that. ACK

Re: [Freeipa-devel] [PATCH] use 'dedicated keytab file' parameter value instead of hard-coded string

2012-07-06 Thread Alexander Bokovoy
On Fri, 06 Jul 2012, Sumit Bose wrote: On Fri, Jul 06, 2012 at 12:47:12PM +0300, Alexander Bokovoy wrote: Hi, another small two-line cleanup. We already set 'dedicated keytab file' in smb.conf when installing trusts via ipa-adtrust-install. ACK Thanks. Pushed to master. -- / Alexander

Re: [Freeipa-devel] [PATCH] reduce redundant checks in ldapsam_search_users()

2012-07-06 Thread Alexander Bokovoy
On Fri, 06 Jul 2012, Sumit Bose wrote: On Fri, Jul 06, 2012 at 01:18:28PM +0300, Alexander Bokovoy wrote: On Fri, 06 Jul 2012, Alexander Bokovoy wrote: Hi, Obvious clean up in ldapsam_search_users(): every branch is setting the same base dn and nothing else. Merged the line with

Re: [Freeipa-devel] [PATCH] 33 Allow silent build if available

2012-07-06 Thread Alexander Bokovoy
On Thu, 05 Jul 2012, Simo Sorce wrote: On Wed, 2012-07-04 at 21:06 +0200, Sumit Bose wrote: Hi, this patch allows to use 'make V=0' to get a less verbose output during the compilation of the freeipa C-code. Since AM_SILENT_RULES is only available with automake 1.11 or later, I used m4_ifdef to

Re: [Freeipa-devel] [PATCH] 34-35 ipasam fixes

2012-07-06 Thread Alexander Bokovoy
On Fri, 06 Jul 2012, Alexander Bokovoy wrote: On Wed, 04 Jul 2012, Sumit Bose wrote: Hi, the following two patches contain fixes for ipa_sam.c. The first fixes several issues which were found by clang and the second removes some testing stuff I forgot to change. ACK. I'll commit them after

Re: [Freeipa-devel] [PATCH] ipasam SASL bind callback fixes

2012-07-06 Thread Alexander Bokovoy
On Thu, 05 Jul 2012, Alexander Bokovoy wrote: On Thu, 05 Jul 2012, Simo Sorce wrote: On Thu, 2012-07-05 at 16:27 +0300, Alexander Bokovoy wrote: See above, we have all the information we need via simple API calls to glibc or krb5 libs, we do not need to retrieve that information by other

Re: [Freeipa-devel] [PATCH] 166 Moved configuration to last position in navigation

2012-07-06 Thread Alexander Bokovoy
On Wed, 04 Jul 2012, Petr Vobornik wrote: Configuration was the last navigation item in IPA server tab. Trusts changed it. It was wrong because configuration is like 'other settings' and so it should be last. This patch moves configuration navigation item to the last position again.

Re: [Freeipa-devel] [PATCH] use 'dedicated keytab file' parameter value instead of hard-coded string

2012-07-06 Thread Simo Sorce
On Fri, 2012-07-06 at 12:47 +0300, Alexander Bokovoy wrote: Hi, another small two-line cleanup. We already set 'dedicated keytab file' in smb.conf when installing trusts via ipa-adtrust-install. ACK, Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [Freeipa-devel] [PATCH] 1028 service pac types

2012-07-06 Thread Rob Crittenden
Simo Sorce wrote: On Mon, 2012-06-25 at 17:38 -0400, Rob Crittenden wrote: Simo Sorce wrote: On Mon, 2012-06-25 at 16:23 -0400, Rob Crittenden wrote: Simo Sorce wrote: - Original Message - This patch is more a WIP than anything. I want to see if I'm on the right track. Hi Rob, I