Re: [Freeipa-devel] DN patch and documentation

2012-07-17 Thread Petr Viktorin
On 07/11/2012 05:24 PM, Alexander Bokovoy wrote: On Wed, 11 Jul 2012, Petr Viktorin wrote: On 07/07/2012 08:45 PM, John Dennis wrote: The DN work I was doing on master is ready for review and testing. It's been a long haul and I've been working relentlessly to get this work completed. I am on

Re: [Freeipa-devel] DN patch and documentation

2012-07-17 Thread Alexander Bokovoy
On Tue, 17 Jul 2012, Petr Viktorin wrote: On 07/11/2012 05:24 PM, Alexander Bokovoy wrote: On Wed, 11 Jul 2012, Petr Viktorin wrote: On 07/07/2012 08:45 PM, John Dennis wrote: The DN work I was doing on master is ready for review and testing. It's been a long haul and I've been working

Re: [Freeipa-devel] [PATCH] 170 Differentiation of widget type and text_widget input type

2012-07-17 Thread Petr Vobornik
On 07/17/2012 01:09 AM, Endi Sukma Dewata wrote: On 7/12/2012 8:10 AM, Petr Vobornik wrote: There was a clash of 'type' attribute in widget's spec. Usually 'type' is used for telling a builder which field and widget to build. Text widget used this attribute also for definion of html input type.

Re: [Freeipa-devel] [PATCH] 171 Fixed display of attributes_widget in IE9

2012-07-17 Thread Petr Vobornik
On 07/17/2012 01:10 AM, Endi Sukma Dewata wrote: On 7/16/2012 3:56 AM, Petr Vobornik wrote: Attributes widget is using overflow css rule in tbody element. IE9 doesn't handle it well. To fix the issue, attributes widget was slightly modified and conditional css stylesheet was added just for

Re: [Freeipa-devel] [PATCH] 172 Bigger textarea for permission type=subtree

2012-07-17 Thread Petr Vobornik
On 07/17/2012 01:10 AM, Endi Sukma Dewata wrote: On 7/16/2012 6:53 AM, Petr Vobornik wrote: Patch description: Adder dialog and details facet for permission type=subtree have small textarea for defining subtree filter. It was unconfortable to define the filter. This difference was removed.

Re: [Freeipa-devel] [PATCH] 172 Bigger textarea for permission type=subtree

2012-07-17 Thread Endi Sukma Dewata
On 7/17/2012 9:25 AM, Petr Vobornik wrote: Possible improvement, instead of using a fixed column size the text area also could be made to occupy 100% of available width. Ideally it should have the same width as the text field or drop down list in this dialog. Updated patch attached. I added

Re: [Freeipa-devel] [PATCH] 0061 ValidationError takes 'error' named argument, not 'reason'

2012-07-17 Thread Rob Crittenden
Alexander Bokovoy wrote: Hi, https://fedorahosted.org/freeipa/ticket/2865 ACK ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0062 support various forms of user account when establishing trusts

2012-07-17 Thread Rob Crittenden
Alexander Bokovoy wrote: Hi, Realm administrator account may be specified using different form: Administrator, DOM\Administrator, Administrator@DOMAIN This patch introduces handling of the second two forms: - In DOM\Administrator only user name is used, short domain name is then taken from a

Re: [Freeipa-devel] [PATCH] 0060 Ensure ipa-adtrust-install is run as admin user

2012-07-17 Thread Rob Crittenden
Alexander Bokovoy wrote: On Fri, 13 Jul 2012, Alexander Bokovoy wrote: Hi, when adding AD trusts support, we need to ensure we have valid kerberos ticket of the user from 'admins' group or otherwise appropriate ACIs will not be granted. This patch introduces a check for that. We already check

[Freeipa-devel] [PATCH] 1035 case sensitivity when calculating indirect members

2012-07-17 Thread Rob Crittenden
When determining whether a member is direct or indirect we were not doing a case-insensitive comparison which led to marking a member as both direct and indirect (in a test case no less). This patch fixes the comparison and the test. rob From c03329d6ea7b5ddda917bca64a6f085efe9e6a95 Mon Sep

Re: [Freeipa-devel] [PATCH] 0056 Framework for admin/install tools, with ipa-ldap-updater

2012-07-17 Thread Rob Crittenden
Petr Viktorin wrote: On 06/29/2012 11:28 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 06/25/2012 03:00 PM, Petr Viktorin wrote: On 06/20/2012 06:15 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 06/04/2012 04:56 PM, Petr Viktorin wrote: Currently, FreeIPA's install/admin scripts

Re: [Freeipa-devel] DN patch and documentation

2012-07-17 Thread John Dennis
On 07/10/2012 04:23 AM, Petr Viktorin wrote: I've read your summary (which you should summarize into a commit message before this is pushed), and gone through the patch. Here is what I found doing that; I didn't get to actual testing yet. I also didn't do a detailed review of ldap2.py changes