[Freeipa-devel] [PATCH] 584 migration: fix import of wsgiref.util

2014-04-01 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/4293 -- Petr Vobornik From dc4eaf9d622b4eac9fb3d942b23083bfb903be9a Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Tue, 1 Apr 2014 08:45:08 +0200 Subject: [PATCH] migration: fix import of wsgiref.util

Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-01 Thread Jan Pazdziora
On Thu, Mar 27, 2014 at 01:14:52PM +0100, Tomas Babej wrote: Hi, When cleaning the range_info struct, simple free of the struct is not enough, we have to free contents of char pointers in the struct as well. https://fedorahosted.org/freeipa/ticket/4276 [...] 1 file changed, 13

Re: [Freeipa-devel] FreeIPA repository and it's committers

2014-04-01 Thread Jan Pazdziora
On Fri, Mar 28, 2014 at 01:14:31PM +0100, Martin Kosek wrote: This week there was a request to be added to the list of FreeIPA committers, which I denied as the person was not a member of the short list of selected trusted active core upstream developers doing the pushes. While that makes

Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-01 Thread Alexander Bokovoy
On Tue, 01 Apr 2014, Jan Pazdziora wrote: On Thu, Mar 27, 2014 at 01:14:52PM +0100, Tomas Babej wrote: Hi, When cleaning the range_info struct, simple free of the struct is not enough, we have to free contents of char pointers in the struct as well.

Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-01 Thread Tomas Babej
On 04/01/2014 09:11 AM, Alexander Bokovoy wrote: On Tue, 01 Apr 2014, Jan Pazdziora wrote: On Thu, Mar 27, 2014 at 01:14:52PM +0100, Tomas Babej wrote: Hi, When cleaning the range_info struct, simple free of the struct is not enough, we have to free contents of char pointers in the struct

Re: [Freeipa-devel] [PATCH] 584 migration: fix import of wsgiref.util

2014-04-01 Thread Jan Pazdziora
On Tue, Apr 01, 2014 at 08:47:25AM +0200, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/4293 -- Petr Vobornik From dc4eaf9d622b4eac9fb3d942b23083bfb903be9a Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Tue, 1 Apr 2014 08:45:08 +0200 Subject: [PATCH]

Re: [Freeipa-devel] FreeIPA repository and it's committers

2014-04-01 Thread Martin Kosek
On 04/01/2014 09:05 AM, Jan Pazdziora wrote: On Fri, Mar 28, 2014 at 01:14:31PM +0100, Martin Kosek wrote: This week there was a request to be added to the list of FreeIPA committers, which I denied as the person was not a member of the short list of selected trusted active core upstream

Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-01 Thread Tomas Babej
On 04/01/2014 09:17 AM, Tomas Babej wrote: On 04/01/2014 09:11 AM, Alexander Bokovoy wrote: On Tue, 01 Apr 2014, Jan Pazdziora wrote: On Thu, Mar 27, 2014 at 01:14:52PM +0100, Tomas Babej wrote: Hi, When cleaning the range_info struct, simple free of the struct is not enough, we have to

Re: [Freeipa-devel] [PATCH 0158] Extend ipa-range-check DS plugin to handle range types

2014-04-01 Thread Tomas Babej
A slightly new version, properly adds new attributes of the range_info struct to the free_range_info method. Should be applied on top of my 161 patch. On 03/27/2014 01:11 PM, Tomas Babej wrote: The updated version handles the ret variable properly. It also makes sure the memory is properly

Re: [Freeipa-devel] [PATCH 0158] Extend ipa-range-check DS plugin to handle range types

2014-04-01 Thread Alexander Bokovoy
On Tue, 01 Apr 2014, Tomas Babej wrote: From 736b3f747188696fd4a46ca63d91a6cca942fd56 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Wed, 5 Mar 2014 12:28:18 +0100 Subject: [PATCH] Extend ipa-range-check DS plugin to handle range types The ipa-range-check plugin used to

Re: [Freeipa-devel] [PATCH 0158] Extend ipa-range-check DS plugin to handle range types

2014-04-01 Thread Tomas Babej
On 04/01/2014 10:40 AM, Alexander Bokovoy wrote: On Tue, 01 Apr 2014, Tomas Babej wrote: From 736b3f747188696fd4a46ca63d91a6cca942fd56 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Wed, 5 Mar 2014 12:28:18 +0100 Subject: [PATCH] Extend ipa-range-check DS plugin to handle

Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-01 Thread Jan Pazdziora
On Tue, Apr 01, 2014 at 10:05:39AM +0200, Tomas Babej wrote: Yes, that was the intention. Mistake on my part, I'll send updated patches. Updated patch attached. Ack based on reading the code and documentation for slapi_ch_free_string. -- Jan Pazdziora Principal Software Engineer,

[Freeipa-devel] [PATCH 0162] ipa-pwd-extop: Fix memory leak in ipapwd_pre_bind

2014-04-01 Thread Tomas Babej
Hi, We need to free the entry before returning from the function. https://fedorahosted.org/freeipa/ticket/4295 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org From 5149ce52f583ef234bde5e8b386567c377369e41 Mon Sep 17

Re: [Freeipa-devel] Read access to container entries

2014-04-01 Thread Martin Kosek
On 03/31/2014 06:01 PM, Simo Sorce wrote: On Mon, 2014-03-31 at 15:39 +0200, Martin Kosek wrote: On 03/31/2014 02:53 PM, Simo Sorce wrote: On Mon, 2014-03-31 at 10:41 +0200, Ludwig Krispenz wrote: ... 3) Add a special attribute to mark public containers, and add an ACI with a filter on

Re: [Freeipa-devel] [PATCH 0162] ipa-pwd-extop: Fix memory leak in ipapwd_pre_bind

2014-04-01 Thread Alexander Bokovoy
On Tue, 01 Apr 2014, Tomas Babej wrote: Hi, We need to free the entry before returning from the function. https://fedorahosted.org/freeipa/ticket/4295 ACK. -- / Alexander Bokovoy ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] Read access to container entries

2014-04-01 Thread Simo Sorce
On Tue, 2014-04-01 at 13:32 +0200, Martin Kosek wrote: On 03/31/2014 06:01 PM, Simo Sorce wrote: On Mon, 2014-03-31 at 15:39 +0200, Martin Kosek wrote: On 03/31/2014 02:53 PM, Simo Sorce wrote: On Mon, 2014-03-31 at 10:41 +0200, Ludwig Krispenz wrote: ... 3) Add a special attribute to

[Freeipa-devel] [PATCH] 468 Make ipa-client-automount backwards compatible

2014-04-01 Thread Martin Kosek
ipa-client-automount calls automountlocation-show command during the process. Unfortunately, FreeIPA commands are forward compatible only and thus fail the installer. Similarly to ipa-client-install, call XML-RPC interface directly with version fixed to 2.0 (command was already available at that

Re: [Freeipa-devel] OTP work, what's left?

2014-04-01 Thread Martin Kosek
On 03/28/2014 10:17 AM, Martin Kosek wrote: On 03/23/2014 10:26 PM, Alexander Bokovoy wrote: Hi! I've updated my COPR repo with current git master versions of FreeIPA and SSSD with few added patches on top that close OTP gaps (Nathaniel's patch 0038 and Jakub Hrozek's patch for password

Re: [Freeipa-devel] [PATCH] 468 Make ipa-client-automount backwards compatible

2014-04-01 Thread Rob Crittenden
Martin Kosek wrote: ipa-client-automount calls automountlocation-show command during the process. Unfortunately, FreeIPA commands are forward compatible only and thus fail the installer. Similarly to ipa-client-install, call XML-RPC interface directly with version fixed to 2.0 (command was

[Freeipa-devel] [PATCH 0231] Fix record parsing to prevent child zone corruption

2014-04-01 Thread Petr Spacek
Hello, Fix record parsing to prevent child zone corruption. Child zone hosted on the same server as parent zone was corrupted by bug in update_record(). Child zone's apex was modified by update_records() instead of delegation records in the parent zone.