Re: [Freeipa-devel] [PATCH] ipa trust-add command should be interactive

2014-07-21 Thread Jan Cholasta
Hi, On 16.7.2014 05:48, Gabe Alford wrote: Hello, Adds AD admin and password to interactive commands. https://fedorahosted.org/freeipa/ticket/3034 Thanks, Gabe I think that instead of making the parameters mandatory, you should instead set alwaysask=True on them. Honza -- Jan Cholasta

Re: [Freeipa-devel] [PATCH 0243] ipalib: idrange: Make non-implemented range types fail the

2014-07-21 Thread Jan Cholasta
Hi, On 16.7.2014 14:05, Tomas Babej wrote: Hi, The ipa-ipa-trust and ipa-ad-winsync ID Range types were allowed to pass the validation tests, however, they are not implemented nor checked by the 389 server plugin. https://fedorahosted.org/freeipa/ticket/4323 ACK. -- Jan Cholasta

Re: [Freeipa-devel] [PATCH] ipa trust-add command should be interactive

2014-07-21 Thread Martin Kosek
On 07/21/2014 09:56 AM, Jan Cholasta wrote: Hi, On 16.7.2014 05:48, Gabe Alford wrote: Hello, Adds AD admin and password to interactive commands. https://fedorahosted.org/freeipa/ticket/3034 Thanks, Gabe I think that instead of making the parameters mandatory, you should instead

Re: [Freeipa-devel] [PATCH] ipa trust-add command should be interactive

2014-07-21 Thread Jan Cholasta
On 21.7.2014 10:28, Martin Kosek wrote: On 07/21/2014 09:56 AM, Jan Cholasta wrote: Hi, On 16.7.2014 05:48, Gabe Alford wrote: Hello, Adds AD admin and password to interactive commands. https://fedorahosted.org/freeipa/ticket/3034 Thanks, Gabe I think that instead of making the

Re: [Freeipa-devel] [PATCH] 697-702 webui: usability improvements in attribute widget

2014-07-21 Thread Petr Vobornik
On 18.7.2014 00:06, Endi Sukma Dewata wrote: On 7/10/2014 8:02 AM, Petr Vobornik wrote: ACK. Comments below: == [PATCH] 699 webui: optimize (re)creation of option widget == There is a case where attributes widget can contain 1000 items. It's about 3000 nodes. It's slow in jQuery. Simple

Re: [Freeipa-devel] [PATCH] 703-707 webui: improvements in permission details page

2014-07-21 Thread Petr Vobornik
On 18.7.2014 00:08, Endi Sukma Dewata wrote: ACK. See comment below: pushed to: master: * 1a904708cc68f742a19036224b267d92644968fc webui: reflect readonly state * e60cfa28626d7e224e2b4aebbe8af8e3fdf1d1c0 webui: fix add of input group class * 75a96fb4c2f58d9ad54a374136afa656ac9a737e webui:

Re: [Freeipa-devel] [PATCH] 708 webui: fix disabled state of service's PAC type

2014-07-21 Thread Petr Vobornik
On 18.7.2014 00:09, Endi Sukma Dewata wrote: On 7/10/2014 7:38 AM, Petr Vobornik wrote: Nested options (MS-PAC and PAD) of service's PAC type should be disabled if no value is supplied (default value is Inherited from server configuration). That was not the case - regression. This patch fixes

Re: [Freeipa-devel] [PATCH] webui: 696 support wildcard attribute level rights

2014-07-21 Thread Petr Vobornik
On 18.7.2014 00:03, Endi Sukma Dewata wrote: On 7/10/2014 7:23 AM, Petr Vobornik wrote: Reproduction: * add 'extensibleObject' object class to target object https://fedorahosted.org/freeipa/ticket/4380 This is the original if-condition: (!rights !(that.flags.indexOf('w_if_no_aci')

[Freeipa-devel] [PATCH] 709 webui: fix nested items creation in dropdown list

2014-07-21 Thread Petr Vobornik
Items nested in other items were created in root list instead of nested list. Note: this feature is not used in current UI but it's likely to be used by a plugin -- Petr Vobornik From 0f83a4bfb5d164f0fbd6d6520091fbea21887673 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com

Re: [Freeipa-devel] [PATCH] 0002 Improve password validity check

2014-07-21 Thread David Kupka
On 07/18/2014 12:52 PM, Martin Kosek wrote: On 07/18/2014 12:33 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/2796 1) Would it be easier/more convenient to just implement following simple check instead of bad_prefix/bad_suffix? if password.strip() != password: raise

[Freeipa-devel] [PATCH] Always record that pkicreate has been executed

2014-07-21 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/2796 -- David Kupka From 5d1e323d87aa4bf2b21ed11b062e68e56fe9d887 Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Mon, 21 Jul 2014 15:57:18 +0200 Subject: [PATCH] Always record that pkicreate has been executed. Record that

Re: [Freeipa-devel] [PATCH 0058] Fix login password expiration detection with OTP

2014-07-21 Thread Petr Vobornik
On 14.7.2014 21:01, Nathaniel McCallum wrote: The preexisting code would execute two steps. First, it would perform a kinit. If the kinit failed, it would attempt to bind using the same credentials to determine if the password were expired. While this method is fairly ugly, it mostly worked in

Re: [Freeipa-devel] [PATCH 0058] Fix login password expiration detection with OTP

2014-07-21 Thread Nathaniel McCallum
On Mon, 2014-07-21 at 16:39 +0200, Petr Vobornik wrote: On 14.7.2014 21:01, Nathaniel McCallum wrote: The preexisting code would execute two steps. First, it would perform a kinit. If the kinit failed, it would attempt to bind using the same credentials to determine if the password were

[Freeipa-devel] [PATCH 0059] Update freeipa-server krb5-server dependency to 1.11.5-5

2014-07-21 Thread Nathaniel McCallum
Previous versions of libkrb5 can't handle expired passwords inside the FAST tunnel. This breaks the password change UI in FreeIPA. From 2541ccf8614e86b9093a8cea9adb4ae117886c16 Mon Sep 17 00:00:00 2001 From: Nathaniel McCallum npmccal...@redhat.com Date: Mon, 21 Jul 2014 12:32:03 -0400 Subject: