Re: [Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

2015-01-14 Thread Martin Kosek
Adding freeipa-devel back. On 01/14/2015 05:58 PM, Simo Sorce wrote: On Wed, 14 Jan 2015 17:47:51 +0100 Martin Kosek mko...@redhat.com wrote: -add:aci:'(targetfilter=(objectclass=nsContainer))(version 3.0; acl Deny read access to replica configuration; deny(read, search, compare) userdn =

Re: [Freeipa-devel] [PATCH 0002] Changing the token owner also changes its manager

2015-01-14 Thread Nathaniel McCallum
On Wed, 2015-01-14 at 17:49 +0100, Martin Babinsky wrote: On 01/14/2015 05:23 PM, Nathaniel McCallum wrote: On Wed, 2015-01-14 at 16:49 +0100, Martin Babinsky wrote: Changing the owner of a token also implicitly sets the new owner as its manager if following conditions are met: 1.) The

Re: [Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

2015-01-14 Thread Simo Sorce
On Wed, 14 Jan 2015 13:41:54 +0100 thierry bordaz tbor...@redhat.com wrote: On 01/14/2015 12:03 PM, Martin Kosek wrote: On 01/14/2015 10:58 AM, thierry bordaz wrote: On 01/14/2015 10:15 AM, Petr Viktorin wrote: On 01/13/2015 10:52 PM, Martin Kosek wrote: On 01/13/2015 09:55 PM, Simo

Re: [Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

2015-01-14 Thread Martin Kosek
On 01/14/2015 03:34 PM, Simo Sorce wrote: On Wed, 14 Jan 2015 13:41:54 +0100 thierry bordaz tbor...@redhat.com wrote: On 01/14/2015 12:03 PM, Martin Kosek wrote: On 01/14/2015 10:58 AM, thierry bordaz wrote: On 01/14/2015 10:15 AM, Petr Viktorin wrote: On 01/13/2015 10:52 PM, Martin Kosek

Re: [Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

2015-01-14 Thread Alexander Bokovoy
On Wed, 14 Jan 2015, Simo Sorce wrote: On Wed, 14 Jan 2015 13:41:54 +0100 thierry bordaz tbor...@redhat.com wrote: On 01/14/2015 12:03 PM, Martin Kosek wrote: On 01/14/2015 10:58 AM, thierry bordaz wrote: On 01/14/2015 10:15 AM, Petr Viktorin wrote: On 01/13/2015 10:52 PM, Martin Kosek

[Freeipa-devel] [PATCH 0002] Changing the token owner also changes its manager

2015-01-14 Thread Martin Babinsky
Changing the owner of a token also implicitly sets the new owner as its manager if following conditions are met: 1.) The original token owner was also its manager 2.) The new manager is not set explicitly via CLI interface. If the owner is unset and the above conditions are met, then the

Re: [Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

2015-01-14 Thread Martin Kosek
On 01/14/2015 03:42 PM, Alexander Bokovoy wrote: On Wed, 14 Jan 2015, Simo Sorce wrote: On Wed, 14 Jan 2015 13:41:54 +0100 thierry bordaz tbor...@redhat.com wrote: On 01/14/2015 12:03 PM, Martin Kosek wrote: On 01/14/2015 10:58 AM, thierry bordaz wrote: On 01/14/2015 10:15 AM, Petr

Re: [Freeipa-devel] [PATCH 0002] Changing the token owner also changes its manager

2015-01-14 Thread Nathaniel McCallum
On Wed, 2015-01-14 at 16:49 +0100, Martin Babinsky wrote: Changing the owner of a token also implicitly sets the new owner as its manager if following conditions are met: 1.) The original token owner was also its manager 2.) The new manager is not set explicitly via CLI interface. If

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Tomas Babej
On 01/14/2015 02:55 PM, Gabe Alford wrote: Hello, In looking into https://fedorahosted.org/freeipa/ticket/4029 I am wondering if there should be separate ipa-advise test, Yes/No? Could be handy in the future to test more ipa-advise output? Or should this test be added to the

Re: [Freeipa-devel] [PATCH 0170, 0183] Detect and warn about invalid forwardzone configuration

2015-01-14 Thread Martin Basti
On 12/12/14 13:52, Martin Basti wrote: On 12/12/14 13:50, Martin Kosek wrote: On 12/11/2014 05:44 PM, Petr Spacek wrote: On 11.12.2014 16:50, Martin Basti wrote: Updated aptch attached: Nice work, ACK! Can we also add some tests? This is a lot of new code that could break stuff. We

Re: [Freeipa-devel] [PATCH 0001] ipa-client-install: attempt to get host TGT several times before aborting client installation

2015-01-14 Thread Martin Babinsky
On 01/13/2015 04:48 PM, Martin Babinsky wrote: On 01/13/2015 09:46 AM, Jan Cholasta wrote: Dne 13.1.2015 v 09:22 Martin Kosek napsal(a): On 01/12/2015 05:45 PM, Martin Babinsky wrote: related to ticket https://fedorahosted.org/freeipa/ticket/4808 Patch attached. Martin^3 I think the

Re: [Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

2015-01-14 Thread Martin Kosek
On 01/14/2015 03:58 PM, Martin Kosek wrote: On 01/14/2015 03:34 PM, Simo Sorce wrote: On Wed, 14 Jan 2015 13:41:54 +0100 thierry bordaz tbor...@redhat.com wrote: On 01/14/2015 12:03 PM, Martin Kosek wrote: On 01/14/2015 10:58 AM, thierry bordaz wrote: On 01/14/2015 10:15 AM, Petr Viktorin

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Gabe Alford
On Wed, Jan 14, 2015 at 10:05 AM, Tomas Babej tba...@redhat.com wrote: On 01/14/2015 06:00 PM, Tomas Babej wrote: On 01/14/2015 05:37 PM, Tomas Babej wrote: On 01/14/2015 02:55 PM, Gabe Alford wrote: Hello, In looking into https://fedorahosted.org/freeipa/ticket/4029 I am

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Tomas Babej
On 01/14/2015 06:00 PM, Tomas Babej wrote: On 01/14/2015 05:37 PM, Tomas Babej wrote: On 01/14/2015 02:55 PM, Gabe Alford wrote: Hello, In looking into https://fedorahosted.org/freeipa/ticket/4029 I am wondering if there should be separate ipa-advise test, Yes/No? Could be handy

Re: [Freeipa-devel] [PATCH 0001] ipa-client-install: attempt to get host TGT several times before aborting client installation

2015-01-14 Thread Martin Babinsky
On 01/14/2015 04:53 PM, Martin Babinsky wrote: On 01/13/2015 04:48 PM, Martin Babinsky wrote: On 01/13/2015 09:46 AM, Jan Cholasta wrote: Dne 13.1.2015 v 09:22 Martin Kosek napsal(a): On 01/12/2015 05:45 PM, Martin Babinsky wrote: related to ticket

Re: [Freeipa-devel] [PATCH 0002] Changing the token owner also changes its manager

2015-01-14 Thread Martin Babinsky
On 01/14/2015 05:23 PM, Nathaniel McCallum wrote: On Wed, 2015-01-14 at 16:49 +0100, Martin Babinsky wrote: Changing the owner of a token also implicitly sets the new owner as its manager if following conditions are met: 1.) The original token owner was also its manager 2.) The new manager is

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Tomas Babej
On 01/14/2015 05:37 PM, Tomas Babej wrote: On 01/14/2015 02:55 PM, Gabe Alford wrote: Hello, In looking into https://fedorahosted.org/freeipa/ticket/4029 I am wondering if there should be separate ipa-advise test, Yes/No? Could be handy in the future to test more ipa-advise output?

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Tomas Babej
On 01/14/2015 06:13 PM, Gabe Alford wrote: On Wed, Jan 14, 2015 at 10:05 AM, Tomas Babej tba...@redhat.com mailto:tba...@redhat.com wrote: On 01/14/2015 06:00 PM, Tomas Babej wrote: On 01/14/2015 05:37 PM, Tomas Babej wrote: On 01/14/2015 02:55 PM, Gabe Alford wrote:

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-14 Thread Martin Kosek
On 01/13/2015 06:02 PM, Jan Cholasta wrote: Dne 13.1.2015 v 17:45 Jan Cholasta napsal(a): Dne 13.1.2015 v 16:37 Petr Vobornik napsal(a): On 01/13/2015 02:26 PM, Jan Cholasta wrote: Dne 13.1.2015 v 13:01 Petr Vobornik napsal(a): On 01/12/2015 02:28 PM, Jan Cholasta wrote: Hi, the attached

Re: [Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

2015-01-14 Thread Petr Viktorin
On 01/13/2015 10:52 PM, Martin Kosek wrote: On 01/13/2015 09:55 PM, Simo Sorce wrote: On Tue, 13 Jan 2015 18:16:11 +0100 Martin Kosek mko...@redhat.com wrote: This is crude first version of the (working) fixes to fix Winsync/Passsync problems caused by the PermissionV2 refactoring.

Re: [Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

2015-01-14 Thread thierry bordaz
On 01/14/2015 10:15 AM, Petr Viktorin wrote: On 01/13/2015 10:52 PM, Martin Kosek wrote: On 01/13/2015 09:55 PM, Simo Sorce wrote: On Tue, 13 Jan 2015 18:16:11 +0100 Martin Kosek mko...@redhat.com wrote: This is crude first version of the (working) fixes to fix Winsync/Passsync problems

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Gabe Alford
Hello, In looking into https://fedorahosted.org/freeipa/ticket/4029 I am wondering if there should be separate ipa-advise test, Yes/No? Could be handy in the future to test more ipa-advise output? Or should this test be added to the test_legacy_clients.py? Thanks, Gabe On Tue, Dec 2,

Re: [Freeipa-devel] [PATCH 0296] ipatests: Make descriptions of declarative tests sorted according to their order

2015-01-14 Thread Petr Viktorin
On 12/19/2014 03:05 PM, Tomas Babej wrote: Hi, this allows us to sort the descriptions and preserve the test order. ACK -- PetrĀ³ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-14 Thread Petr Viktorin
On 01/14/2015 09:14 AM, Martin Kosek wrote: On 01/13/2015 06:02 PM, Jan Cholasta wrote: Rebased again, patch attached. Given that Petr is not there today, I finished the review for him. I did not find any other issues, all issues except (2) are fixed. ACK. Pushed to master (rebased) and

Re: [Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

2015-01-14 Thread Martin Kosek
On 01/14/2015 10:37 AM, thierry bordaz wrote: On 01/14/2015 10:15 AM, Petr Viktorin wrote: On 01/13/2015 10:52 PM, Martin Kosek wrote: On 01/13/2015 09:55 PM, Simo Sorce wrote: On Tue, 13 Jan 2015 18:16:11 +0100 Martin Kosek mko...@redhat.com wrote: This is crude first version of the

Re: [Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

2015-01-14 Thread thierry bordaz
On 01/14/2015 10:15 AM, Petr Viktorin wrote: On 01/13/2015 10:52 PM, Martin Kosek wrote: On 01/13/2015 09:55 PM, Simo Sorce wrote: On Tue, 13 Jan 2015 18:16:11 +0100 Martin Kosek mko...@redhat.com wrote: This is crude first version of the (working) fixes to fix Winsync/Passsync problems

Re: [Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

2015-01-14 Thread Martin Kosek
On 01/14/2015 10:58 AM, thierry bordaz wrote: On 01/14/2015 10:15 AM, Petr Viktorin wrote: On 01/13/2015 10:52 PM, Martin Kosek wrote: On 01/13/2015 09:55 PM, Simo Sorce wrote: On Tue, 13 Jan 2015 18:16:11 +0100 Martin Kosek mko...@redhat.com wrote: This is crude first version of the

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-14 Thread Martin Kosek
On 01/14/2015 12:35 PM, Petr Viktorin wrote: On 01/14/2015 09:14 AM, Martin Kosek wrote: On 01/13/2015 06:02 PM, Jan Cholasta wrote: Rebased again, patch attached. Given that Petr is not there today, I finished the review for him. I did not find any other issues, all issues except (2) are

Re: [Freeipa-devel] [PATCHES] 0684-0687 Use tracker fixture in host plugin tests

2015-01-14 Thread Tomas Babej
On 01/06/2015 03:49 PM, Petr Viktorin wrote: The first patch enables pylint to run on tests. Some of the exceptions I've added are pretty heavy-handed, but the main thing I wanted to enable is checking for duplicate test function/method names, since in that case the earlier test is silently

Re: [Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

2015-01-14 Thread thierry bordaz
On 01/14/2015 12:03 PM, Martin Kosek wrote: On 01/14/2015 10:58 AM, thierry bordaz wrote: On 01/14/2015 10:15 AM, Petr Viktorin wrote: On 01/13/2015 10:52 PM, Martin Kosek wrote: On 01/13/2015 09:55 PM, Simo Sorce wrote: On Tue, 13 Jan 2015 18:16:11 +0100 Martin Kosek mko...@redhat.com

Re: [Freeipa-devel] [PATCH 0296] ipatests: Make descriptions of declarative tests sorted according to their order

2015-01-14 Thread Tomas Babej
On 01/14/2015 11:53 AM, Petr Viktorin wrote: On 12/19/2014 03:05 PM, Tomas Babej wrote: Hi, this allows us to sort the descriptions and preserve the test order. ACK Pushed to master: 5416652f6f15de4cc2140a58466facdf07c70965 -- Tomas Babej Associate Software Engineer | Red Hat | Identity