Re: [Freeipa-devel] [PATCH 536] ipapython: remove default_encoding_utf8

2016-01-05 Thread Tomas Babej
On 01/05/2016 08:54 AM, Jan Cholasta wrote: > Hi, > > the attached patch replaces the default_encoding_utf8 binary module with > 2 lines of equivalent Python code. > > Honza > > > This looks fine to me, however, I wonder, why this approach was ever taken? The sys.setdefaultencoding is

Re: [Freeipa-devel] 4.3 on rawhide build task fail

2016-01-05 Thread Lukas Slebodnik
On (22/12/15 16:31), Petr Vobornik wrote: >Build of 4.3 on Fedora rawhide failed at the end on rpmdiff check. Builds for >all arches were successful and also works in COPR. > 0 free 1 open 4 done 0 failed >12284450 build (rawhide, /freeipa:b2442d51ba3f2a5f907f72e9bd90c5889bd89c0e): >open

Re: [Freeipa-devel] 4.3 on rawhide build task fail

2016-01-05 Thread Lukas Slebodnik
On (05/01/16 10:37), Lukas Slebodnik wrote: >On (22/12/15 16:31), Petr Vobornik wrote: >>Build of 4.3 on Fedora rawhide failed at the end on rpmdiff check. Builds for >>all arches were successful and also works in COPR. >> 0 free 1 open 4 done 0 failed >>12284450 build (rawhide,

Re: [Freeipa-devel] [PATCH 536] ipapython: remove default_encoding_utf8

2016-01-05 Thread Jan Cholasta
On 5.1.2016 11:54, Alexander Bokovoy wrote: On Tue, 05 Jan 2016, Tomas Babej wrote: On 01/05/2016 08:54 AM, Jan Cholasta wrote: Hi, the attached patch replaces the default_encoding_utf8 binary module with 2 lines of equivalent Python code. Honza This looks fine to me, however, I

[Freeipa-devel] [PATCH 0120] prevent crash of CA-less server upgrade due to absent certmonger

2016-01-05 Thread Martin Babinsky
fixes https://fedorahosted.org/freeipa/ticket/5519 -- Martin^3 Babinsky From d5e6dadf7e092b389284a753ec55e2448446f3d5 Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Tue, 5 Jan 2016 13:00:24 +0100 Subject: [PATCH] prevent crash of CA-less server upgrade due to absent

[Freeipa-devel] [PATCH 154] ipa-kdb: map_groups() consider all results

2016-01-05 Thread Sumit Bose
Hi, to find out to which local group a external user is mapped we do a dereference search over the external groups with the SIDs related to the external user. If a SID is mapped to more than one external group we currently consider only the first returned match. With this patch all results are

Re: [Freeipa-devel] [PATCH 536] ipapython: remove default_encoding_utf8

2016-01-05 Thread Alexander Bokovoy
On Tue, 05 Jan 2016, Jan Cholasta wrote: On 5.1.2016 11:54, Alexander Bokovoy wrote: On Tue, 05 Jan 2016, Tomas Babej wrote: On 01/05/2016 08:54 AM, Jan Cholasta wrote: Hi, the attached patch replaces the default_encoding_utf8 binary module with 2 lines of equivalent Python code. Honza

[Freeipa-devel] [PATCH] 0048 Decode HTTP reason phrase as iso-8859-1

2016-01-05 Thread Fraser Tweedale
Happy new year, all. The attached patch fixes a unicode decode error triggered in some locales, which causes failure of installation (and probably other oprations, if locale is changed under an existing server). https://fedorahosted.org/freeipa/ticket/5578 Cheers, Fraser From

[Freeipa-devel] [pytest-multihost-devel][PATCH] Warn user about missing multihost conf file

2016-01-05 Thread Abhijeet Kasurde
Hi All, Please review attached patch Fixes : https://fedorahosted.org/python-pytest-multihost/ticket/3 Thanks, Abhijeet Kasurde From 0fc2238dd0bd26a789232ffaec058ac59f304e43 Mon Sep 17 00:00:00 2001 From: Abhijeet Kasurde Date: Wed, 6 Jan 2016 11:38:24 +0530 Subject:

Re: [Freeipa-devel] [PATCH] Added kpasswd_server directive in client krb5.conf

2016-01-05 Thread Abhijeet Kasurde
Hi All, On 01/05/2016 04:52 PM, Christian Heimes wrote: On 2016-01-04 23:38, Nalin Dahyabhai wrote: On Mon, Dec 21, 2015 at 12:17:08PM +0530, Abhijeet Kasurde wrote: Hi All, Please review patches attached. The port number should probably be changed from 749 to 464. Nalin is correct.

Re: [Freeipa-devel] [PATCH 559] Fix kadmin for new users

2016-01-05 Thread Martin Babinsky
On 11/25/2015 03:41 PM, Martin Kosek wrote: On 11/25/2015 03:32 PM, Simo Sorce wrote: On Wed, 2015-11-25 at 14:13 +0100, Tomas Babej wrote: On 11/25/2015 02:13 PM, Tomas Babej wrote: On 11/25/2015 02:00 PM, Martin Babinsky wrote: On 11/24/2015 11:32 PM, Simo Sorce wrote: Ticket #937 was

Re: [Freeipa-devel] [PATCH 559] Fix kadmin for new users

2016-01-05 Thread Martin Kosek
On 01/06/2016 08:37 AM, Martin Babinsky wrote: > On 11/25/2015 03:41 PM, Martin Kosek wrote: >> On 11/25/2015 03:32 PM, Simo Sorce wrote: >>> On Wed, 2015-11-25 at 14:13 +0100, Tomas Babej wrote: On 11/25/2015 02:13 PM, Tomas Babej wrote: > > > On 11/25/2015 02:00 PM, Martin

Re: [Freeipa-devel] [PATCH 565] Fix potential aborts in KDB driver

2016-01-05 Thread Simo Sorce
On Tue, 2016-01-05 at 16:15 -0500, Simo Sorce wrote: > The LDAP context was not checked on the first api call and a context may > be null on some error conditions (LDAP server unreachable). > > Always check that we have a valid context before calling the ldap API. > > Builds abut it is untested.

[Freeipa-devel] [PATCH 027] Require Dogtag 10.2.6-13 to fix KRA uninstall

2016-01-05 Thread Christian Heimes
The combination of a bug in Dogtag's sslget command and a new feature in mod_nss causes an incomplete uninstallation of KRA. The bug has been fixed in Dogtag 10.2.6-13. https://fedorahosted.org/freeipa/ticket/5469 https://fedorahosted.org/pki/ticket/1704 Signed-off-by: Christian Heimes

Re: [Freeipa-devel] Added kpasswd_server directive in client krb5.conf

2016-01-05 Thread Christian Heimes
On 2016-01-04 23:38, Nalin Dahyabhai wrote: > On Mon, Dec 21, 2015 at 12:17:08PM +0530, Abhijeet Kasurde wrote: >> Hi All, >> >> Please review patches attached. > > The port number should probably be changed from 749 to 464. Nalin is correct. kpasswd and admin server use different ports: $

Re: [Freeipa-devel] [PATCH 536] ipapython: remove default_encoding_utf8

2016-01-05 Thread Alexander Bokovoy
On Tue, 05 Jan 2016, Tomas Babej wrote: On 01/05/2016 08:54 AM, Jan Cholasta wrote: Hi, the attached patch replaces the default_encoding_utf8 binary module with 2 lines of equivalent Python code. Honza This looks fine to me, however, I wonder, why this approach was ever taken? The

Re: [Freeipa-devel] 4.3 on rawhide build task fail

2016-01-05 Thread Petr Vobornik
On 01/05/2016 10:55 AM, Lukas Slebodnik wrote: On (05/01/16 10:37), Lukas Slebodnik wrote: On (22/12/15 16:31), Petr Vobornik wrote: Build of 4.3 on Fedora rawhide failed at the end on rpmdiff check. Builds for all arches were successful and also works in COPR. 0 free 1 open 4 done 0 failed

[Freeipa-devel] [PATCH 565] Fix potential aborts in KDB driver

2016-01-05 Thread Simo Sorce
The LDAP context was not checked on the first api call and a context may be null on some error conditions (LDAP server unreachable). Always check that we have a valid context before calling the ldap API. Builds abut it is untested. Simo. -- Simo Sorce * Red Hat, Inc * New York From

Re: [Freeipa-devel] [PATCH 027] Require Dogtag 10.2.6-13 to fix KRA uninstall

2016-01-05 Thread Lukas Slebodnik
On (05/01/16 12:24), Christian Heimes wrote: >The combination of a bug in Dogtag's sslget command and a new feature >in mod_nss causes an incomplete uninstallation of KRA. The bug has been >fixed in Dogtag 10.2.6-13. > and it ins in fedora 23 stable for a week