[Freeipa-devel] [freeipa PR#76][comment] Keep NSS trust flags of existing certificates

2016-09-19 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/76 Title: #76: Keep NSS trust flags of existing certificates flo-renaud commented: """ (re-sending as setting the review state did not send any email) Hi Tomas, thanks for your patch. Works as expected. """ See the full comment at

[Freeipa-devel] [freeipa PR#76][+ack] Keep NSS trust flags of existing certificates

2016-09-19 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/76 Title: #76: Keep NSS trust flags of existing certificates Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#87][comment] dns: re-introduce --raw in dnsrecord-del

2016-09-19 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/87 Title: #87: dns: re-introduce --raw in dnsrecord-del mbasti-rh commented: """ Works for me with server API. """ See the full comment at https://github.com/freeipa/freeipa/pull/87#issuecomment-247984671 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#90][opened] Update ipa-server-install man page for hostname

2016-09-19 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/90 Author: tomaskrizek Title: #90: Update ipa-server-install man page for hostname Action: opened PR body: """ Hostname is always set, remove the text that says hostname is set only if it does not match the current hostname.

Re: [Freeipa-devel] Github review feature

2016-09-19 Thread Ben Lipton
On 09/16/2016 03:17 AM, Martin Basti wrote: Sorry for stealing your thread, but you started asking about github review emails :) Standard review inline comments are disabled on purpose, each comment generates one email, so we decided that is better after review to write a regular comment

[Freeipa-devel] [freeipa PR#91][opened] Add help info about certificate revocation reasons

2016-09-19 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/91 Author: tomaskrizek Title: #91: Add help info about certificate revocation reasons Action: opened PR body: """ Inform the user where to find additional information about certificate revocation reasons.

[Freeipa-devel] [freeipa PR#87][+ack] dns: re-introduce --raw in dnsrecord-del

2016-09-19 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/87 Title: #87: dns: re-introduce --raw in dnsrecord-del Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#10][comment] Client-side CSR autogeneration

2016-09-19 Thread LiptonB
URL: https://github.com/freeipa/freeipa/pull/10 Title: #10: Client-side CSR autogeneration LiptonB commented: """ `csrgen` sounds good to me. The new modules have now been moved to `ipaclient.plugins.csrgen`, `ipaclient.csrgen`, and `ipatests.test_ipaclient.test_csrgen`. FYI: I force pushed

[Freeipa-devel] [freeipa PR#88][comment] test_plugable: update the rest of test_init

2016-09-19 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/88 Title: #88: test_plugable: update the rest of test_init mbasti-rh commented: """ Can you please remove unused import? """ See the full comment at https://github.com/freeipa/freeipa/pull/88#issuecomment-248033023 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#76][closed] Keep NSS trust flags of existing certificates

2016-09-19 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/76 Author: tomaskrizek Title: #76: Keep NSS trust flags of existing certificates Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/76/head:pr76 git checkout pr76 --

[Freeipa-devel] [freeipa PR#76][comment] Keep NSS trust flags of existing certificates

2016-09-19 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/76 Title: #76: Keep NSS trust flags of existing certificates mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/2bc70a5d5f5eb953969e7341179c5083c147221a ipa-4-3:

[Freeipa-devel] [freeipa PR#87][+pushed] dns: re-introduce --raw in dnsrecord-del

2016-09-19 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/87 Title: #87: dns: re-introduce --raw in dnsrecord-del Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#87][comment] dns: re-introduce --raw in dnsrecord-del

2016-09-19 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/87 Title: #87: dns: re-introduce --raw in dnsrecord-del mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/e5f7a612fbfdaa9ee12ef16cef550931011abe4c ipa-4-4:

[Freeipa-devel] [freeipa PR#76][+pushed] Keep NSS trust flags of existing certificates

2016-09-19 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/76 Title: #76: Keep NSS trust flags of existing certificates Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#92][opened] Add log messages for IP checks during client install

2016-09-19 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/92 Author: tomaskrizek Title: #92: Add log messages for IP checks during client install Action: opened PR body: """ The added log messages allow easier debugging of IP related issues during ipa-client-install.

[Freeipa-devel] [freeipa PR#87][closed] dns: re-introduce --raw in dnsrecord-del

2016-09-19 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/87 Author: jcholast Title: #87: dns: re-introduce --raw in dnsrecord-del Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/87/head:pr87 git checkout pr87 -- Manage

[Freeipa-devel] [freeipa PR#76][comment] Keep NSS trust flags of existing certificates

2016-09-19 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/76 Title: #76: Keep NSS trust flags of existing certificates mbasti-rh commented: """ This does not apply to ipa-4-2, please rebase and create a new PR for 4.2 """ See the full comment at

[Freeipa-devel] [freeipa PR#91][+ack] Add help info about certificate revocation reasons

2016-09-19 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/91 Title: #91: Add help info about certificate revocation reasons Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#91][comment] Add help info about certificate revocation reasons

2016-09-19 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/91 Title: #91: Add help info about certificate revocation reasons stlaz commented: """ Please, don't forget to add the ACK labels if you think the code should be pushed into FreeIPA. """ See the full comment at

[Freeipa-devel] [freeipa PR#88][synchronized] test_plugable: update the rest of test_init

2016-09-19 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/88 Author: jcholast Title: #88: test_plugable: update the rest of test_init Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/88/head:pr88 git checkout pr88 From

[Freeipa-devel] [freeipa PR#90][+ack] Update ipa-server-install man page for hostname

2016-09-19 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/90 Title: #90: Update ipa-server-install man page for hostname Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#86][comment] Made sssd restart a non-raising opration

2016-09-19 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/86 Title: #86: Made sssd restart a non-raising opration mirielka commented: """ Hi, so sorry about this, but the necessity of sssd restart was caused by some leftover mess on the machines where I ran the trust related tests. If the configuration is

[Freeipa-devel] [freeipa PR#10][comment] Client-side CSR autogeneration

2016-09-19 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/10 Title: #10: Client-side CSR autogeneration jcholast commented: """ 1. I'm afraid `certrequest` (actually `certreq`) is already taken. What about `csrgen`? 2. I would be perfectly happy with `ipaclient.`. 3. OK. Logistical stuff: - I'm fine with