[Freeipa-devel] [freeipa PR#199][opened] [ipa-4-4] Fix missing file that fails DL1 replica installation

2016-11-01 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/199 Author: stlaz Title: #199: [ipa-4-4] Fix missing file that fails DL1 replica installation Action: opened PR body: """ Replica installation on DL1 would fail to create a httpd instance due to missing '/etc/httpd/alias/cacert.asc'. Create this

Re: [Freeipa-devel] [PATCH] 0221 fix trustdomain-del

2016-11-01 Thread Martin Babinsky
On 10/31/2016 05:23 PM, Alexander Bokovoy wrote: See description. This is a regression since FreeIPA 4.4.0. Hi Alexander, Please link upstream ticket[1] to the commit message, not BZ. I have put on my Travis hat and found: 1.) pep8 error: ./ipaserver/plugins/trust.py:1623:25: E128

[Freeipa-devel] [freeipa PR#200][opened] Test: basic kerberos over http functionality

2016-11-01 Thread ofayans
URL: https://github.com/freeipa/freeipa/pull/200 Author: ofayans Title: #200: Test: basic kerberos over http functionality Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6446 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa

[Freeipa-devel] [freeipa PR#198][comment] Fix missing file that fails DL1 replica installation

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/198 Title: #198: Fix missing file that fails DL1 replica installation jcholast commented: """ Please rebase to ipa-4-4. """ See the full comment at https://github.com/freeipa/freeipa/pull/198#issuecomment-257500714 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#198][comment] Fix missing file that fails DL1 replica installation

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/198 Title: #198: Fix missing file that fails DL1 replica installation jcholast commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/842bf3d09f4b2de7d4b52005ac970594345455e0 """ See the full comment at

[Freeipa-devel] [freeipa PR#198][+pushed] Fix missing file that fails DL1 replica installation

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/198 Title: #198: Fix missing file that fails DL1 replica installation Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#198][+ack] Fix missing file that fails DL1 replica installation

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/198 Title: #198: Fix missing file that fails DL1 replica installation Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#200][synchronized] Test: basic kerberos over http functionality

2016-11-01 Thread ofayans
URL: https://github.com/freeipa/freeipa/pull/200 Author: ofayans Title: #200: Test: basic kerberos over http functionality Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/200/head:pr200 git checkout pr200

[Freeipa-devel] [freeipa PR#199][closed] [ipa-4-4] Fix missing file that fails DL1 replica installation

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/199 Author: stlaz Title: #199: [ipa-4-4] Fix missing file that fails DL1 replica installation Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/199/head:pr199 git

[Freeipa-devel] [freeipa PR#199][+ack] [ipa-4-4] Fix missing file that fails DL1 replica installation

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/199 Title: #199: [ipa-4-4] Fix missing file that fails DL1 replica installation Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#199][+pushed] [ipa-4-4] Fix missing file that fails DL1 replica installation

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/199 Title: #199: [ipa-4-4] Fix missing file that fails DL1 replica installation Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH] 0221 fix trustdomain-del

2016-11-01 Thread Alexander Bokovoy
On ti, 01 marras 2016, Martin Babinsky wrote: On 10/31/2016 05:23 PM, Alexander Bokovoy wrote: See description. This is a regression since FreeIPA 4.4.0. Hi Alexander, Please link upstream ticket[1] to the commit message, not BZ. I have put on my Travis hat and found: 1.) pep8 error:

[Freeipa-devel] [freeipa PR#200][synchronized] Test: basic kerberos over http functionality

2016-11-01 Thread ofayans
URL: https://github.com/freeipa/freeipa/pull/200 Author: ofayans Title: #200: Test: basic kerberos over http functionality Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/200/head:pr200 git checkout pr200

[Freeipa-devel] [freeipa PR#198][closed] Fix missing file that fails DL1 replica installation

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/198 Author: stlaz Title: #198: Fix missing file that fails DL1 replica installation Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/198/head:pr198 git checkout pr198

[Freeipa-devel] [freeipa PR#201][opened] spec file: bump minimal required version of 389-ds-base

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/201 Author: jcholast Title: #201: spec file: bump minimal required version of 389-ds-base Action: opened PR body: """ Require 389-ds-base >= 1.3.5.14 for: https://fedorahosted.org/389/ticket/48992 https://fedorahosted.org/freeipa/ticket/6369 """

[Freeipa-devel] [freeipa PR#201][comment] spec file: bump minimal required version of 389-ds-base

2016-11-01 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/201 Title: #201: spec file: bump minimal required version of 389-ds-base stlaz commented: """ ACK """ See the full comment at https://github.com/freeipa/freeipa/pull/201#issuecomment-257535867 -- Manage your subscription for the Freeipa-devel

Re: [Freeipa-devel] [PATCH] 0221 fix trustdomain-del

2016-11-01 Thread Martin Babinsky
On 11/01/2016 09:42 AM, Alexander Bokovoy wrote: On ti, 01 marras 2016, Martin Babinsky wrote: On 10/31/2016 05:23 PM, Alexander Bokovoy wrote: See description. This is a regression since FreeIPA 4.4.0. Hi Alexander, Please link upstream ticket[1] to the commit message, not BZ. I have

[Freeipa-devel] [freeipa PR#202][opened] ipa-getkeytab enhancements

2016-11-01 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/202 Author: martbab Title: #202: ipa-getkeytab enhancements Action: opened PR body: """ This PR implements '-H' and '-Y' options mentioned in https://fedorahosted.org/freeipa/ticket/6409 along with the ability to specify CA cert on the command line

[Freeipa-devel] [freeipa PR#201][+ack] spec file: bump minimal required version of 389-ds-base

2016-11-01 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/201 Title: #201: spec file: bump minimal required version of 389-ds-base Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#187][synchronized] Register entry points of Custodia plugins

2016-11-01 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/187 Author: tiran Title: #187: Register entry points of Custodia plugins Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/187/head:pr187 git checkout pr187 From

[Freeipa-devel] [freeipa PR#201][closed] spec file: bump minimal required version of 389-ds-base

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/201 Author: jcholast Title: #201: spec file: bump minimal required version of 389-ds-base Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/201/head:pr201 git checkout

[Freeipa-devel] [freeipa PR#197][synchronized] Make setup.py files PyPI compatible

2016-11-01 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/197 Author: tiran Title: #197: Make setup.py files PyPI compatible Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/197/head:pr197 git checkout pr197 From

[Freeipa-devel] [freeipa PR#201][+pushed] spec file: bump minimal required version of 389-ds-base

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/201 Title: #201: spec file: bump minimal required version of 389-ds-base Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#201][comment] spec file: bump minimal required version of 389-ds-base

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/201 Title: #201: spec file: bump minimal required version of 389-ds-base jcholast commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/f12abfb852dfb1a7759928b05defde68d5d7a3df ipa-4-4:

[Freeipa-devel] [freeipa PR#203][opened] Add sdist_list plugin to all setup.py

2016-11-01 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/203 Author: tiran Title: #203: Add sdist_list plugin to all setup.py Action: opened PR body: """ The sdist_list plugin creates a source distribution file list. Signed-off-by: Christian Heimes @pspacek here is your helper

[Freeipa-devel] [freeipa PR#203][comment] Add sdist_list plugin to all setup.py

2016-11-01 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/203 Title: #203: Add sdist_list plugin to all setup.py tiran commented: """ You have two options to work around the extra output 1. redirect stderr and use ```python setup.py --quiet sdist_list```. The order is import, ```python setup.py sdist_list

[Freeipa-devel] [freeipa PR#203][synchronized] Add sdist_list plugin to all setup.py

2016-11-01 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/203 Author: tiran Title: #203: Add sdist_list plugin to all setup.py Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/203/head:pr203 git checkout pr203 From

[Freeipa-devel] [freeipa PR#203][comment] Add sdist_list plugin to all setup.py

2016-11-01 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/203 Title: #203: Add sdist_list plugin to all setup.py pspacek commented: """ Thanks for the propsal. It has several problems: - It prints extra text at the beginning of output. This makes the output unsuitable for automated processing. ~~~ $ python

[Freeipa-devel] [freeipa PR#204][opened] ipautil.run: Remove hardcoded environ PATH value

2016-11-01 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/204 Author: mbasti-rh Title: #204: ipautil.run: Remove hardcoded environ PATH value Action: opened PR body: """ This was introduced in commit d0ea0bb63891babd1c5778df2e291b527c8e927c as F14 compatibility. PATH should be always inherited from from

[Freeipa-devel] [freeipa PR#145][comment] Refactoring: LDAP Connection Management

2016-11-01 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: Refactoring: LDAP Connection Management tomaskrizek commented: """ In an offline discussion we decided not to push temporary changes to master. Here's the final code for review. """ See the full comment at

[Freeipa-devel] [freeipa PR#204][comment] ipautil.run: Remove hardcoded environ PATH value

2016-11-01 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/204 Title: #204: ipautil.run: Remove hardcoded environ PATH value mbasti-rh commented: """ Can you elaborate more about that attack? Do you have any links to share? If an attacker has permission to set a user environment variables, IMO the user has

[Freeipa-devel] [freeipa PR#204][synchronized] ipautil.run: Remove hardcoded environ PATH value

2016-11-01 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/204 Author: mbasti-rh Title: #204: ipautil.run: Remove hardcoded environ PATH value Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/204/head:pr204 git checkout

[Freeipa-devel] [freeipa PR#204][comment] ipautil.run: Remove hardcoded environ PATH value

2016-11-01 Thread rcritten
URL: https://github.com/freeipa/freeipa/pull/204 Title: #204: ipautil.run: Remove hardcoded environ PATH value rcritten commented: """ NACK. I'd be fine with changing the PATH to remove cruft but the primary purpose is to prevent an attacker from providing their own PATH with unknown

[Freeipa-devel] [freeipa PR#206][opened] Properly handle multiple cookies in rpcclient

2016-11-01 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/206 Author: simo5 Title: #206: Properly handle multiple cookies in rpcclient Action: opened PR body: """ The current code does not give a list of cookies, but a concatenated string separated by a comma. This is a format the Cookie class does not

[Freeipa-devel] [freeipa PR#204][comment] ipautil.run: Remove hardcoded environ PATH value

2016-11-01 Thread rcritten
URL: https://github.com/freeipa/freeipa/pull/204 Title: #204: ipautil.run: Remove hardcoded environ PATH value rcritten commented: """ This isn't about replacing existing binaries, it's about putting binaries into unexpected places that are in the default PATH (e.g. ~/bin or /usr/local/bin).

[Freeipa-devel] [freeipa PR#205][comment] Support DAL version 5 and version 6

2016-11-01 Thread frozencemetery
URL: https://github.com/freeipa/freeipa/pull/205 Title: #205: Support DAL version 5 and version 6 frozencemetery commented: """ Thank you for fixing this, and futureproofing the next version bump. Unless freeipa has a policy against it, I would prefer the use of designated initializers here

[Freeipa-devel] [freeipa PR#205][opened] Support DAL version 5 and version 6

2016-11-01 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/205 Author: simo5 Title: #205: Support DAL version 5 and version 6 Action: opened PR body: """ Should fix bz#1389866 (untested) """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#204][comment] ipautil.run: Remove hardcoded environ PATH value

2016-11-01 Thread rcritten
URL: https://github.com/freeipa/freeipa/pull/204 Title: #204: ipautil.run: Remove hardcoded environ PATH value rcritten commented: """ PATH is untrustworthy because there is no knowing what is in it, or the order. It could easily have /usr/local/bin first and some rogue version of a program

[Freeipa-devel] [freeipa PR#204][comment] ipautil.run: Remove hardcoded environ PATH value

2016-11-01 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/204 Title: #204: ipautil.run: Remove hardcoded environ PATH value mbasti-rh commented: """ > PATH is untrustworthy because there is no knowing what is in it, or the > order. It could easily have /usr/local/bin first and some rogue version of a >