URL: https://github.com/freeipa/freeipa/pull/244
Title: #244: Add templating to ipaplatform path [RFC]
mbasti-rh commented:
"""
Can you finish this PR? It can be tested and possibly merged
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/244#issuecomment-261997481
--
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with pkg_resource.parse_version
martbab commented:
"""
It seems that your changes broke IPA upgrade:
```
Done configuring the web interface (httpd).
Applying LDAP updates
Upgrading IPA:
[1/9]: stopping
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with pkg_resource.parse_version
tiran commented:
"""
setuptool's version parser does not support slicing. I need to find another
solution for ```verify_client_version()```.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/249
Title: #249: Remove references to ds_newinst.pl
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/687ebd18a1927cd6dcbb6cb884b979096c8a44aa
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/249
Author: frasertweedale
Title: #249: Remove references to ds_newinst.pl
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/249/head:pr249
git checkout pr249
--
URL: https://github.com/freeipa/freeipa/pull/249
Title: #249: Remove references to ds_newinst.pl
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/255
Title: #255: Adjustments for setup requirements
mbasti-rh commented:
"""
I found some changes in versions of dependencies I don't like, because there is
no explanation why it is needed and it is out of sync between specfile and
setup.py
"""
URL: https://github.com/freeipa/freeipa/pull/212
Author: mbasti-rh
Title: #212: KRA: don't add KRA container when KRA replica
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/212/head:pr212
git checkout pr212
--
URL: https://github.com/freeipa/freeipa/pull/212
Title: #212: KRA: don't add KRA container when KRA replica
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/256
Title: #256: Pylint: whitelist packages with extension modules
mbasti-rh commented:
"""
LGTM, I'll test it tomorrow
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/256#issuecomment-261997895
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/212
Title: #212: KRA: don't add KRA container when KRA replica
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/61094a2a20f5cacdb7c87940d0db8d8593a87505
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/223
Title: #223: LDAP refactoring: remove admin_conn
mbasti-rh commented:
"""
LGTM and Works for me, but I have to make sure that things I wrote inline
won''t happen
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/223
Title: #223: LDAP refactoring: remove admin_conn
mbasti-rh commented:
"""
LGTM and Works for me, but I have to make sure that things I wrote inline
didn't happen
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/231
Title: #231: Do not log DM password in ca/kra installation logs
tomaskrizek commented:
"""
I agree. We need to re-add `self.dm_password` to `nolog_list`, just like it was
before I removed it
URL: https://github.com/freeipa/freeipa/pull/258
Title: #258: Break ipaplatform / ipalib import cycle of hell
jcholast commented:
"""
The original code is broken by design IMO. The API object is used only to get
the configured service startup timeout and to guess our DS instance name. None
of
URL: https://github.com/freeipa/freeipa/pull/244
Title: #244: Add templating to ipaplatform path [RFC]
jcholast commented:
"""
Also LGTM.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/244#issuecomment-262162424
--
Manage your subscription for the Freeipa-devel mailing
On 11.11.2016 18:28, Christian Heimes wrote:
On 2016-11-11 17:46, Martin Basti wrote:
On 11.11.2016 15:25, Christian Heimes wrote:
Hello,
I have released the first version of a new design document. It describes
how I'm going to improve integration of FreeIPA's client libraries
(ipalib,
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with pkg_resource.parse_version
tiran commented:
"""
Back to ```parse_version```!
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/254#issuecomment-261886678
--
Manage your subscription for
On 21.11.2016 11:32, Christian Heimes wrote:
> On 2016-11-21 10:26, Jan Cholasta wrote:
>> On 11.11.2016 18:28, Christian Heimes wrote:
>>> On 2016-11-11 17:46, Martin Basti wrote:
On 11.11.2016 15:25, Christian Heimes wrote:
> Hello,
>
> I have released the first
URL: https://github.com/freeipa/freeipa/pull/223
Author: tomaskrizek
Title: #223: LDAP refactoring: remove admin_conn
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/223/head:pr223
git checkout pr223
From
On 2016-11-21 10:46, Jan Cholasta wrote:
> On 21.11.2016 10:32, Christian Heimes wrote:
>> On 2016-11-21 10:26, Jan Cholasta wrote:
>>> On 11.11.2016 18:28, Christian Heimes wrote:
On 2016-11-11 17:46, Martin Basti wrote:
>
>
> On 11.11.2016 15:25, Christian Heimes wrote:
>>
URL: https://github.com/freeipa/freeipa/pull/254
Author: tiran
Title: #254: Replace LooseVersion with pkg_resource.parse_version
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/254/head:pr254
git checkout
URL: https://github.com/freeipa/freeipa/pull/212
Title: #212: KRA: don't add KRA container when KRA replica
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/212
Title: #212: KRA: don't add KRA container when KRA replica
stlaz commented:
"""
ACK, works on both DLs.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/212#issuecomment-261890178
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/260
Author: pspacek
Title: #260: Build: fix path in ipa-ods-exporter.socket unit file
Action: opened
PR body:
"""
This fixes regression caused by incorrect
daemons/dnssec/ipa-ods-exporter.socket.in path template introduced
in commit
URL: https://github.com/freeipa/freeipa/pull/254
Author: tiran
Title: #254: Replace LooseVersion with parse_ipa_version()
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/254/head:pr254
git checkout pr254
URL: https://github.com/freeipa/freeipa/pull/254
Author: tiran
Title: #254: Replace LooseVersion with pkg_resource.parse_version
Action: edited
Changed field: title
Original value:
"""
Replace LooseVersion with parse_ipa_version()
"""
--
Manage your subscription for the Freeipa-devel
On 21.11.2016 10:32, Christian Heimes wrote:
On 2016-11-21 10:26, Jan Cholasta wrote:
On 11.11.2016 18:28, Christian Heimes wrote:
On 2016-11-11 17:46, Martin Basti wrote:
On 11.11.2016 15:25, Christian Heimes wrote:
Hello,
I have released the first version of a new design document. It
On 2016-11-21 10:26, Jan Cholasta wrote:
> On 11.11.2016 18:28, Christian Heimes wrote:
>> On 2016-11-11 17:46, Martin Basti wrote:
>>>
>>>
>>> On 11.11.2016 15:25, Christian Heimes wrote:
Hello,
I have released the first version of a new design document. It
describes
how
On 21.11.2016 11:04, Christian Heimes wrote:
On 2016-11-21 10:46, Jan Cholasta wrote:
On 21.11.2016 10:32, Christian Heimes wrote:
On 2016-11-21 10:26, Jan Cholasta wrote:
On 11.11.2016 18:28, Christian Heimes wrote:
On 2016-11-11 17:46, Martin Basti wrote:
On 11.11.2016 15:25, Christian
On 2016-11-21 11:38, Jan Cholasta wrote:
> On 21.11.2016 11:04, Christian Heimes wrote:
>> On 2016-11-21 10:46, Jan Cholasta wrote:
>>> On 21.11.2016 10:32, Christian Heimes wrote:
On 2016-11-21 10:26, Jan Cholasta wrote:
> On 11.11.2016 18:28, Christian Heimes wrote:
>> On 2016-11-11
URL: https://github.com/freeipa/freeipa/pull/258
Author: tiran
Title: #258: Break ipaplatform / ipalib import cycle of hell
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/258/head:pr258
git checkout pr258
URL: https://github.com/freeipa/freeipa/pull/258
Title: #258: Break ipaplatform / ipalib import cycle of hell
tiran commented:
"""
thx @mbasti-rh . I took care of it.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/258#issuecomment-261889771
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
pspacek commented:
"""
@tiran You are right, I forgot to remove the `config.rpath` when
`AM_GNU_GETTEXT_VERSION` macro was introduced. This version fixes this problem
by
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
apophys commented:
"""
I think in this case we can go with keyword arguments only. Most of the uses of
the tracker in the tests do it already. What I will need in the case of
Hi,
On 11.11.2016 15:25, Christian Heimes wrote:
Hello,
I have released the first version of a new design document. It describes
how I'm going to improve integration of FreeIPA's client libraries
(ipalib, ipapython, ipaclient, ipaplatform) for third party developers.
URL: https://github.com/freeipa/freeipa/pull/260
Title: #260: Build: fix path in ipa-ods-exporter.socket unit file
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/261
Author: martbab
Title: #261: upgrade: do not set HTTP and DS principals explicitly
Action: opened
PR body:
"""
In ipa-server-upgrade, HTTP and DS principals are explicitly constructed from
realm, fqdn, and service prefix. This is no neither
On 21.11.2016 14:15, Christian Heimes wrote:
> On 2016-11-21 13:31, Jan Cholasta wrote:
>> Hi,
>>
>> On 11.11.2016 15:25, Christian Heimes wrote:
>>> Hello,
>>>
>>> I have released the first version of a new design document. It describes
>>> how I'm going to improve integration of FreeIPA's client
URL: https://github.com/freeipa/freeipa/pull/191
Title: #191: Exclude testing ipa.pot file from zanata
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/191
Title: #191: Exclude testing ipa.pot file from zanata
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/191
Author: mbasti-rh
Title: #191: Exclude testing ipa.pot file from zanata
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/191/head:pr191
git checkout pr191
--
URL: https://github.com/freeipa/freeipa/pull/191
Title: #191: Exclude testing ipa.pot file from zanata
martbab commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/ad32bf147ed6996c0967bb8e8cfb803113ceaf5f
ipa-4-4:
On 2016-11-21 13:31, Jan Cholasta wrote:
> Hi,
>
> On 11.11.2016 15:25, Christian Heimes wrote:
>> Hello,
>>
>> I have released the first version of a new design document. It describes
>> how I'm going to improve integration of FreeIPA's client libraries
>> (ipalib, ipapython, ipaclient,
URL: https://github.com/freeipa/freeipa/pull/231
Title: #231: Do not log DM password in ca/kra installation logs
martbab commented:
"""
Well that is what I was pointing at, by adding both DM and admin passwords to
the parent method's default `nolog_list`, you are future-proofing the code
On 2016-11-21 14:44, Petr Spacek wrote:
>>> 3.3 ipaplatform auto-configuration
>>>
>>> I'm not sure if guessing platform from ID_LIKE is really a good idea. It
>>> might work fine for centos -> rhel, but in general we can't really
>>> assume it will always work, as the platforms listed in ID_LIKE
URL: https://github.com/freeipa/freeipa/pull/223
Title: #223: LDAP refactoring: remove admin_conn
tomaskrizek commented:
"""
Depends on #262
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/223#issuecomment-261956124
--
Manage your subscription for the Freeipa-devel
URL: https://github.com/freeipa/freeipa/pull/262
Author: tomaskrizek
Title: #262: upgrade: do not explicitly set principal for services
Action: opened
PR body:
"""
After installer refactoring, principal is a property of service.
https://fedorahosted.org/freeipa/ticket/6500
"""
To pull the
On 21.11.2016 15:07, Christian Heimes wrote:
On 2016-11-21 14:44, Petr Spacek wrote:
3.3 ipaplatform auto-configuration
I'm not sure if guessing platform from ID_LIKE is really a good idea. It
might work fine for centos -> rhel, but in general we can't really
assume it will always work, as the
URL: https://github.com/freeipa/freeipa/pull/223
Author: tomaskrizek
Title: #223: LDAP refactoring: remove admin_conn
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/223/head:pr223
git checkout pr223
From
URL: https://github.com/freeipa/freeipa/pull/262
Title: #262: upgrade: do not explicitly set principal for services
martbab commented:
"""
Heh, I have opened https://github.com/freeipa/freeipa/pull/262 for this same
issue recently. Since you assigned yourself to the ticket and filled all
On 21.11.2016 14:15, Christian Heimes wrote:
On 2016-11-21 13:31, Jan Cholasta wrote:
Hi,
On 11.11.2016 15:25, Christian Heimes wrote:
Hello,
I have released the first version of a new design document. It describes
how I'm going to improve integration of FreeIPA's client libraries
(ipalib,
URL: https://github.com/freeipa/freeipa/pull/262
Title: #262: upgrade: do not explicitly set principal for services
martbab commented:
"""
Heh, I have opened PR#261 for this same issue recently. Since you assigned
yourself to the ticket and filled all required fields you win this race :).
"""
URL: https://github.com/freeipa/freeipa/pull/262
Title: #262: upgrade: do not explicitly set principal for services
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/261
Title: #261: upgrade: do not set HTTP and DS principals explicitly
martbab commented:
"""
Closing this as duplicate of https://github.com/freeipa/freeipa/pull/262
"""
See the full comment at
On 21.11.2016 15:25, Jan Cholasta wrote:
On 21.11.2016 15:07, Christian Heimes wrote:
On 2016-11-21 14:44, Petr Spacek wrote:
3.3 ipaplatform auto-configuration
I'm not sure if guessing platform from ID_LIKE is really a good
idea. It
might work fine for centos -> rhel, but in general we can't
URL: https://github.com/freeipa/freeipa/pull/262
Title: #262: upgrade: do not explicitly set principal for services
martbab commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/2793cdc8593c40d8318ec3685408ade6bf9a5320
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/262
Author: tomaskrizek
Title: #262: upgrade: do not explicitly set principal for services
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/262/head:pr262
git checkout
URL: https://github.com/freeipa/freeipa/pull/251
Title: #251: Add rebuild rule for template files
pspacek commented:
"""
I'm going to provide a proper fix as agreed on meeting today.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/251#issuecomment-261987023
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/251
Title: #251: Add rebuild rule for template files
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/260
Author: pspacek
Title: #260: Build: fix path in ipa-ods-exporter.socket unit file
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/260/head:pr260
git checkout
URL: https://github.com/freeipa/freeipa/pull/261
Title: #261: upgrade: do not set HTTP and DS principals explicitly
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/259
Title: #259: Minor fixes for IPAVersion class
mbasti-rh commented:
"""
LGTM, I'll test tomorrow
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/259#issuecomment-261995775
--
Manage your subscription for the Freeipa-devel
URL: https://github.com/freeipa/freeipa/pull/258
Title: #258: Break ipaplatform / ipalib import cycle of hell
mbasti-rh commented:
"""
LGTM, except the inline comment I made, I'll test it tomorrow
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/258#issuecomment-261995638
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
jcholast commented:
"""
@mbasti-rh: `knob()` already handles choices, it's the built-in `optparse`
module which does not display them. Once the installer code is migrated to
`argparse`,
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
mbasti-rh commented:
"""
@jcholast I know, but it doesn't fill `metavar` with choices. I don't know when
we will migrate to argparse, so I think until that we can extend it to show
URL: https://github.com/freeipa/freeipa/pull/245
Title: #245: Allow full customisability of IPA CA subject DN
tiran commented:
"""
@frasertweedale I don't have a clue, either. Let's ignore the message.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn,
xmlrpc_uri, ldap_uri
jcholast commented:
"""
Actually it should be created from domain name, which is the primary identifier
of an IPA domain, not from realm name.
"""
See
URL: https://github.com/freeipa/freeipa/pull/247
Title: #247: Add 'ipa local-env' subcommand
jcholast commented:
"""
Sorry, but this is wrong. `ipa env` is supposed to return local settings unless
run with `--server`. Why was it not fixed instead of adding a new redundant
command?
"""
See
URL: https://github.com/freeipa/freeipa/pull/247
Title: #247: Add 'ipa local-env' subcommand
tiran commented:
"""
@jcholast Please open a ticket.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/247#issuecomment-261879797
--
Manage your subscription for the Freeipa-devel
URL: https://github.com/freeipa/freeipa/pull/259
Title: #259: Minor fixes for IPAVersion class
tiran commented:
"""
I pulled the fix from PR #254
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/259#issuecomment-261881543
--
Manage your subscription for the Freeipa-devel
URL: https://github.com/freeipa/freeipa/pull/247
Title: #247: Add 'ipa local-env' subcommand
jcholast commented:
"""
Reopened 6490.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/247#issuecomment-261881844
--
Manage your subscription for the Freeipa-devel mailing list:
URL: https://github.com/freeipa/freeipa/pull/259
Author: tiran
Title: #259: Minor fixes for IPAVersion class
Action: opened
PR body:
"""
Py3: classes with __eq__ must provide __hash__ function or set __hash__
to None.
Comparison function like __eq__ must signal unsupported types by
returning
73 matches
Mail list logo
