[Freeipa-devel] [freeipa PR#687][synchronized] Add pki_pin only when needed

2017-04-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/687 Author: stlaz Title: #687: Add pki_pin only when needed Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/687/head:pr687 git checkout pr687 From 429f8dae4ea3b5

[Freeipa-devel] [freeipa PR#689][opened] Sort SRV records by priority

2017-04-04 Thread alex-zel
URL: https://github.com/freeipa/freeipa/pull/689 Author: alex-zel Title: #689: Sort SRV records by priority Action: opened PR body: """ In some cases where multiple SRV records are present, LDAP and Kerberos records were returned in different order, causing replication issues in a multi maste

[Freeipa-devel] [freeipa PR#684][closed] httpinstance: make sure NSS database is backed up

2017-04-04 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/684 Author: HonzaCholasta Title: #684: httpinstance: make sure NSS database is backed up Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/684/head:pr684 git checkout pr

[Freeipa-devel] [freeipa PR#684][+pushed] httpinstance: make sure NSS database is backed up

2017-04-04 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/684 Title: #684: httpinstance: make sure NSS database is backed up Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page

[Freeipa-devel] [freeipa PR#684][comment] httpinstance: make sure NSS database is backed up

2017-04-04 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/684 Title: #684: httpinstance: make sure NSS database is backed up HonzaCholasta commented: """ master: * 5f5a3b29dba7cc736ba334aefb55484baeefeb76 httpinstance: make sure NSS database is backed up ipa-4-5: * 471dfcbe1cc3f319da788add3661cb6d63e3c0

[Freeipa-devel] [freeipa PR#690][opened] server-install: remove broken no-pkinit check

2017-04-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/690 Author: stlaz Title: #690: server-install: remove broken no-pkinit check Action: opened PR body: """ Don't check for no-pkinit option in case pkinit cert file was provided. Setting no-pkinit is prohibited in this case, so without this fix we hav

[Freeipa-devel] [freeipa PR#677][comment] cert: defer cert-find result post-processing

2017-04-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/677 Title: #677: cert: defer cert-find result post-processing stlaz commented: """ What worries me the most is that the tests are green even though this is potentially a serious problem. """ See the full comment at https://github.com/freeipa/freeip

[Freeipa-devel] [freeipa PR#667][comment] idrange-mod: properly handle empty --dom-name option

2017-04-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/667 Title: #667: idrange-mod: properly handle empty --dom-name option stlaz commented: """ LGTM, except you're talking about `idrange-mod` in the commit message but are fixing `idrange-add` (`idrange-mod` does not have the option at all). """ See th

[Freeipa-devel] [freeipa PR#667][synchronized] idrange-mod: properly handle empty --dom-name option

2017-04-04 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/667 Author: flo-renaud Title: #667: idrange-mod: properly handle empty --dom-name option Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/667/head:pr667 git check

[Freeipa-devel] [freeipa PR#667][edited] idrange-mod: properly handle empty --dom-name option

2017-04-04 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/667 Author: flo-renaud Title: #667: idrange-mod: properly handle empty --dom-name option Action: edited Changed field: body Original value: """ When idrange-mod is called with --dom-name=, the CLI exits with ipa: ERROR: an internal error has occurr

[Freeipa-devel] [freeipa PR#667][edited] idrange-add: properly handle empty --dom-name option

2017-04-04 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/667 Author: flo-renaud Title: #667: idrange-add: properly handle empty --dom-name option Action: edited Changed field: title Original value: """ idrange-mod: properly handle empty --dom-name option """ -- Manage your subscription for the Freeipa-

[Freeipa-devel] [freeipa PR#667][comment] idrange-add: properly handle empty --dom-name option

2017-04-04 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/667 Title: #667: idrange-add: properly handle empty --dom-name option flo-renaud commented: """ Hi @stlaz I fixed the commit message. In contrary to what I told you offline, you need to configure an AD trust with ipa-adtrust-install and ipa trust-a

[Freeipa-devel] [freeipa PR#679][comment] Make sure remote hosts have our keys

2017-04-04 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/679 Title: #679: Make sure remote hosts have our keys pvoborni commented: """ Shouldn't the ticket number be: https://pagure.io/freeipa/issue/6838 ? """ See the full comment at https://github.com/freeipa/freeipa/pull/679#issuecomment-291553067 -- M

[Freeipa-devel] [freeipa PR#679][comment] Make sure remote hosts have our keys

2017-04-04 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/679 Title: #679: Make sure remote hosts have our keys simo5 commented: """ Seem like both errors are the same problem. Should we mark 6688 a duplicate of 6838 ? """ See the full comment at https://github.com/freeipa/freeipa/pull/679#issuecomment-291

[Freeipa-devel] [freeipa PR#679][comment] Make sure remote hosts have our keys

2017-04-04 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/679 Title: #679: Make sure remote hosts have our keys simo5 commented: """ Nevermind they are not duplicates. I'll fix the commit message. """ See the full comment at https://github.com/freeipa/freeipa/pull/679#issuecomment-291557263 -- Manage you

[Freeipa-devel] [freeipa PR#679][synchronized] Make sure remote hosts have our keys

2017-04-04 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/679 Author: simo5 Title: #679: Make sure remote hosts have our keys Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/679/head:pr679 git checkout pr679 From 5d9103

[Freeipa-devel] [freeipa PR#667][+ack] idrange-add: properly handle empty --dom-name option

2017-04-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/667 Title: #667: idrange-add: properly handle empty --dom-name option Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page

[Freeipa-devel] [freeipa PR#667][comment] idrange-add: properly handle empty --dom-name option

2017-04-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/667 Title: #667: idrange-add: properly handle empty --dom-name option stlaz commented: """ @flo-renaud That's completely OK :) I thought we could probably add an assert to `CIDict.__contains__()` method since I realize the issue was somewhere else th