[Freeipa-devel] [freeipa PR#726][opened] Add check for directory name

2017-04-20 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/726 Author: Akasurde Title: #726: Add check for directory name Action: opened PR body: """ Fix adds check to verify if user provided input is not a directory when filename is required. Fixes: https://pagure.io/freeipa/issue/6883 Signed-off-by:

[Freeipa-devel] [freeipa PR#725][opened] Fix certificate_out check in CertRetrieveOverride

2017-04-20 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/725 Author: Akasurde Title: #725: Fix certificate_out check in CertRetrieveOverride Action: opened PR body: """ Fixes: https://pagure.io/freeipa/issue/6885 Signed-off-by: Abhijeet Kasurde """ To pull the PR as Git branch:

[Freeipa-devel] [freeipa PR#724][+ack] upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is…

2017-04-20 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/724 Title: #724: upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is… Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#724][comment] upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is…

2017-04-20 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/724 Title: #724: upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is… abbra commented: """ LGTM """ See the full comment at https://github.com/freeipa/freeipa/pull/724#issuecomment-295855495 -- Manage your subscription for the

Re: [Freeipa-devel] [freeipa PR#724][opened] upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is…

2017-04-20 Thread Alexander Bokovoy
On to, 20 huhti 2017, flo-renaud wrote: URL: https://github.com/freeipa/freeipa/pull/724 Author: flo-renaud Title: #724: upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is… Action: opened PR body: """ … installed During upgrade, the plugin update_tdo_gidnumber is launched

[Freeipa-devel] [freeipa PR#688][comment] Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

2017-04-20 Thread redhatrises
URL: https://github.com/freeipa/freeipa/pull/688 Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches redhatrises commented: """ Should this also go into the 4.5 branch? """ See the full comment at

[Freeipa-devel] [freeipa PR#694][comment] RFC: implement local PKINIT deployment in server/replica install

2017-04-20 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/694 Title: #694: RFC: implement local PKINIT deployment in server/replica install martbab commented: """ @abbra I received an interactive review from @HonzaCholasta today and he is not very keen on idea of having ternary (absent/local/external/full)

[Freeipa-devel] [freeipa PR#694][comment] RFC: implement local PKINIT deployment in server/replica install

2017-04-20 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/694 Title: #694: RFC: implement local PKINIT deployment in server/replica install abbra commented: """ I agree that it is internal detail whether we use local pkinit or not. However, we need to know that it is existing as oposed to not existing at

[Freeipa-devel] [freeipa PR#688][comment] Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

2017-04-20 Thread redhatrises
URL: https://github.com/freeipa/freeipa/pull/688 Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches redhatrises commented: """ Bump for review """ See the full comment at https://github.com/freeipa/freeipa/pull/688#issuecomment-295713616 -- Manage your

[Freeipa-devel] [freeipa PR#722][closed] Fix server upgrade

2017-04-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/722 Author: stlaz Title: #722: Fix server upgrade Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/722/head:pr722 git checkout pr722 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#722][+ack] Fix server upgrade

2017-04-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/722 Title: #722: Fix server upgrade Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#722][comment] Fix server upgrade

2017-04-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/722 Title: #722: Fix server upgrade HonzaCholasta commented: """ master: * b38750eaa82025aad56f8eca849f47775b2cbc75 Fix CAInstance.import_ra_cert for empty passwords ipa-4-5: * e3f2878909c1f92a0d92ed2a8ce00c96135e1346 Fix

[Freeipa-devel] [freeipa PR#722][+pushed] Fix server upgrade

2017-04-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/722 Title: #722: Fix server upgrade Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#723][comment] Store GSSAPI session key in /var/run/httpd

2017-04-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/723 Title: #723: Store GSSAPI session key in /var/run/httpd HonzaCholasta commented: """ Could we put the mod_auth_gssapi session key in `/var/run/ipa/session.key`? `/var/run/ipa` is where we store IPA-specific stuff, including mod_auth_gssapi

[Freeipa-devel] [freeipa PR#723][comment] Store GSSAPI session key in /var/run/httpd

2017-04-20 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/723 Title: #723: Store GSSAPI session key in /var/run/httpd MartinBasti commented: """ Sure """ See the full comment at https://github.com/freeipa/freeipa/pull/723#issuecomment-295643034 -- Manage your subscription for the Freeipa-devel mailing

[Freeipa-devel] [freeipa PR#723][opened] Store GSSAPI session key in /var/run/httpd

2017-04-20 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/723 Author: MartinBasti Title: #723: Store GSSAPI session key in /var/run/httpd Action: opened PR body: """ Runtime data should be stored in /var/run instead of /etc/httpd/alias. This change is also compatible with selinux policy.

[Freeipa-devel] [freeipa PR#723][synchronized] Store GSSAPI session key in /var/run/httpd

2017-04-20 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/723 Author: MartinBasti Title: #723: Store GSSAPI session key in /var/run/httpd Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/723/head:pr723 git checkout

[Freeipa-devel] [freeipa PR#724][opened] upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is…

2017-04-20 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/724 Author: flo-renaud Title: #724: upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is… Action: opened PR body: """ … installed During upgrade, the plugin update_tdo_gidnumber is launched in order to add a gidnumber to the

[Freeipa-devel] [freeipa PR#694][comment] RFC: implement local PKINIT deployment in server/replica install

2017-04-20 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/694 Title: #694: RFC: implement local PKINIT deployment in server/replica install martbab commented: """ We can query that PKINIT was not configured at all by a) checking the presence of KDC keypair, b) checking the sysupgrade (no presence of pkinit

[Freeipa-devel] [freeipa PR#694][comment] RFC: implement local PKINIT deployment in server/replica install

2017-04-20 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/694 Title: #694: RFC: implement local PKINIT deployment in server/replica install abbra commented: """ Yep. Then this PR can be merged once you removed distinction external/full. """ See the full comment at

[Freeipa-devel] [freeipa PR#679][edited] Make sure remote hosts have our keys

2017-04-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/679 Author: simo5 Title: #679: Make sure remote hosts have our keys Action: edited Changed field: body Original value: """ In complex replication setups a replica may try to obtain CA keys from a host that is not the master we initially create the

[Freeipa-devel] Pagure issue template

2017-04-20 Thread Petr Vobornik
Hi all, I'd like to improve quality of bug reports and RFEs. A possibility I see is to create and issue template [1]. What do you think of the following template? Should we use it? ### Request for enhancement As , I want so that . ### Bug What doesn't work (what was

[Freeipa-devel] [freeipa PR#722][opened] Fix server upgrade

2017-04-20 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/722 Author: stlaz Title: #722: Fix server upgrade Action: opened PR body: """ OpenSSL can't cope with empty files, add a newline after each password https://pagure.io/freeipa/issue/6878 """ To pull the PR as Git branch: git remote add ghfreeipa

[Freeipa-devel] [freeipa PR#715][closed] use correct option name

2017-04-20 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/715 Author: realsobek Title: #715: use correct option name Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/715/head:pr715 git checkout pr715 -- Manage your

[Freeipa-devel] [freeipa PR#715][+rejected] use correct option name

2017-04-20 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/715 Title: #715: use correct option name Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#715][comment] use correct option name

2017-04-20 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/715 Title: #715: use correct option name stlaz commented: """ Since the changes here are part of https://github.com/freeipa/freeipa/pull/716, I am going to close this PR. """ See the full comment at

[Freeipa-devel] [freeipa PR#694][comment] RFC: implement local PKINIT deployment in server/replica install

2017-04-20 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/694 Title: #694: RFC: implement local PKINIT deployment in server/replica install abbra commented: """ I read through the code and I believe it addresses all use cases we have been discussing. LGTM. """ See the full comment at

[Freeipa-devel] [freeipa PR#694][+ack] RFC: implement local PKINIT deployment in server/replica install

2017-04-20 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/694 Title: #694: RFC: implement local PKINIT deployment in server/replica install Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: