Re: [Freeipa-devel] [PATCH] cleanup of pam_sss

2009-07-22 Thread Sumit Bose
On Wed, Jul 22, 2009 at 08:46:13AM -0400, Simo Sorce wrote: On Wed, 2009-07-22 at 12:52 +0200, Sumit Bose wrote: this patch should make pam_sss.c considerably more readable and should allow to use modules like pam_cracklib together with pam_sss. I hope I have caught all corner cases.

Re: [Freeipa-devel] [PATCH] cleanup of pam_sss

2009-07-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/22/2009 08:59 AM, Sumit Bose wrote: On Wed, Jul 22, 2009 at 07:46:53AM -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/22/2009 06:52 AM, Sumit Bose wrote: Hi, this patch should make pam_sss.c

Re: [Freeipa-devel] [PATCH][SSSD] Minor cleanups in monitor.c

2009-07-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/22/2009 01:09 PM, Simo Sorce wrote: On Wed, 2009-07-22 at 12:40 -0400, Stephen Gallagher wrote: * Forgot to check for successful allocation * Used the wrong mem_ctx when allocating a timer event. ack Simo.

Re: [Freeipa-devel] Ubuntu interests in FreeIPA

2009-07-22 Thread Mathias Gug
Hi, Sorry for not following up earlier on this, but this topic has been recently brought on the Ubuntu freeipa team mailing list [1] [1]: https://lists.launchpad.net/freeipa/msg9.html Here are my comments mainly related to supporting openldap instead of 389DS in FreeIPA: On Tue, Jun 30,

Re: [Freeipa-devel] [PATCH] initial commit of log watcher (lwatch)

2009-07-22 Thread John Dennis
On 07/22/2009 03:05 PM, Stephen Gallagher wrote: Nack. The following things must be corrected before this patch will be accepted. General: The log file /tmp/lwatch.log is not usable by two users simultaneously. Each user should have his/her own log file or there should be a mechanism in place

Re: [Freeipa-devel] [PATCHES] c-ares integration

2009-07-22 Thread Simo Sorce
On Wed, 2009-07-22 at 20:09 +0200, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 All three patches with corrections are attached. Some comments inline. Patches look good to me, ack to all three. Simo. ___ Freeipa-devel mailing

Re: [Freeipa-devel] Ubuntu interests in FreeIPA

2009-07-22 Thread Dmitri Pal
Mathias Gug wrote: On Wed, Jul 22, 2009 at 04:44:49PM -0400, Dmitri Pal wrote: Looking at freeipa-1.2.1/ipa-server/ipa-slapi-plugins/, there are 4 plugins: * dna: Distributed Numeric Assignment plug-in I don't know of an openldap plugin providing the same functionality. However one