Re: [Freeipa-devel] [PATCH] Improve error messages

2009-07-31 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/28/2009 10:21 AM, Stephen Gallagher wrote: On 07/28/2009 08:58 AM, Jakub Hrozek wrote: Jenny found several cases where our error messages were not very descriptive. This patch adds a ERROR() call for those cases. The error message for

Re: [Freeipa-devel] [PATCH] Notify user when deleting nonexistent user or group

2009-07-31 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/31/2009 11:55 AM, Stephen Gallagher wrote: On 07/31/2009 06:02 AM, Jakub Hrozek wrote: On 07/30/2009 08:45 PM, Stephen Gallagher wrote: I'm going to nack the user notification patch. I think we need to think some more about this. The sysdb

Re: [Freeipa-devel] [PATCH] Replace TYPE_ERROR by ValidationError

2009-07-31 Thread Rob Crittenden
Pavel Zůna wrote: No more tracebacks when an INT parameter is beyond the type limit. Fix bug: 5107333 There will probably be more patches similar to this one in the future. TYPE_ERROR is used in a several places where a better suited exception is available. ack smime.p7s Description: