[Freeipa-devel] [PATCH] Require current versions of python-nss & python-lxml

2009-11-19 Thread John Dennis
This adds a new dependency on python-lxml. It also requires that python-nss be the current version (0.8). This is needed for the http authentication work I did for Jason which was added in a recent version of python-nss. This patch also fixes a deprecation warning concerning nssinit() which is depe

Re: [Freeipa-devel] [PATCH] Make NotImplementedError in rabase return the correct function name

2009-11-19 Thread Rob Crittenden
John Dennis wrote: Signed-off-by: John Dennis Make NotImplementedError in rabase return the correct function name The NotImplementedError's in rabase were returning the wrong function name, looks like a simple cut-n-paste bug. --- ipaserver/plugins/rabase.py |8 1 files changed

Re: [Freeipa-devel] [PATCH] Reading Int parameter class should respect radix prefix

2009-11-19 Thread Rob Crittenden
John Dennis wrote: Signed-off-by: John Dennis Reading INT parameter class should respect radix prefix The Int parameter class was not respecting any radix prefix (e.g. 0x) the user may have supplied. This patch implements _convert_scalar method for the Int class so that we can pass the special

Re: [Freeipa-devel] [PATCH] add new error class for certificate operations

2009-11-19 Thread Rob Crittenden
John Dennis wrote: add new error class for certificate operations --- ipalib/errors.py | 29 - 1 files changed, 28 insertions(+), 1 deletions(-) ___

Re: [Freeipa-devel] [PATCH] error strings in documentation were missing unicode specifier

2009-11-19 Thread Rob Crittenden
John Dennis wrote: error strings in documentation were missing unicode specifier --- ipalib/errors.py |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) ___ Free

Re: [Freeipa-devel] [PATCH] respect debug arg during server install

2009-11-19 Thread Rob Crittenden
John Dennis wrote: The debug flag (e.g. -d) was not being respected during server install. This patch corrects that. --- install/tools/ipa-server-install |1 + 1 files changed, 1 insertions(+), 0 deletions(-) ___

Re: [Freeipa-devel] [PATCH] 316 add tips to --help

2009-11-19 Thread Rob Crittenden
Pavel Zuna wrote: Rob Crittenden wrote: Add some tips for getting more help from ipa command. % ipa --help Usage: ipa [options] Options: -h, --helpshow this help message and exit -e KEY=VALSet environment variable KEY to VAL -c FILE Load configuration from FILE

Re: [Freeipa-devel] [PATCH] 314 handle LDAP bind failures gracefully

2009-11-19 Thread Rob Crittenden
Pavel Zuna wrote: Rob Crittenden wrote: Gracefully handle a valid kerberos ticket for a deleted entry. I saw this with a host where I joined a host, obtained a host principal, kinited to that principal, then deleted the host from the IPA server. The ticket was still valid so Apache let it thr

Re: [Freeipa-devel] [PATCH] Make ldap2.convert_attr_synonyms more robust against schema lookup fails.

2009-11-19 Thread Rob Crittenden
Pavel Zuna wrote: Rob Crittenden wrote: Pavel Zuna wrote: Rob Crittenden wrote: The user plugin is crapping out on line 317 of ldap2.py because attr is coming back None. The attribute it is looking for is member. I think the fix involves setting member_attributes = ['member'] to the user pl

Re: [Freeipa-devel] [PATCH] 311 more integrated client install

2009-11-19 Thread Rob Crittenden
Jason Gerard DeRose wrote: On Wed, 2009-11-11 at 11:39 -0500, Rob Crittenden wrote: This patch integrates ipa-join and ipa-rmkeytab into the client installer. This will join a machine to the IPA realm and fetch a host principal for /etc/krb5.keytab. On uninstall all principals for the realm w

[Freeipa-devel] [PATCH] Make NotImplementedError in rabase return the correct function name

2009-11-19 Thread John Dennis
Signed-off-by: John Dennis Make NotImplementedError in rabase return the correct function name The NotImplementedError's in rabase were returning the wrong function name, looks like a simple cut-n-paste bug. --- ipaserver/plugins/rabase.py |8 1 files changed, 4 insertions(+), 4

[Freeipa-devel] [PATCH] along with stdout, stderr also log the initial command

2009-11-19 Thread John Dennis
Signed-off-by: John Dennis along with stdout,stderr also log the initial command This implements better logging of external commands. Formerly we were just outputting stdout and stderr without labeling which was which. We also omitted the initial command and it's arguments. This made it difficul

[Freeipa-devel] [PATCH] If plugin fails to load log the traceback

2009-11-19 Thread John Dennis
Signed-off-by: John Dennis If plugin fails to load log the traceback If a plugin fails to load due to some kind of error it would be nice if the error log contained the traceback so you can examine what went wrong rather than being left blind as to why it failed to load. --- ipalib/plugable.p

[Freeipa-devel] [PATCH] Reading Int parameter class should respect radix prefix

2009-11-19 Thread John Dennis
Signed-off-by: John Dennis Reading INT parameter class should respect radix prefix The Int parameter class was not respecting any radix prefix (e.g. 0x) the user may have supplied. This patch implements _convert_scalar method for the Int class so that we can pass the special radix base of zero t

[Freeipa-devel] [PATCH] 317 fix location of CA

2009-11-19 Thread Rob Crittenden
The output of ipa-server-install pointed to the old location of the self-signed database, the 389-DS instance. It is now stored in the Apache NSS database. Also set a db password on the 389-DS NSS database. It was using a blank password. rob freeipa-317-ca.patch Description: application/mb

[Freeipa-devel] [PATCH] add new error class for certificate operations

2009-11-19 Thread John Dennis
add new error class for certificate operations --- ipalib/errors.py | 29 - 1 files changed, 28 insertions(+), 1 deletions(-) diff --git a/ipalib/errors.py b/ipalib/errors.py index 1c358cd..f23a636 100644 --- a/ipalib/errors.py +++ b/ipalib/errors.py @@ -89,7 +89,9

[Freeipa-devel] [PATCH] error strings in documentation were missing unicode specifier

2009-11-19 Thread John Dennis
error strings in documentation were missing unicode specifier --- ipalib/errors.py |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ipalib/errors.py b/ipalib/errors.py index 1c358cd..ca1851c 100644 --- a/ipalib/errors.py +++ b/ipalib/errors.py @@ -390,7 +390,7 @@ clas

[Freeipa-devel] [PATCH] respect debug arg during server install

2009-11-19 Thread John Dennis
The debug flag (e.g. -d) was not being respected during server install. This patch corrects that. --- install/tools/ipa-server-install |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/install/tools/ipa-server-install b/install/tools/ipa-server-install index 809d69a..44fc

[Freeipa-devel] [PATCH] Print only one line of docstrings in command listings.

2009-11-19 Thread Pavel Zuna
Full docstring is shown on `ipa help COMMAND` Pavel 0001-Print-only-one-line-of-docstrings-in-command-listing.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-d

Re: [Freeipa-devel] [PATCH] 316 add tips to --help

2009-11-19 Thread Pavel Zuna
Rob Crittenden wrote: Add some tips for getting more help from ipa command. % ipa --help Usage: ipa [options] Options: -h, --helpshow this help message and exit -e KEY=VALSet environment variable KEY to VAL -c FILE Load configuration from FILE -d, --debug

Re: [Freeipa-devel] [PATCH] 314 handle LDAP bind failures gracefully

2009-11-19 Thread Pavel Zuna
Rob Crittenden wrote: Gracefully handle a valid kerberos ticket for a deleted entry. I saw this with a host where I joined a host, obtained a host principal, kinited to that principal, then deleted the host from the IPA server. The ticket was still valid so Apache let it through but it failed

Re: [Freeipa-devel] [PATCH] Make ldap2.convert_attr_synonyms more robust against schema lookup fails.

2009-11-19 Thread Pavel Zuna
Rob Crittenden wrote: Pavel Zuna wrote: Rob Crittenden wrote: The user plugin is crapping out on line 317 of ldap2.py because attr is coming back None. The attribute it is looking for is member. I think the fix involves setting member_attributes = ['member'] to the user plugin. I wonder if

Re: [Freeipa-devel] [PATCH] 311 more integrated client install

2009-11-19 Thread Jason Gerard DeRose
On Wed, 2009-11-11 at 11:39 -0500, Rob Crittenden wrote: > This patch integrates ipa-join and ipa-rmkeytab into the client > installer. This will join a machine to the IPA realm and fetch a host > principal for /etc/krb5.keytab. > > On uninstall all principals for the realm will be removed from

Re: [Freeipa-devel] [PATCH] 310 clean up ipa-join return values

2009-11-19 Thread Jason Gerard DeRose
On Wed, 2009-11-11 at 11:36 -0500, Rob Crittenden wrote: > ipa-join calls ipa-getkeytab and returns whatever return value it does > so I want to be careful not to overlap the values and keep things unique > or meaning the same thing in both. > > This patch cleans up a few places. > > rob ack.

Re: [Freeipa-devel] Return values, CRUD, webUI

2009-11-19 Thread Jason Gerard DeRose
On Wed, 2009-11-18 at 15:15 +0100, Pavel Zuna wrote: > Jason Gerard DeRose wrote: > > The vast majority of our Command plugins subclass from one of the CRUD > > base classes, so in terms of return value consistency and API style, we > > need to focus most on them (and then adapt their style to the