Re: [Freeipa-devel] [PATCH] admiyo-0001-hash-params

2010-08-17 Thread Pavel Zuna
On 08/12/2010 08:36 PM, Adam Young wrote: I'll try to use a patch naming structure similar to what Pavel's using: This patch fixes https://fedorahosted.org/freeipa/ticket/135. Instead of HTML Params starting with '?' we use the Hash '#' as the startgin point. This keeps the broswer from

Re: [Freeipa-devel] [PATCH] Fix Update function on details page.

2010-08-17 Thread Adam Young
On 08/17/2010 09:09 AM, Pavel Zuna wrote: On 08/17/2010 03:08 PM, Pavel Zuna wrote: This is a fix to the setattr/addattr problem discussed in the thread: [Freeipa-devel] [PATCH] Change the behaviour of addattr/setattr parameters The problem was that parameters with no values are

[Freeipa-devel] Extending Details, user and otherwise

2010-08-17 Thread Adam Young
The structure of our details code is basciallt [categorid, categoryDisplay, atrrtibutes] and attributes are [attributeId, attributeDisplay, I've inlined the user details at the bottom as an example. In order to make these configuratble by the end user, here is a strawman proposal:

Re: [Freeipa-devel] [PATCH] Fix Update function on details page.

2010-08-17 Thread Adam Young
On 08/17/2010 09:09 AM, Pavel Zuna wrote: On 08/17/2010 03:08 PM, Pavel Zuna wrote: This is a fix to the setattr/addattr problem discussed in the thread: [Freeipa-devel] [PATCH] Change the behaviour of addattr/setattr parameters The problem was that parameters with no values are

Re: [Freeipa-devel] [PATCH] Clean ipa.js and make it load plugin meta-data over JSON-RPC.

2010-08-17 Thread Adam Young
On 08/10/2010 01:30 PM, Pavel Zuna wrote: What it means? Well, first I removed some development control variables from ipa.js. Namely useSampleData and sizelimit. I moved useSampleData to the top of index.xhtml. This way we won't forget about it when we don't need it anymore. sizelimit has

Re: [Freeipa-devel] [PATCH] Fix Update function on details page.

2010-08-17 Thread Adam Young
On 08/17/2010 09:09 AM, Pavel Zuna wrote: On 08/17/2010 03:08 PM, Pavel Zuna wrote: This is a fix to the setattr/addattr problem discussed in the thread: [Freeipa-devel] [PATCH] Change the behaviour of addattr/setattr parameters The problem was that parameters with no values are

Re: [Freeipa-devel] [PATCH] Clean details.js.

2010-08-17 Thread Adam Young
On 08/10/2010 01:30 PM, Pavel Zuna wrote: What does it mean? I removed duplicate code, that was pasted here from the user details page. ipa_details_init doesn't call ipa_init anymore. ipa_details_create takes a second optional parameter, that can be set to a container element if we want to

Re: [Freeipa-devel] [PATCH] Make user details work again in the webUI.

2010-08-17 Thread Adam Young
On 08/10/2010 01:31 PM, Pavel Zuna wrote: Unfortunately we can't have any javascript in *.inc files, because the browser will strip them for security reasons. I moved all the attribute callbacks etc. to the only logical place: user.js. It's fine for now, but user.js is going to need some