[Freeipa-devel] [PATCH] 42 Add group members to default output of sudorule-show

2011-02-15 Thread Jan Zelený
https://fedorahosted.org/freeipa/ticket/915 Jan From d624fa6db9c652565ce2555abc0f5e915e7fac97 Mon Sep 17 00:00:00 2001 From: Jan Zeleny jzel...@redhat.com Date: Tue, 15 Feb 2011 05:03:41 -0500 Subject: [PATCH] Add group members to default output of sudorule-show

[Freeipa-devel] [PATCH] Fix a typo in ipa-client-install man page

2011-02-15 Thread Jan Zelený
https://fedorahosted.org/freeipa/ticket/782 Jan From 14581a1507d846d9147799809aad2d8075eb1cb8 Mon Sep 17 00:00:00 2001 From: Jan Zeleny jzel...@redhat.com Date: Tue, 15 Feb 2011 05:56:10 -0500 Subject: [PATCH] Fix a typo in ipa-client-install man page https://fedorahosted.org/freeipa/ticket/782

[Freeipa-devel] [PATCH] 056 Note --ip-address parameter of ipa-replica-prepare in man page

2011-02-15 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 https://fedorahosted.org/freeipa/ticket/615 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk1aXbkACgkQHsardTLnvCVNgACZAYcYdlDnLXxzdjmbZRf70cgt

[Freeipa-devel] [PATCH] 057 Validate MX records

2011-02-15 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 https://fedorahosted.org/freeipa/ticket/967 I'm wondering whether to extend the patch - if the mail server name does not end with a dot, BIND treats it as relative to the zone. So if you do: ipa dnsrecord-add example.com @ --mx-rec=10

[Freeipa-devel] [PATCH] 031 Remove WebUI identifiers from global namespace

2011-02-15 Thread Martin Kosek
Many WebUI identifiers were defined in a global namespace. This is not a good programming practice and may result in name clashes, for example with other libraries. This patch moves these variables to IPA namespace or its sub-namespaces, if required. https://fedorahosted.org/freeipa/ticket/212

Re: [Freeipa-devel] [PATCH] 78 Use ldapi: instead of unsecured ldap: in ipa core tools.

2011-02-15 Thread Pavel Zuna
On 02/14/2011 04:53 PM, Rob Crittenden wrote: Pavel Zuna wrote: On 02/08/2011 01:06 PM, Pavel Zuna wrote: The patch also corrects exception handling in some of the tools. Fix #874 Pavel Updated patch attached. Forgot to rename an identifier in exception handling. Pavel This isn't

Re: [Freeipa-devel] [PATCH] 78 Use ldapi: instead of unsecured ldap: in ipa core tools.

2011-02-15 Thread Pavel Zuna
On 02/14/2011 04:56 PM, JR Aquino wrote: On 2/10/11 2:42 AM, Pavel Zunapz...@redhat.com wrote: On 02/08/2011 01:06 PM, Pavel Zuna wrote: The patch also corrects exception handling in some of the tools. Fix #874 Pavel Updated patch attached. Forgot to rename an identifier in exception

[Freeipa-devel] [PATCH] Don't load the LDAP schema during startup

2011-02-15 Thread Jan Zelený
Loading of the schema is now performed in the first request that requires it. https://fedorahosted.org/freeipa/ticket/583 Jan From 0b1368442254cb738a95e766539fa030fe2504c8 Mon Sep 17 00:00:00 2001 From: Jan Zeleny jzel...@redhat.com Date: Tue, 15 Feb 2011 09:37:58 +0100 Subject: [PATCH] Don't

Re: [Freeipa-devel] [PATCH] 42 Add group members to default output of sudorule-show

2011-02-15 Thread JR Aquino
On 2/15/11 2:06 AM, Jan Zelený jzel...@redhat.com wrote: https://fedorahosted.org/freeipa/ticket/915 Jan ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK I don't know how I missed that!

Re: [Freeipa-devel] [PATCH] Fix setattr mail bug in user plugin.

2011-02-15 Thread Martin Kosek
ACK. Martin On Tue, 2011-02-15 at 16:18 +0100, Pavel Zuna wrote: The email normalizer expects a list or tuple, but when using setattr it gets a string and interates on it as if it was a list/tuple. Before patch: [root@ipadev freeipa]# ./ipa user-mod testuser --setattr

[Freeipa-devel] [PATCH] 44 Fixes in ipa-join man page

2011-02-15 Thread Jan Zelený
https://fedorahosted.org/freeipa/ticket/784 https://fedorahosted.org/freeipa/ticket/786 https://fedorahosted.org/freeipa/ticket/787 Jan From d9fed7217b7cb599089f5d3e1d16820c080b2cd6 Mon Sep 17 00:00:00 2001 From: Jan Zeleny jzel...@redhat.com Date: Tue, 15 Feb 2011 08:22:13 -0500 Subject: [PATCH]

[Freeipa-devel] [PATCH] 2 Fix handling of /etc/hosts

2011-02-15 Thread Jan Cholasta
Fixes handling of empty lines, erroneous lines and comments in /etc/hosts. https://fedorahosted.org/freeipa/ticket/971 Honza From 1313015b03fb9174a0d911cf81bf4968cb3f693f Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 15 Feb 2011 17:51:18 +0100 Subject: [PATCH] Fix

Re: [Freeipa-devel] [PATCH] 2 Fix handling of /etc/hosts

2011-02-15 Thread Rob Crittenden
Jan Cholasta wrote: Fixes handling of empty lines, erroneous lines and comments in /etc/hosts. https://fedorahosted.org/freeipa/ticket/971 nack. Would using line.rstrip() be better than the conditional checking explicitly for \n? I don't think we can use format this way, isn't it new to

[Freeipa-devel] [PATCH] 724 remove permission as possible member of privilege

2011-02-15 Thread Rob Crittenden
A permission can't be a member of a privilege, remove the attribute from metadata. ticket 970 rob freeipa-rcrit-724-privilege.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] 725 fix service validator

2011-02-15 Thread Rob Crittenden
The kerberos service validator wasn't enforcing that the server name be not blank. ticket 961. rob freeipa-rcrit-725-service.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 2 Fix handling of /etc/hosts

2011-02-15 Thread Jan Cholasta
D'oh! Fixed. Honza Dne 15.2.2011 18:14, Rob Crittenden napsal(a): Jan Cholasta wrote: Fixes handling of empty lines, erroneous lines and comments in /etc/hosts. https://fedorahosted.org/freeipa/ticket/971 nack. Would using line.rstrip() be better than the conditional checking explicitly

Re: [Freeipa-devel] [PATCH] 031 Remove WebUI identifiers from global namespace

2011-02-15 Thread Adam Young
On 02/15/2011 08:25 AM, Martin Kosek wrote: Many WebUI identifiers were defined in a global namespace. This is not a good programming practice and may result in name clashes, for example with other libraries. This patch moves these variables to IPA namespace or its sub-namespaces, if required.

[Freeipa-devel] [PATCH] 726 require root to run ipactl

2011-02-15 Thread Rob Crittenden
Trying to run ipactl as non-root results in a slew of bogus error messages, some of which come because dirsrv can't read certain files as the wrong user, some based on our handling of that fact. ticket 936 rob freeipa-rcrit-726-ipactl.patch Description: application/mbox

Re: [Freeipa-devel] [PATCH] 724 remove permission as possible member of privilege

2011-02-15 Thread Adam Young
On 02/15/2011 12:19 PM, Rob Crittenden wrote: A permission can't be a member of a privilege, remove the attribute from metadata. ticket 970 rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 726 require root to run ipactl

2011-02-15 Thread Adam Young
On 02/15/2011 02:05 PM, Rob Crittenden wrote: Trying to run ipactl as non-root results in a slew of bogus error messages, some of which come because dirsrv can't read certain files as the wrong user, some based on our handling of that fact. ticket 936 rob

[Freeipa-devel] [PATCH] 102 Fixed association facets.

2011-02-15 Thread Endi Sukma Dewata
The association config has been removed because it incorrectly assumes there is only one association between two entities. Now each association is defined separately using association facets. The service.py has been modified to specify the correct relationships. The API.txt has been updated.

Re: [Freeipa-devel] [PATCH] Fix setattr mail bug in user plugin.

2011-02-15 Thread Adam Young
On 02/15/2011 10:56 AM, Martin Kosek wrote: ACK. Martin On Tue, 2011-02-15 at 16:18 +0100, Pavel Zuna wrote: The email normalizer expects a list or tuple, but when using setattr it gets a string and interates on it as if it was a list/tuple. Before patch: [root@ipadev freeipa]# ./ipa

Re: [Freeipa-devel] [PATCH] 42 Add group members to default output of sudorule-show

2011-02-15 Thread Adam Young
On 02/15/2011 09:51 AM, JR Aquino wrote: On 2/15/11 2:06 AM, Jan Zelenýjzel...@redhat.com wrote: https://fedorahosted.org/freeipa/ticket/915 Jan ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 725 fix service validator

2011-02-15 Thread Martin Kosek
On Tue, 2011-02-15 at 12:39 -0500, Rob Crittenden wrote: The kerberos service validator wasn't enforcing that the server name be not blank. ticket 961. rob ACK. All service tests pass. Martin ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 2 Fix handling of /etc/hosts

2011-02-15 Thread Rob Crittenden
Jan Cholasta wrote: D'oh! Fixed. Honza Dne 15.2.2011 18:14, Rob Crittenden napsal(a): Jan Cholasta wrote: Fixes handling of empty lines, erroneous lines and comments in /etc/hosts. https://fedorahosted.org/freeipa/ticket/971 nack. Would using line.rstrip() be better than the

Re: [Freeipa-devel] [PATCH] 056 Note --ip-address parameter of ipa-replica-prepare in man page

2011-02-15 Thread Rob Crittenden
Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 https://fedorahosted.org/freeipa/ticket/615 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

Re: [Freeipa-devel] [PATCH] 057 Validate MX records

2011-02-15 Thread Rob Crittenden
Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 https://fedorahosted.org/freeipa/ticket/967 I'm wondering whether to extend the patch - if the mail server name does not end with a dot, BIND treats it as relative to the zone. So if you do: ipa dnsrecord-add example.com @

Re: [Freeipa-devel] [PATCH] Code cleanup

2011-02-15 Thread Rob Crittenden
Jan Zelený wrote: Hi, I'd like to propose this cleanup patch. I just noticed that the code in these two files is most likely not used any more (at least I didn't find a place where it is used). What do you think? Is it safe to throw it out? Or are there some places which are still using it?

[Freeipa-devel] [PATCH] 727 don't allow host cn to be updated

2011-02-15 Thread Rob Crittenden
We are required by LDAP schema to have a cn value in a host record. Don't let a user modify it, it will just cause confusion. tickets 706 and 707 rob freeipa-rcrit-727-host.patch Description: application/mbox ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 44 Fixes in ipa-join man page

2011-02-15 Thread Rob Crittenden
Jan Zelený wrote: https://fedorahosted.org/freeipa/ticket/784 https://fedorahosted.org/freeipa/ticket/786 https://fedorahosted.org/freeipa/ticket/787 Jan nack, there are a couple of minor problems. - _(IPA Server to use), _(IPA Server Name) }, + _(IPA Server to use),

Re: [Freeipa-devel] [PATCH] 725 fix service validator

2011-02-15 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2011-02-15 at 12:39 -0500, Rob Crittenden wrote: The kerberos service validator wasn't enforcing that the server name be not blank. ticket 961. rob ACK. All service tests pass. Martin pushed to master ___

Re: [Freeipa-devel] [PATCH] Fix a typo in ipa-client-install man page

2011-02-15 Thread Rob Crittenden
Jan Zelený wrote: https://fedorahosted.org/freeipa/ticket/782 Jan ack, pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 17 Managed netgroups should be invisible

2011-02-15 Thread JR Aquino
This patch provides ipa netgroup-find a default filter which prevents the displaying of mepManageEntry Netgroups by default. It also introduces a —private flag similar to the group.py to allow for displaying them if necessary. freeipa-jraquino-0017-Managed-netgroups-should-be-invisible.patch

Re: [Freeipa-devel] [PATCH] 102 Fixed association facets.

2011-02-15 Thread Endi Sukma Dewata
On 2/15/2011 1:39 PM, Endi Sukma Dewata wrote: The association config has been removed because it incorrectly assumes there is only one association between two entities. Now each association is defined separately using association facets. The service.py has been modified to specify the correct

[Freeipa-devel] [PATCH] temp fix for init script on f15

2011-02-15 Thread Simo Sorce
This fixes a hangup issue when a init script calls another within systemctl, by preventing calling systemctl on initscripts. Will need to work with fedora folks to find an appropriate long term solution, but this will make things work for now. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [Freeipa-devel] [PATCH] 102 Fixed association facets.

2011-02-15 Thread Adam Young
On 02/15/2011 04:23 PM, Endi Sukma Dewata wrote: On 2/15/2011 1:39 PM, Endi Sukma Dewata wrote: The association config has been removed because it incorrectly assumes there is only one association between two entities. Now each association is defined separately using association facets. The

Re: [Freeipa-devel] [PATCH] temp fix for init script on f15

2011-02-15 Thread Rob Crittenden
Simo Sorce wrote: This fixes a hangup issue when a init script calls another within systemctl, by preventing calling systemctl on initscripts. Will need to work with fedora folks to find an appropriate long term solution, but this will make things work for now. Simo. ack, tested on F-14 and

Re: [Freeipa-devel] [PATCH] 44 Fixes in ipa-join man page

2011-02-15 Thread David O'Brien
Jan Zelený wrote: https://fedorahosted.org/freeipa/ticket/784 https://fedorahosted.org/freeipa/ticket/786 https://fedorahosted.org/freeipa/ticket/787 Jan nack A few typos and style issues: - _(File were to store the keytab information), _(Keytab File Name) }, + _(File were to store the

Re: [Freeipa-devel] [PATCH] 44 Fixes in ipa-join man page

2011-02-15 Thread Jan Zelený
David O'Brien dav...@redhat.com wrote: Jan Zelený wrote: https://fedorahosted.org/freeipa/ticket/784 https://fedorahosted.org/freeipa/ticket/786 https://fedorahosted.org/freeipa/ticket/787 Jan nack A few typos and style issues: - _(File were to store the keytab information),

Re: [Freeipa-devel] [PATCH] Updated default Kerberos password policy

2011-02-15 Thread Jan Zelený
Jan Zeleny jzel...@redhat.com wrote: Rob Crittenden rcrit...@redhat.com wrote: Jan Zelený wrote: https://fedorahosted.org/freeipa/ticket/930 I put there a value Dmitri suggested. Feel free to change it before pushing if you think there should be the originally suggested 10 login