Re: [Freeipa-devel] [PATCH] 761 Sort entries on *-find commands

2011-04-13 Thread Martin Kosek
On Tue, 2011-04-12 at 16:56 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-03-30 at 17:14 -0400, Rob Crittenden wrote: Sort output on find commands based on the baseldap LDAPSearch class. A couple tests had to be modified to match the new order. ticket 794 rob

Re: [Freeipa-devel] [PATCH] 9 Fix unitialized variables

2011-04-13 Thread Martin Kosek
On Mon, 2011-04-11 at 14:44 +0200, Jan Cholasta wrote: Fixed unitialized variables in makeapi validate_api. ACK. Pushed to master, ipa-2-0. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 10 Fix double definition

2011-04-13 Thread Martin Kosek
On Mon, 2011-04-11 at 14:48 +0200, Jan Cholasta wrote: Fixed double definition of Command.output_for_cli. ACK. Pushed to master, ipa-2-0. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 11 Fix unitialized attributes

2011-04-13 Thread Martin Kosek
On Mon, 2011-04-11 at 15:07 +0200, Jan Cholasta wrote: Fixed unitialized attributes in ipalib.aci.ACI, ipalib.parameters.Data, ipalib.text.LazyText, ipaserver.install.service.Service and ipaserver.rpcserver.WSGIExecutioner. NACK. This patch breaks the build. $ make rpms [snip] if [ !=

Re: [Freeipa-devel] [PATCH] 3 Add ability to specify netmask with IP addresses during installation

2011-04-13 Thread Jan Cholasta
On 11.4.2011 12:48, Jan Cholasta wrote: On 8.4.2011 16:26, Rob Crittenden wrote: Jan Cholasta wrote: On 29.3.2011 22:15, Rob Crittenden wrote: Jan Cholasta wrote: Sorry, forgot to attach the patch. Is this why you have some blind excepts?

Re: [Freeipa-devel] [PATCH] 11 Fix unitialized attributes

2011-04-13 Thread Jan Cholasta
On 13.4.2011 13:04, Martin Kosek wrote: On Mon, 2011-04-11 at 15:07 +0200, Jan Cholasta wrote: Fixed unitialized attributes in ipalib.aci.ACI, ipalib.parameters.Data, ipalib.text.LazyText, ipaserver.install.service.Service and ipaserver.rpcserver.WSGIExecutioner. NACK. This patch breaks the

Re: [Freeipa-devel] [PATCH] 6 Add lint script for static code analysis

2011-04-13 Thread Martin Kosek
On Mon, 2011-04-11 at 15:44 +0200, Jan Cholasta wrote: On 7.4.2011 17:00, Jan Cholasta wrote: This patch adds a script based on pylint for static code analysis during build. https://fedorahosted.org/freeipa/ticket/867 ___ Freeipa-devel

Re: [Freeipa-devel] [PATCH] 137 Entitlement registration.

2011-04-13 Thread Adam Young
On 04/12/2011 03:06 PM, Endi Sukma Dewata wrote: The entitlement facet will show the appropriate buttons depending on the entitlement status. If it's not registered, the facet will show a Register button. If it's registered, the facet will show a Consume button.

Re: [Freeipa-devel] [PATCH] Fix lint false positives

2011-04-13 Thread Martin Kosek
On Mon, 2011-04-11 at 13:38 +0200, Martin Kosek wrote: On Thu, 2011-04-07 at 17:03 +0200, Jan Cholasta wrote: Added changes to the code necesarry for removal of false positives reported by the lint script (see my previous patch). ACK. Along with the previous patch suppressing false

Re: [Freeipa-devel] [PATCH] 136 Merged IPA.cmd() into IPA.command().

2011-04-13 Thread Adam Young
On 04/12/2011 12:09 PM, Endi Sukma Dewata wrote: The IPA.cmd() has been merged into IPA.command(). All invocations and test cases have been converted. Ticket #988 Passed JSLint, QUnit and Selenium tests. ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 761 Sort entries on *-find commands

2011-04-13 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2011-04-12 at 16:56 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-03-30 at 17:14 -0400, Rob Crittenden wrote: Sort output on find commands based on the baseldap LDAPSearch class. A couple tests had to be modified to match the new order. ticket 794

Re: [Freeipa-devel] [PATCH] 137 Entitlement registration.

2011-04-13 Thread Endi Sukma Dewata
On 4/13/2011 9:12 AM, Adam Young wrote: Please make sure all String literals come from the interal.py messages plugin. New button labels are defined in entitle.js for Consume and Register. I'm thinking to do that once we have all the entitlement functionalities implemented. There are also

Re: [Freeipa-devel] [PATCH] 137 Entitlement registration.

2011-04-13 Thread Adam Young
On 04/13/2011 11:03 AM, Endi Sukma Dewata wrote: On 4/13/2011 9:12 AM, Adam Young wrote: Please make sure all String literals come from the interal.py messages plugin. New button labels are defined in entitle.js for Consume and Register. I'm thinking to do that once we have all the

[Freeipa-devel] About FreeIPA Blurb

2011-04-13 Thread Adam Young
The FreeIPA.org Landing page needs a better description of the project. Can anyone suggest a One-Three line description that orients people to FreeIPA, assuming they know little/nothing about the project? Exl;ainig that it integrates Kerbers an LDAp is the second step, but it really is an

Re: [Freeipa-devel] [PATCH] 137 Entitlement registration.

2011-04-13 Thread Endi Sukma Dewata
On 4/13/2011 10:13 AM, Adam Young wrote: There's no pattern defined in the metadata for the quantity. There is an 'int' type though. I think we can add a general purpose type checking in addition to pattern validation. This can be done in a separate patch. We can add a validation rule

Re: [Freeipa-devel] [PATCH] 761 Sort entries on *-find commands

2011-04-13 Thread Martin Kosek
On Wed, 2011-04-13 at 10:49 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2011-04-12 at 16:56 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-03-30 at 17:14 -0400, Rob Crittenden wrote: Sort output on find commands based on the baseldap LDAPSearch class. A

Re: [Freeipa-devel] [PATCH] 137 Entitlement registration.

2011-04-13 Thread Adam Young
On 04/13/2011 11:30 AM, Endi Sukma Dewata wrote: On 4/13/2011 10:13 AM, Adam Young wrote: There's no pattern defined in the metadata for the quantity. There is an 'int' type though. I think we can add a general purpose type checking in addition to pattern validation. This can be done in a

[Freeipa-devel] [PATCH] 771 include rights for all aci components in permission_show

2011-04-13 Thread Rob Crittenden
Provide attributelevelrights for the aci components in permission_show. Since the broken-out components are just part of the aci just copy right access rights for aci. ticket 943 rob From 7289204b5b3394e41ddbf4351c372740c6d483b1 Mon Sep 17 00:00:00 2001 From: Rob Crittenden

Re: [Freeipa-devel] About FreeIPA Blurb

2011-04-13 Thread Dmitri Pal
On 04/13/2011 04:23 PM, JR Aquino wrote: On Apr 13, 2011, at 1:00 PM, Dmitri Pal wrote: On 04/13/2011 11:34 AM, Adam Young wrote: The FreeIPA.org Landing page needs a better description of the project. Can anyone suggest a One-Three line description that orients people to FreeIPA, assuming

Re: [Freeipa-devel] About FreeIPA Blurb

2011-04-13 Thread Adam Young
On 04/13/2011 04:26 PM, Dmitri Pal wrote: On 04/13/2011 04:23 PM, JR Aquino wrote: On Apr 13, 2011, at 1:00 PM, Dmitri Pal wrote: On 04/13/2011 11:34 AM, Adam Young wrote: The FreeIPA.org Landing page needs a better description of the project. Can anyone suggest a One-Three line description

[Freeipa-devel] [PATCH] 772 prompt for reverse members

2011-04-13 Thread Rob Crittenden
Always ask members in LDAP*ReverseMember commands. This changes the API but alwaysask is enforced on the client only so doesn't change the wire API so I'm not updating the API version. ticket 1081 rob freeipa-rcrit-772-reverse.patch Description: application/mbox

Re: [Freeipa-devel] About FreeIPA Blurb

2011-04-13 Thread Dmitri Pal
On 04/13/2011 05:05 PM, Adam Young wrote: On 04/13/2011 04:26 PM, Dmitri Pal wrote: On 04/13/2011 04:23 PM, JR Aquino wrote: On Apr 13, 2011, at 1:00 PM, Dmitri Pal wrote: On 04/13/2011 11:34 AM, Adam Young wrote: The FreeIPA.org Landing page needs a better description of the project. Can

Re: [Freeipa-devel] About FreeIPA Blurb

2011-04-13 Thread Simo Sorce
On Wed, 13 Apr 2011 17:05:02 -0400 Adam Young ayo...@redhat.com wrote: FreeIPA is a centralized authentication and authorization management framework, built on open standards, with a focus towards the needs of Linux and Unix clients. I'd like to ack, but when I see framework I think of

Re: [Freeipa-devel] About FreeIPA Blurb

2011-04-13 Thread JR Aquino
On Apr 13, 2011, at 6:15 PM, Simo Sorce wrote: On Wed, 13 Apr 2011 17:05:02 -0400 Adam Young ayo...@redhat.com wrote: FreeIPA is a centralized authentication and authorization management framework, built on open standards, with a focus towards the needs of Linux and Unix clients.

Re: [Freeipa-devel] About FreeIPA Blurb

2011-04-13 Thread Adam Young
On 04/13/2011 09:26 PM, Adam Young wrote: On 04/13/2011 09:15 PM, Simo Sorce wrote: On Wed, 13 Apr 2011 17:05:02 -0400 Adam Youngayo...@redhat.com wrote: FreeIPA is a centralized authentication and authorization management framework, built on open standards, with a focus towards the needs of

Re: [Freeipa-devel] About FreeIPA Blurb

2011-04-13 Thread JR Aquino
On Apr 13, 2011, at 6:40 PM, Adam Young wrote: On 04/13/2011 09:26 PM, Adam Young wrote: On 04/13/2011 09:15 PM, Simo Sorce wrote: On Wed, 13 Apr 2011 17:05:02 -0400 Adam Youngayo...@redhat.com wrote: FreeIPA is a centralized authentication and authorization management framework, built

Re: [Freeipa-devel] [PATCH] 136 Merged IPA.cmd() into IPA.command().

2011-04-13 Thread Adam Young
On 04/13/2011 04:57 PM, Endi Sukma Dewata wrote: On 4/13/2011 9:19 AM, Adam Young wrote: I'm not a fan of the string concatination in the command calls. I'd prefer to do that inside the IPA.command object, the way it was done in IPA.cmd: { entity:cert method:revoke: ... } and if

Re: [Freeipa-devel] [PATCH] 137 Entitlement registration.

2011-04-13 Thread Adam Young
On 04/13/2011 11:30 AM, Endi Sukma Dewata wrote: On 4/13/2011 10:13 AM, Adam Young wrote: There's no pattern defined in the metadata for the quantity. There is an 'int' type though. I think we can add a general purpose type checking in addition to pattern validation. This can be done in a

Re: [Freeipa-devel] [PATCH] 137 Entitlement registration.

2011-04-13 Thread Endi Sukma Dewata
On 4/13/2011 10:33 PM, Adam Young wrote: BTW, are you planning on updating this patch, or do the validation work in a follow on patch? Attached is an updated version. There are a few more patches in the pipeline. After that I'll address the I18n labels, integer validation and builder