Re: [Freeipa-devel] [PATCH] 837 autofill default revocation reason

2011-07-22 Thread Martin Kosek
On Thu, 2011-07-21 at 16:52 -0400, Rob Crittenden wrote: The default revocation reason wasn't autofilling so trying to retrieve it when it wasn't set caused things to blow up. ticket https://fedorahosted.org/freeipa/ticket/1514 ACK, works as advertised. Pushed to master, ipa-2-0. Martin

Re: [Freeipa-devel] [PATCH] 836 Don't check for leading/trailing spaces on cert

2011-07-22 Thread Martin Kosek
On Thu, 2011-07-21 at 16:50 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Don't check for leading/trailing spaces when loading an entitlement cert ticket https://fedorahosted.org/freeipa/ticket/1505 With API.txt update, doesn't affect wire protocol. NACK. 1) I think we should

Re: [Freeipa-devel] [PATCH] 33 Fix ipa-compat-manage

2011-07-22 Thread Martin Kosek
On Fri, 2011-07-22 at 10:27 +0200, Jan Cholasta wrote: On 21.7.2011 18:52, Martin Kosek wrote: On Thu, 2011-07-21 at 16:54 +0200, Jan Cholasta wrote: Make ipa-compat-manage work again after the changes to ipa-nis-manage I've done in patch 32. (this also fixes

[Freeipa-devel] [WIP] Add command to test HBAC rules

2011-07-22 Thread Alexander Bokovoy
Hi, attached please find a first cut of an HBAC tester command to CLI, FreeIPA ticket https://fedorahosted.org/freeipa/ticket/386 The idea behind this plugin is to re-use pyhbac module provided by SSSD project which is Python bindings for SSSD's libipa_hbac code used for actual HBAC rule

[Freeipa-devel] [PATCH] 838 pull in arch-specific cyrus-sasl-gssapi

2011-07-22 Thread Rob Crittenden
We need a specific requires on the arch-specific cyrus-sasl-gssapi. This was discovered by a user that had the 32-bit client package installed on a 64-bit server. The GSSAPI SASL mechanism wasn't available because he had only the 64-bit cyrus-sasl-gssapi library installed. This adds a more

Re: [Freeipa-devel] [WIP] Add command to test HBAC rules

2011-07-22 Thread Alexander Bokovoy
Now real patch: adds command, updates API.txt and VERSION files, along with freeipa.spec. On 22.07.2011 12:32, Alexander Bokovoy wrote: Hi, attached please find a first cut of an HBAC tester command to CLI, FreeIPA ticket https://fedorahosted.org/freeipa/ticket/386 The idea behind this

Re: [Freeipa-devel] [PATCH] 38 Move Managed Entries into their own container in the replicated space.

2011-07-22 Thread Martin Kosek
On Thu, 2011-07-21 at 23:00 +, JR Aquino wrote: Create: cn=Managed Entries,cn=etc,$SUFFIX Create: cn=Definitions,cn=Managed Entries,cn=etc,$SUFFIX Create: cn=Templates,cn=Managed Entries,cn=etc,$SUFFIX Create method for migrating any and all custom Managed Entries from the cn=config

Re: [Freeipa-devel] [PATCH] 25 Create Tool for Enabling Disabling Managed Entry

2011-07-22 Thread Martin Kosek
On Thu, 2011-07-21 at 23:52 +, JR Aquino wrote: On Apr 25, 2011, at 9:00 AM, Simo Sorce wrote: On Mon, 2011-04-25 at 14:59 +, JR Aquino wrote: On Apr 25, 2011, at 6:43 AM, Simo Sorce wrote: On Thu, 2011-04-21 at 23:28 +, JR Aquino wrote: Hmmm Both Private Groups and the

Re: [Freeipa-devel] [PATCH] 25 Create Tool for Enabling Disabling Managed Entry

2011-07-22 Thread Rob Crittenden
Martin Kosek wrote: On Thu, 2011-07-21 at 23:52 +, JR Aquino wrote: On Apr 25, 2011, at 9:00 AM, Simo Sorce wrote: On Mon, 2011-04-25 at 14:59 +, JR Aquino wrote: On Apr 25, 2011, at 6:43 AM, Simo Sorce wrote: On Thu, 2011-04-21 at 23:28 +, JR Aquino wrote: Hmmm Both Private

Re: [Freeipa-devel] [PATCH] 836 Don't check for leading/trailing spaces on cert

2011-07-22 Thread Rob Crittenden
Martin Kosek wrote: On Thu, 2011-07-21 at 16:50 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Don't check for leading/trailing spaces when loading an entitlement cert ticket https://fedorahosted.org/freeipa/ticket/1505 With API.txt update, doesn't affect wire protocol. NACK. 1) I

Re: [Freeipa-devel] [PATCH] 38 Move Managed Entries into their own container in the replicated space.

2011-07-22 Thread JR Aquino
On Jul 22, 2011, at 6:54 AM, Martin Kosek wrote: On Thu, 2011-07-21 at 23:00 +, JR Aquino wrote: Create: cn=Managed Entries,cn=etc,$SUFFIX Create: cn=Definitions,cn=Managed Entries,cn=etc,$SUFFIX Create: cn=Templates,cn=Managed Entries,cn=etc,$SUFFIX Create method for migrating any and

[Freeipa-devel] [PATCH] 217 Refactored IPA.current_facet().

2011-07-22 Thread Endi Sukma Dewata
The IPA.current_facet() has been merged into IPA.entity.setup() and replaced by IPA.entity.get_facet(). The setup() will read the current facet's name from the entity-facet URL parameter and store the facet object in the entity object. The get_facet() without any parameter will return the current

Re: [Freeipa-devel] [PATCH] 217 Refactored IPA.current_facet().

2011-07-22 Thread Adam Young
On 07/22/2011 12:00 PM, Endi Sukma Dewata wrote: The IPA.current_facet() has been merged into IPA.entity.setup() and replaced by IPA.entity.get_facet(). The setup() will read the current facet's name from the entity-facet URL parameter and store the facet object in the entity object. The

[Freeipa-devel] [PATCH] 218 Fixed problem with navigation state loading.

2011-07-22 Thread Endi Sukma Dewata
The select event handler in the navigation tab has been modified to distinguish the source of the event. If the event is triggered by URL hash change, it will use the state specified in the URL. If the event is triggered by a mouse click, it will use the state stored internally. -- Endi S.

Re: [Freeipa-devel] [PATCH] 218 Fixed problem with navigation state loading.

2011-07-22 Thread Adam Young
On 07/22/2011 12:16 PM, Endi Sukma Dewata wrote: The select event handler in the navigation tab has been modified to distinguish the source of the event. If the event is triggered by URL hash change, it will use the state specified in the URL. If the event is triggered by a mouse click, it will

Re: [Freeipa-devel] [PATCH] 219 Fixed navigation problems.

2011-07-22 Thread Adam Young
On 07/22/2011 12:17 PM, Endi Sukma Dewata wrote: The navigation code has been modified store the facet's state separately in the facet object itself. The path state is stored in the navigation object. When the path is changed to view a new facet, only the path and the state of the new facet will

[Freeipa-devel] [PATCH] 220 Fixed navigation unit test.

2011-07-22 Thread Endi Sukma Dewata
The mock-up get_state() has been modified to return an empty object if it's called without parameter. It's the same as $bbq.getState(). Pushed under one-liner/trivial rule. -- Endi S. Dewata From 489f99000e23e3566ab4e1e6a2b6dca6402a3c46 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata

[Freeipa-devel] [PATCH] 0274-move-dns-to-identity-tab

2011-07-22 Thread Adam Young
It makes a lot more sense here. From 2bfd11641b7023442c158f4400efc9a74a49a815 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Fri, 22 Jul 2011 15:39:16 -0400 Subject: [PATCH] move dns to identity tab --- install/ui/webui.js |7 --- 1 files changed, 4 insertions(+), 3

Re: [Freeipa-devel] [WIP] Add command to test HBAC rules

2011-07-22 Thread Rob Crittenden
Alexander Bokovoy wrote: Now real patch: adds command, updates API.txt and VERSION files, along with freeipa.spec. On 22.07.2011 12:32, Alexander Bokovoy wrote: Hi, attached please find a first cut of an HBAC tester command to CLI, FreeIPA ticket https://fedorahosted.org/freeipa/ticket/386

[Freeipa-devel] [PATCH] 221 Fixed click handlers on certificate buttons.

2011-07-22 Thread Endi Sukma Dewata
The click event handlers for certificate buttons have been fixed to stop standard event processing which causes the page to change. -- Endi S. Dewata From eb263c323a61e3d197c86585643e7dab351b1f4a Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Fri, 22 Jul 2011 14:32:33

Re: [Freeipa-devel] [WIP] Add command to test HBAC rules

2011-07-22 Thread Alexander Bokovoy
On 22.07.2011 22:47, Rob Crittenden wrote: Alexander Bokovoy wrote: Now real patch: adds command, updates API.txt and VERSION files, along with freeipa.spec. On 22.07.2011 12:32, Alexander Bokovoy wrote: Hi, attached please find a first cut of an HBAC tester command to CLI, FreeIPA

[Freeipa-devel] [PATCH] 0275-remove-hardcoded-DNS-label-for-record-name

2011-07-22 Thread Adam Young
Pushed under the one line rule. From 4ae7edebafbfc551ddaf036b6860781182867c47 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Fri, 22 Jul 2011 16:25:11 -0400 Subject: [PATCH] remove hardcoded DNS label for record name. https://fedorahosted.org/freeipa/ticket/1493 ---

Re: [Freeipa-devel] [PATCH] 0274-move-dns-to-identity-tab

2011-07-22 Thread Endi Sukma Dewata
On 7/22/2011 2:39 PM, Adam Young wrote: It makes a lot more sense here. ACK, but there's a jslint warning. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0274-move-dns-to-identity-tab

2011-07-22 Thread Adam Young
On 07/22/2011 04:26 PM, Endi Sukma Dewata wrote: On 7/22/2011 2:39 PM, Adam Young wrote: It makes a lot more sense here. ACK, but there's a jslint warning. Fixed and pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH ]0276-dns-section-header-i18n

2011-07-22 Thread Adam Young
From 46f5a5b95139d2ba13a370a7266ad0bc664c3dfa Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Fri, 22 Jul 2011 17:35:06 -0400 Subject: [PATCH] dns section header i18n. https://fedorahosted.org/freeipa/ticket/1493 --- install/ui/dns.js |4 +-

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-22 Thread Endi Sukma Dewata
On 7/22/2011 12:18 PM, Endi Sukma Dewata wrote: On 7/22/2011 10:34 AM, Adam Young wrote: While this version has a Navigation fix in it, it is going to be rebased on top of Endi Dewata's patch for putting the state inside each of the facets. Rebased. I'll continue the review. Some issues: