Re: [Freeipa-devel] [PATCH] 55 Parse comma-separated lists of values in all parameter types

2011-11-07 Thread Jan Cholasta
Dne 4.11.2011 22:25, Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 24.10.2011 17:42, Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 20.10.2011 13:20, Jan Cholasta napsal(a): Parse comma-separated lists of values in all parameter types. This can enabled for a specific parameter by

Re: [Freeipa-devel] [PATCH] 308 Added current password field.

2011-11-07 Thread Petr Vobornik
On 11/04/2011 11:29 PM, Endi Sukma Dewata wrote: The reset password dialog for user has been modified to provide a field to specify the current password when changing the user's own password. Ticket #2065 ACK ipa-2-1, master -- Petr Vobornik ___

Re: [Freeipa-devel] [PATCH] 308 Added current password field.

2011-11-07 Thread Martin Kosek
On Mon, 2011-11-07 at 13:48 +0100, Petr Vobornik wrote: On 11/04/2011 11:29 PM, Endi Sukma Dewata wrote: The reset password dialog for user has been modified to provide a field to specify the current password when changing the user's own password. Ticket #2065 ACK ipa-2-1, master

Re: [Freeipa-devel] [PATCH] 029 Page is cleared before it is visible

2011-11-07 Thread Petr Vobornik
On 11/05/2011 01:37 AM, Endi Sukma Dewata wrote: On 11/4/2011 11:02 AM, Petr Vobornik wrote: Found another problem, changing page in the association facet didn't work because pkey is still the same. See the attached patch. ACK and pushed to master -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 030 Extending facet's mechanism of gathering changes

2011-11-07 Thread Petr Vobornik
On 11/04/2011 06:22 PM, Endi Sukma Dewata wrote: Rebased, ACK, and pushed to master. Some comments below. On 11/4/2011 7:21 AM, Petr Vobornik wrote: Perhaps the save_as_update_info() later can be merged with get_update_info() too because both are essentially generating update_info for dirty

[Freeipa-devel] [PATCH] 160 Hosts file not updated when IP is passed as option

2011-11-07 Thread Martin Kosek
When an IPA server with unresolvable hostname is being installed, a hostname record must be inserted to /etc/hosts or the installation will fail. However, it is not inserted when IP address is passed as an option (--ip-address) and not interactively. This patch fixes this so that /etc/hosts record

Re: [Freeipa-devel] [PATCHES] #2036 Fix coverity bugs

2011-11-07 Thread Alexander Bokovoy
On Thu, 03 Nov 2011, Simo Sorce wrote: Just some unchecked returns, we do not care much, but will keep Coverity happy. ACK to all below, they seem to be straight-forward. As slapi_ch_free_string() accepts a pointer to NULL and does nothing in that case, you don't need to protect against

Re: [Freeipa-devel] [PATCHES] #2037 Coverity issues

2011-11-07 Thread Alexander Bokovoy
On Thu, 03 Nov 2011, Simo Sorce wrote: These are actual issues. Most are resource leaks. And one is a bad sizeof() computation that will cause us later to overwrite out of bound memory, so potentially a segfault. Went through all of these. ACK. https://fedorahosted.org/freeipa/ticket/2037

Re: [Freeipa-devel] [PATCHES] #2036 Fix coverity bugs

2011-11-07 Thread Simo Sorce
On Mon, 2011-11-07 at 22:42 +0200, Alexander Bokovoy wrote: ACK to all below, they seem to be straight-forward. Thanks, pushed to master. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCHES] #2037 Coverity issues

2011-11-07 Thread Simo Sorce
On Tue, 2011-11-08 at 00:22 +0200, Alexander Bokovoy wrote: Went through all of these. ACK. Thanks again, pushed to master. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCHES] #1791 Tust Effort: Add support for generating MS-PAC

2011-11-07 Thread Simo Sorce
On Fri, 2011-11-04 at 23:31 +0100, Sumit Bose wrote: On Fri, Nov 04, 2011 at 10:49:40AM -0400, Simo Sorce wrote: The attached patches are for master and concern the effort of creating trust relationships between IPA and AD domains. With these patches if you have run ipa-adtrust-install

[Freeipa-devel] LDAPS for the IPA LDAP server?

2011-11-07 Thread Adam Young
I noticed that the PKI Directory server has a secure port set but the IPA DS instance does not: PKI nsslapd-secureport: 7390 Why doesn IPA set up ldapson port 636? ___ Freeipa-devel mailing list Freeipa-devel@redhat.com