Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Jan Cholasta
On 29.2.2012 15:50, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 16 defers validation conversion until after {add,del,set}attr is processed, so that we don't search for an integer in a list of strings (this caused ticket

[Freeipa-devel] [PATCH] 239 Tolerate UDP port failures in conncheck

2012-03-16 Thread Martin Kosek
UDP port checks in ipa-replica-conncheck are too strict. The entire conncheck fails when UDP ports cannot be verified as open. However, UDP protocol is unrealiable by its nature and the port can also not be checked if there is an application already bound to it. This can happen for example when

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-03-16 Thread Petr Viktorin
On 03/15/2012 08:55 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2227 (Unable to add certain sudo commands to groups). What an interesting bug to get :) One problem with our CSV splitting is that it's not idempotent (baskslashes are eaten when there

Re: [Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-16 Thread Petr Viktorin
On 03/13/2012 12:23 PM, Petr Viktorin wrote: On 03/12/2012 09:18 PM, Rob Crittenden wrote: Petr Viktorin wrote: Most of the tests we have check if the server does the right thing with XML-RPC calls. How the commandline is converted to command arguments, including interactive prompting, is

Re: [Freeipa-devel] [PATCH] 987 Don't allow IPA master hosts and services to be disabled

2012-03-16 Thread Petr Viktorin
On 03/15/2012 10:04 PM, Rob Crittenden wrote: diff --git a/ipalib/plugins/baseldap.py b/ipalib/plugins/baseldap.py index 9562ff98729ead6ac9e56d504f6ee0a7c0ca377a..f3c89a0fc5e3f00ed7f132dbff2510d89bc7370d 100644 --- a/ipalib/plugins/baseldap.py +++ b/ipalib/plugins/baseldap.py @@ -887,12

Re: [Freeipa-devel] [PATCH] 986 remove unnecessary serial conversions

2012-03-16 Thread Petr Viktorin
On 03/15/2012 06:31 PM, Rob Crittenden wrote: This is related to my patch 924. Petr Viktorin noticed a couple of serial to hex conversions were wrong and it turns out they aren't needed at all. This patch removes them. rob On 03/15/2012 06:32 PM, Rob Crittenden wrote: Petr Viktorin wrote:

Re: [Freeipa-devel] [PATCH] 0024 Fix expected exception checking in tests

2012-03-16 Thread Petr Viktorin
On 03/15/2012 10:36 PM, Rob Crittenden wrote: Petr Viktorin wrote: Can you spot the bug in this test code? try: do_invalid_operation() except ExpectedError: pass Our test suite had several of those. Nose provides nice tools, `raises` (a decorator) and `assert_raises` (a context manager) that

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Rob Crittenden
Jan Cholasta wrote: On 29.2.2012 15:50, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 16 defers validation conversion until after {add,del,set}attr is processed, so that we don't search for an integer in a list of strings

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Petr Viktorin
I may be taking things out of context, but I see this: On 03/16/2012 02:07 PM, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:50, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: .. snip .. Patch 17 makes these options honor params marked

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Jan Cholasta
On 16.3.2012 14:14, Petr Viktorin wrote: I may be taking things out of context, but I see this: On 03/16/2012 02:07 PM, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:50, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: .. snip .. Patch

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Rob Crittenden
Petr Viktorin wrote: I may be taking things out of context, but I see this: On 03/16/2012 02:07 PM, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:50, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: .. snip .. Patch 17 makes these

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Petr Viktorin
On 03/16/2012 02:34 PM, Rob Crittenden wrote: Petr Viktorin wrote: I may be taking things out of context, but I see this: On 03/16/2012 02:07 PM, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:50, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden

Re: [Freeipa-devel] [PATCH] 0016 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Petr Viktorin
On 03/15/2012 09:24 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/29/2012 04:34 PM, Petr Viktorin wrote: On 02/29/2012 03:50 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 16 defers validation conversion until

Re: [Freeipa-devel] [PATCH] 107 Content is no more overwritten by error message

2012-03-16 Thread Petr Vobornik
On 03/13/2012 10:54 PM, Endi Sukma Dewata wrote: On 3/9/2012 7:16 AM, Petr Vobornik wrote: When an error which caused calling of report_error occur, the content of a facet got replaced by error message. There was no way how to force the facet to recreate its content and the facet became

Re: [Freeipa-devel] [PATCH] 0016 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Rob Crittenden
Petr Viktorin wrote: On 03/15/2012 09:24 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/29/2012 04:34 PM, Petr Viktorin wrote: On 02/29/2012 03:50 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 16 defers

Re: [Freeipa-devel] [PATCH] 0016 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Rob Crittenden
Rob Crittenden wrote: Petr Viktorin wrote: On 03/15/2012 09:24 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/29/2012 04:34 PM, Petr Viktorin wrote: On 02/29/2012 03:50 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: Petr Viktorin wrote:

Re: [Freeipa-devel] [PATCH] 0016 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Petr Viktorin
On 03/16/2012 06:33 PM, Rob Crittenden wrote: Rob Crittenden wrote: Petr Viktorin wrote: On 03/15/2012 09:24 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/29/2012 04:34 PM, Petr Viktorin wrote: On 02/29/2012 03:50 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03

Re: [Freeipa-devel] [PATCH] 0016 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Petr Viktorin
On 03/16/2012 06:35 PM, Petr Viktorin wrote: On 03/16/2012 06:33 PM, Rob Crittenden wrote: Rob Crittenden wrote: Petr Viktorin wrote: On 03/15/2012 09:24 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/29/2012 04:34 PM, Petr Viktorin wrote: On 02/29/2012 03:50 PM, Rob Crittenden

[Freeipa-devel] [PATCH] 989 import plugins on context, not in_server

2012-03-16 Thread Rob Crittenden
in_server controls how messages are dispatched. We should import on context. This prevents the error message session memcached servers not running in ipa-ldap-updater and ipa-replica-manage. rob From be57f22856bfe95e0bd19d8b41f19dfd83153384 Mon Sep 17 00:00:00 2001 From: Rob Crittenden

[Freeipa-devel] [PATCH] 990 attribute name in exceptions

2012-03-16 Thread Rob Crittenden
When using *attr we should return the param.name of in the exception and when using a cli option we should return param.cli_name. This didn't work consistently in the framework. This is a bit of a kludge, catching exceptions and re-raising them, but it is a less invasive way of doing it. I

[Freeipa-devel] [PATCH] 349 Fixed boot.ldif permission.

2012-03-16 Thread Endi Sukma Dewata
The server installation failed on F17 due to permission problem. The /var/lib/dirsrv/boot.ldif was previously owned and only readable by root. It is now owned by DS user dirsrv. Ticket #2544 -- Endi S. Dewata From 0a9b9c026938a2879cd3d9ed54a14b1afc96f1f0 Mon Sep 17 00:00:00 2001 From: Endi