Re: [Freeipa-devel] [PATCH] 993 disable UPG for migration

2012-03-29 Thread Martin Kosek
On Wed, 2012-03-28 at 17:28 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Thu, 2012-03-22 at 15:21 -0400, Rob Crittenden wrote: We don't want to create private groups automatically for migrated users, there could be namespace overlap (and race conditions prevent us from trying to

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-03-29 Thread Petr Viktorin
On 03/29/2012 12:20 AM, Rob Crittenden wrote: I'm using a much narrower scope. I'm not trying to make it easy to manage non-printable characters, just not blow things up if they exist. Limiting to the XML-RPC supported set is for convenience, these are unprintable characters in any context.

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-03-29 Thread Jan Cholasta
On 29.3.2012 00:20, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:45, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:58, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:02, Petr Viktorin wrote: On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr Viktorin

Re: [Freeipa-devel] [PATCHES] 113-114 Facet expiration flag

2012-03-29 Thread Petr Vobornik
On 03/27/2012 05:36 PM, Endi Sukma Dewata wrote: On 3/22/2012 12:50 PM, Petr Vobornik wrote: The effort was split to two patches. See patch descriptions. ACK on both. Nice job. See comments below. Pushed to master, ipa-2-2. See comment below. Notes: Case #7 (automatic: an open facet

[Freeipa-devel] [PATCH] 115 Reworked netgroup Web UI to allow setting user/host category

2012-03-29 Thread Petr Vobornik
This patch is changing netgroup web ui to look more like hbac or sudo rule UI. This change allows to define and display user category, host category and external host. The core of the change is changing member attributes (user, group, host, hostgroup) to use rule_details_widget instead of

[Freeipa-devel] [PATCH] (master) Support case-insensitive searches for principals during TGS request processing

2012-03-29 Thread Alexander Bokovoy
Hi, Attached patch implements solution for https://fedorahosted.org/freeipa/ticket/1577. With the patch applied to master, FreeIPA will be more forgiving for service principals requested with wrong character case. This is something supported by Active Directory where principals for services

Re: [Freeipa-devel] [PATCH] 0030 Allow multi-line CSV parameters

2012-03-29 Thread Ondrej Hamada
On 03/22/2012 09:40 AM, Petr Viktorin wrote: Feed individual lines of input into the CSV parser, and include all lines in the output. https://fedorahosted.org/freeipa/ticket/2402 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-03-29 Thread Petr Vobornik
On 03/29/2012 12:20 AM, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:45, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:58, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:02, Petr Viktorin wrote: On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr

Re: [Freeipa-devel] [PATCH] 993 disable UPG for migration

2012-03-29 Thread Simo Sorce
On Thu, 2012-03-29 at 11:27 -0400, Rob Crittenden wrote: This patch is much better and covers my previous concerns. I just find an issue with UPG. It is not created for non-posix users when UPGs are enabled: # echo Secret123 | ipa migrate-ds ldap://ldap.example.com --with-compat

Re: [Freeipa-devel] [PATCH] 0030 Allow multi-line CSV parameters

2012-03-29 Thread Rob Crittenden
Ondrej Hamada wrote: On 03/22/2012 09:40 AM, Petr Viktorin wrote: Feed individual lines of input into the CSV parser, and include all lines in the output. https://fedorahosted.org/freeipa/ticket/2402 ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 993 disable UPG for migration

2012-03-29 Thread Rob Crittenden
Simo Sorce wrote: On Thu, 2012-03-29 at 11:27 -0400, Rob Crittenden wrote: This patch is much better and covers my previous concerns. I just find an issue with UPG. It is not created for non-posix users when UPGs are enabled: # echo Secret123 | ipa migrate-ds ldap://ldap.example.com

Re: [Freeipa-devel] [PATCH] 993 disable UPG for migration

2012-03-29 Thread Simo Sorce
On Thu, 2012-03-29 at 15:25 -0400, Rob Crittenden wrote: Simo Sorce wrote: On Thu, 2012-03-29 at 11:27 -0400, Rob Crittenden wrote: This patch is much better and covers my previous concerns. I just find an issue with UPG. It is not created for non-posix users when UPGs are enabled:

Re: [Freeipa-devel] [PATCH] 238 Improve automount indirect map error message

2012-03-29 Thread Rob Crittenden
Martin Kosek wrote: When user does not pass a name of parent map in automountmap-add-indirect command, auto.master is used as a default. However, when auto.master does not exist in a given location, we raise NotFound error with a name of a location instead of a name of the missing automount map.

Re: [Freeipa-devel] [PATCH] 0032 Move DNS test skipping to class setup

2012-03-29 Thread Rob Crittenden
Petr Viktorin wrote: Currently, each DNS test case first checks if DNS is configured by creating and deleting a test zone. This takes quite a lot of time. This patch moves the check to the setUpClass method, so the check is only done once for all the tests. On my VM, this makes the DNS

Re: [Freeipa-devel] [PATCH] (master) Support case-insensitive searches for principals during TGS request processing

2012-03-29 Thread Simo Sorce
On Thu, 2012-03-29 at 16:30 +0300, Alexander Bokovoy wrote: This is due to some krbtgt/realm@REALM searches performed in KDC without allowing for principal aliases and therefore no chance to our case-insensitive searches to kick in. Additional discussion is needed, I think, if we want to

Re: [Freeipa-devel] [PATCH] 0029 Check expected error messages in tests

2012-03-29 Thread Rob Crittenden
Petr Viktorin wrote: On 03/26/2012 09:49 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/20/2012 01:39 PM, Petr Viktorin wrote: This patch adds checking error messages, not just types, to the XML-RPC tests. The checking is still somewhat hackish, since XML-RPC doesn't give us structured

[Freeipa-devel] [PATCH] 999 fix failure count interval in kdb backend

2012-03-29 Thread Rob Crittenden
The wrong attribute name was being requested for the failure count interval so it was never being applied. This caused the failure count to never be reset with time. rob From d6595ab23c2ed861076e00036408f1926f5ee842 Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Thu,

[Freeipa-devel] [PATCH 69] Use indexed format specifiers in i18n strings

2012-03-29 Thread John Dennis
Translators need to reorder messages to suit the needs of the target language. The conventional positional format specifiers (e.g. %s %d) do not permit reordering because their order is tied to the ordering of the arguments to the printf function. The fix is to use indexed format specifiers. --